From 23adfeb00327fbdccacc99806acb1a9a073bd8e0 Mon Sep 17 00:00:00 2001 From: Paul Yang Date: Thu, 26 Oct 2017 14:41:43 -0700 Subject: Reserve unknown in Ruby (#3763) * Reserve unknown in ruby * Revert ruby tests. Wait for cpp impl for conformance test * Add conformance test for preserving unknown * Add unknown field conformance test to csharp failure list. * Fix comments * Fix comment * Fix comments * Fix typo * Use stringsink_string directly * Mark hd unused * Remove unused encodeunknown_handlerfunc --- conformance/conformance_php.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'conformance/conformance_php.php') diff --git a/conformance/conformance_php.php b/conformance/conformance_php.php index 2e3f7831..4dc18f59 100755 --- a/conformance/conformance_php.php +++ b/conformance/conformance_php.php @@ -57,10 +57,10 @@ function doTest($request) return $response; } } elseif ($request->getMessageType() == "protobuf_test_messages.proto2.TestAllTypesProto2") { - $response->setSkipped("PHP doesn't support proto2"); - return $response; + $response->setSkipped("PHP doesn't support proto2"); + return $response; } else { - trigger_error("Protobuf request doesn't have specific payload type", E_USER_ERROR); + trigger_error("Protobuf request doesn't have specific payload type", E_USER_ERROR); } } elseif ($request->getPayload() == "json_payload") { try { -- cgit v1.2.3