From 81aeed082ecc35b62f1808234f4a0dd347775b33 Mon Sep 17 00:00:00 2001 From: Thomas Van Lenten Date: Wed, 31 Jan 2018 13:57:50 -0500 Subject: Work around the static analyzer false report. --- objectivec/GPBMessage.m | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/objectivec/GPBMessage.m b/objectivec/GPBMessage.m index a9f8bfe7..2e9fd7c6 100644 --- a/objectivec/GPBMessage.m +++ b/objectivec/GPBMessage.m @@ -753,6 +753,12 @@ void GPBPrepareReadOnlySemaphore(GPBMessage *self) { if (!atomic_compare_exchange_strong(&self->readOnlySemaphore_, &expected, worker)) { dispatch_release(worker); } +#if defined(__clang_analyzer__) + // The Xcode 9.2 (and 9.3 beta) static analyzer thinks worker is leaked + // (doesn't seem to know about atomic_compare_exchange_strong); so just + // for the analyzer, let it think worker is also released in this case. + else { dispatch_release(worker); } +#endif } #pragma clang diagnostic pop -- cgit v1.2.3