From 2506cf5cf4da16386d8cb3908fd054452829cc6a Mon Sep 17 00:00:00 2001 From: depristo Date: Thu, 28 Jun 2018 22:54:43 +0000 Subject: Remove write-strings warning from COPTs. This change reduces the excessive warnings when compiling C++ protobufs like "external/protobuf_archive/python/google/protobuf/pyext/message.cc:2629:1: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]" --- BUILD | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BUILD b/BUILD index c21b631e..27288d94 100644 --- a/BUILD +++ b/BUILD @@ -43,12 +43,13 @@ COPTS = select({ "//conditions:default": [ "-DHAVE_PTHREAD", "-Wall", - "-Wwrite-strings", "-Woverloaded-virtual", "-Wno-sign-compare", "-Wno-unused-function", # Prevents ISO C++ const string assignment warnings for pyext sources. + # no-write-strings is the standard GCC flag as of at least v5. "-Wno-writable-strings", + "-Wno-write-strings", ], }) -- cgit v1.2.3 From 42141fa2f725a9d5e18e60e109744f178432d839 Mon Sep 17 00:00:00 2001 From: mdepristo Date: Sat, 30 Jun 2018 14:56:19 -0700 Subject: Remove unclear comment. --- BUILD | 1 - 1 file changed, 1 deletion(-) diff --git a/BUILD b/BUILD index 27288d94..ce3bd034 100644 --- a/BUILD +++ b/BUILD @@ -47,7 +47,6 @@ COPTS = select({ "-Wno-sign-compare", "-Wno-unused-function", # Prevents ISO C++ const string assignment warnings for pyext sources. - # no-write-strings is the standard GCC flag as of at least v5. "-Wno-writable-strings", "-Wno-write-strings", ], -- cgit v1.2.3