aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/google/protobuf/metadata.h
Commit message (Collapse)AuthorAge
* Down-integrate from google3.Gravatar Feng Xiao2017-03-29
|
* fix compile error on centos in metadata.h for constructors. (#2599)Gravatar michaelpengcn2017-01-27
|
* Integrated internal changes from GoogleGravatar Adam Cozzette2016-11-17
|
* Integrate internal changesGravatar Bo Yang2016-10-10
|
* Integrate google internal changes.Gravatar Jisi Liu2016-03-30
|
* Merge pull request #769 from pkasting/metadataGravatar Feng Xiao2015-09-10
|\ | | | | Fix compile failures building protobuf DLLs on MSVC in Chromium's cod…
| * Change to just not marking the class for exportGravatar Peter Kasting2015-08-27
| |
| * Fix compile failures building protobuf DLLs on MSVC in Chromium's codebase.Gravatar Peter Kasting2015-08-27
| | | | | | | | | | | | | | | | | | | | | | | | When trying to compile the protobuf code as a DLL, and then compile other DLLs with generated .pb.cc/h files that reference InternalMetadataWithArena::InternalMetadataWithArena(Arena*), MSVC gives an "unresolved external symbol" error. This seems to be due to the function being simultaneously exported and inline. Moving it out-of-line fixes things. There are other functions exported and inline as well but de-inlining them doesn't seem to be necessary to get the build working, and I'd rather de-inline as few functions as possible.
* | Down-integrate from google3.Gravatar Feng Xiao2015-08-22
| |
| * Define GOOGLE_ATTRIBUTE_NOINLINE for MSVC. Workaround for VS2015 Release ↵Gravatar Douglas Heriot2015-08-22
|/ | | | | | | | | | | build compiler bug. See issue #240 - MSVC in VS2015 seems to inline a function it shouldn't. My original workaround was to disable inlining for the whole file, but I found a way to do it on just this specific function using __declspec(noinline). Unfortunately __declspec has to go at the start of the function declaration, while __attribute in GCC can go either before or after. I had to move lots of GOOGLE_ATTRIBUTE_NOLINE to make it compile. I have not yet tested this change with GCC. Will there be other side effects of defining this, given it wasn't previously? I also noticed a few functions marked with both the 'inline' keyword, and GOOGLE_ATTRIBUTE_NOINLINE - huh? Is there an explanation for this, or is it an oversight?
* Down-integrate from internal code base.Gravatar Feng Xiao2014-11-10