aboutsummaryrefslogtreecommitdiffhomepage
path: root/objectivec
Commit message (Collapse)AuthorAge
* Improving the granularity parsing errors (#1623)Gravatar Sergio Campamá2016-06-02
| | | | | | | | | Add more context to GPBCodedInputStream failures. Have GPBMessage parsing apis extract out the GPBCodedInputStream information and expose it. Update HeaderDocs with pointers to all error domains/codes. Expand the unittests to cover the full set of errors reported. Fixes https://github.com/google/protobuf/issues/1618
* Merge pull request #1620 from sergiocampama/cleanup1Gravatar Thomas Van Lenten2016-05-30
|\ | | | | Removing unused GPBExceptionMessageKey
| * Removing unused GPBExceptionMessageKeyGravatar Sergio Campama2016-05-27
| | | | | | | | https://github.com/google/protobuf/issues/1618
* | Merge pull request #1617 from thomasvl/more_warningsGravatar Thomas Van Lenten2016-05-27
|\ \ | |/ |/| Add -Woverriding-method-mismatch.
| * Add -Woverriding-method-mismatch.Gravatar Thomas Van Lenten2016-05-27
| | | | | | | | | | | | | | Fixes up the code to avoid some issues with isEqual: methods. Opened https://github.com/google/protobuf/issues/1616 to track the KVC collision.
* | fix expected class checking in GPBSetMessageRepeatedFieldGravatar Jon Wall2016-05-26
|/ | | | | This is currently checking for the wrong class for enums and NSMutableArray fields.
* Add more warnings to for the ObjC runtime buildGravatar Thomas Van Lenten2016-05-25
| | | | | | | | | | | | | | Working on https://github.com/google/protobuf/issues/1599, specifically: - Turn on more warnings that the Xcode UI calls out with individual controls. - Manually add: -Wundef -Wswitch-enum - Manually add and then diable in the unittests because of XCTest's headers: -Wreserved-id-macro -Wdocumentation-unknown-command - Manually add -Wdirect-ivar-access, but disable it for the unittests and in the library code (via #pragmas to suppress it). This is done so proto users can enable the warning.
* Merge pull request #1595 from thomasvl/objc_travis_tweaksGravatar Thomas Van Lenten2016-05-25
|\ | | | | Automated testing tweaks for ObjC
| * Automated testing tweaks for ObjCGravatar Thomas Van Lenten2016-05-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Move the ObjC tests into the list and exclude them on linux, this will change where in the order they start, since they are longer, it will have other things run in parallel instead of them ending up last and taking the longest. - Switch to the Xcode 7.3 image. - Drop the use of xctool and stream line things through the full_mac_build.sh script. This means we end up with only one build script instead of two. - Tweaks to the mac build script: - Make iOS Xcode version support explicit - Support Debug/Release only building - Change the OS X min parallel count to 2 to better deal with VMs. - Split the travis ios tests into the two Xcode Configurations as the logs are choking travis.
* | Better support for using the proto library from a framework.Gravatar Thomas Van Lenten2016-05-24
|/ | | | | | | | | | | | | | - Add generator constant for the default framework name. - Add generator api for making the CPP symbol from the name. - Add generator api to see if it is a bundled proto file. - Output a CPP conditional and two imports for the core library headers. - Add helper for generating the #import for file headers to deal with the framework imports. - Add a reference from the unittests to a WKT to use that to inspect how imports generate. - Update the podspec to define the CPP symbol and require pods 1.0 (or later). Fixes https://github.com/google/protobuf/issues/1457
* Make the CocoaPods integration tests more robustGravatar Thomas Van Lenten2016-05-20
| | | | | | | - Env solution doesn't seem to always work, use template pod files and copy them in place instead. - Flush the pods cache before and after runs. - Make pod install verbose to have the info incase something goes wrong.
* Add shared schemes for the CocoaPods integration testsGravatar Thomas Van Lenten2016-05-19
| | | | | Otherwise the projects have to be opened once to create user schemes for the command line builds to work.
* CocoaPod Integration TestsGravatar Thomas Van Lenten2016-05-19
| | | | | | | | - Add an Xcode 6.3 created default iOS Project. - Add an Xcode 6.3 created default OS X Project. - Add Podfiles to for both that use Protobufs from within the tree. - Add a script to run the tests (and cleanup) to help confirm the state of the Protobuf.podspec and sources.
* Expand the OS X/Xcode gitignoresGravatar Thomas Van Lenten2016-05-19
| | | | | - Add the folder CocoaPods will add to the root folder. - Move and expand the entries in the objectivec directory.
* Declare an init and avoid passing NULL to initWithValue:count:Gravatar Thomas Van Lenten2016-05-10
| | | | Fixes https://github.com/google/protobuf/issues/1189
* Update descritpor protos for objcGravatar Jisi Liu2016-04-29
|
* Merge the script fix.Gravatar Jisi Liu2016-04-29
|\
| * Fix cp -r usage to be portable.Gravatar Jisi Liu2016-04-29
| | | | | | | | | | | | | | | | cp -r foo/ bar/ in linux will create a bar/foo directoy. In the objectivec generate descritpor case, well known types will be created in objectivec/google/google/protobuf/.. if the command is run under linux. Adding the trailing period fixes the behavior inconsistency.
* | Merge branch 'master' of github.com:google/protobufGravatar Jisi Liu2016-04-28
|\|
* | Down integrate from Google internal.Gravatar Jisi Liu2016-04-28
| |
| * Fix up -hash/-isEqual: for bool storage.Gravatar Thomas Van Lenten2016-04-27
| | | | | | | | | | | | | | Both methods weren't checking the has_bits (where the bools are stored), so it resulted in invalid results. Add a test that should shake out something like this in the future also.
| * Proper checking of enum with non zero defaultGravatar Thomas Van Lenten2016-04-26
|/ | | | | | | | | proto2 syntax allows the first enum to have a non zero value. This means any field using that default has a non zero default without having an explicit default being set. So when deciding what runtime info is needed, don't rely on an explicit default, always check that the values aren't zero. Fixes https://github.com/google/protobuf/issues/1453
* ObjC support for failing the build in the generated WKTs are out of dateGravatar Thomas Van Lenten2016-04-20
| | | | | | | | - Always generated into a temp directory so we can see if things changed. - Add a flag to control exiting with error when stale vs updating. This should let the continuous builds error out when ObjC needs to have the checked in sources updated.
* Regenerate the WKT to pick up current changes to the proto files.Gravatar Thomas Van Lenten2016-04-19
|
* Fix comment typoGravatar Thomas Van Lenten2016-04-19
|
* Merge pull request #1391 from thomasvl/string_tweaksGravatar Thomas Van Lenten2016-04-06
|\ | | | | ObjC String followups: one test case only addition, behavior change for invalid UTF-8
* | Updating Xcode Settings to use iOS 9.3Gravatar Geoffrey Wiseman2016-04-06
| | | | | | | | Update the simulators used for some tests under Xcode 7.3 to be iOS 9.3.
| * Error during parsing for invalid UTF-8 instead of dropping dropping data.Gravatar Thomas Van Lenten2016-04-05
| | | | | | | | | | | | | | This seems to be some code evolution side effects. Back when there was a custom string class, we couldn't really error when we finally saw the string was bad so we had to return the empty string, but now that full validation is done up front, it can error out.
| * Add tests to ensure we read strings with BOMs so we don't forget about ↵Gravatar Thomas Van Lenten2016-04-05
|/ | | | lessons of the past.
* Add -position and -isAtEnd for use when manually parsing input streams.Gravatar Thomas Van Lenten2016-04-01
|
* The message was autoreleased, the -releases are an over release.Gravatar Thomas Van Lenten2016-03-24
|
* Only create the readonlySemaphore on demand.Gravatar Thomas Van Lenten2016-03-21
| | | | | | This will lower the amount of dispatch_semaphores created per Message when the full object tree isn't walked in a way that would require them to be created. Uses a dispatch_once_t for one time init of the dispatch_semaphore.
* Shrink ObjC overhead (generated size and some runtime sizes)Gravatar Thomas Van Lenten2016-03-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NOTE: This is a binary breaking change as structure sizes have changed size and/or order. - Drop capturing field options, no other options were captured and other mobile targeted languages don't try to capture this sort information (saved 8 bytes for every field defined (in static data and again in field descriptor instance size data). - No longer generate/compile in the messages/enums in descriptor.proto. If developers need it, they should generate it and compile it in. Reduced the overhead of the core library. - Compute the number of has_bits actually needs to avoid over reserving. - Let the boolean single fields store via a has_bit to avoid storage, makes the common cases of the instance size smaller. - Reorder some flags and down size the enums to contain the bits needed. - Reorder the items in the structures to manually ensure they are are packed better (especially when generating 64bit code - 8 bytes for every field, 16 bytes for every extension, instance sizes 8 bytes also). - Split off the structure initialization so when the default is zero, the generated static storage doesn't need to reserve the space. This is batched at the message level, so all the fields for the message have to have zero defaults to get the saves. By definition all proto3 syntax files fall into this case but it also saves space for the proto2 that use the standard defaults. (saves 8 bytes of static data for every field that had a zero default) - Don't track the enums defined by a message. Nothing in the runtime needs it and it was just generation and runtime overhead. (saves 8 bytes per enum) - Ensure EnumDescriptors are started up threadsafe in all cases. - Split some of the Descriptor initialization into multiple methods so the generated code isn't padded with lots of zero/nil args. - Change how oneof info is feed to the runtime enabling us to generate less static data (8 bytes saved per oneof for 64bit). - Change how enum value informat is capture to pack the data and only decode it if it ends up being needed. Avoids padding issues causing bloat of 64bit, and removes the needs for extra pointers in addition to the data (just the data and one pointer now).
* Fix up handing of fields with leading names that should be all caps.Gravatar Thomas Van Lenten2016-03-08
| | | | Add a compile test to confirm things are working as expected.
* HeaderDoc support in the library and generated sourcesGravatar Thomas Van Lenten2016-03-07
| | | | | | | - Convert most of the core library headers over to HeaderDoc format. - Switch the generated comments over to HeaderDoc. - Create GPBCodedOutputStream_PackagePrivate and move some things into there that should be more internal.
* Support ObjC Generic CollectionsGravatar Thomas Van Lenten2016-02-18
| | | | | | | - Extend GPB*ObjectDictionary to support generic syntax. - Update the generator to output generics so the enclosed type is exposed for compiler checks. - Use generics in a the public interfaces. - Update the generated sources that are checked in.
* Bump up travis to Xcode 7.2Gravatar Thomas Van Lenten2016-02-16
| | | | | - Update simulator versions used. - Mark the iOS tests as flaky while trying to dig out the root cause.
* Rewrap the lineGravatar Dongjoon Hyun2016-02-11
|
* Remove redundant `the` in comments.Gravatar Dongjoon Hyun2016-02-03
|
* Integrate from google internal.Gravatar Jisi Liu2016-01-29
| | | | | Java files are moved to un-do the hack in the prevous commit, which moved the java files to the original position for integration.
* Merge pull request #1129 from dongjoon-hyun/fix_typos_in_README_and_CHANGESGravatar Feng Xiao2016-01-12
|\ | | | | Fix typos in README.md/CHANGES.txt
* | Release the semaphore in dealloc, fixing leak.Gravatar Thomas Van Lenten2016-01-12
| |
| * Fix typos in README.md/CHANGES.txtGravatar Dongjoon Hyun2016-01-11
|/
* Remove the stale reference to test no longer around, and keep the ↵Gravatar Thomas Van Lenten2016-01-07
| | | | performance test limited to just performance tests.
* Update objectivec/google/protobuf/Type.pbobjc.mGravatar Thomas Van Lenten2016-01-05
| | | | | commit e841bac4fcf47f809e089a70d5f84ac37b3883df seems to have updated the generated .pbobjc.h but not the .pbobjc.m to match.
* Have the tests rely on the autocreator behaviors.Gravatar Thomas Van Lenten2016-01-05
| | | | | Incase developers look at the tests for examples, have them rely on the autocreators also.
* Merge branch master into v3.0.0-beta-2Gravatar Feng Xiao2015-12-21
|\
| * Drop all use of OSSpinLockGravatar Thomas Van Lenten2015-12-17
| | | | | | | | | | | | | | | | | | | | | | | | | | Apple engineers have pointed out that OSSpinLocks are vulnerable to live locking on iOS in cases of priority inversion: . http://mjtsai.com/blog/2015/12/16/osspinlock-is-unsafe/ . https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20151214/000372.html - Use a dispatch_semaphore_t within the extension registry. - Use a dispatch_semaphore_t for protecting autocreation within messages. - Drop the custom/internal GPBString class since we don't have really good numbers to judge the locking replacements and it isn't required. We can always bring it back with real data in the future.
* | Down-integrate from internal code base.Gravatar Feng Xiao2015-12-11
|/
* Update the min toolchain for iOS/OS X to be Xcode 7Gravatar Thomas Van Lenten2015-12-10
| | | | | | | - Let Xcode update the projects, schemes, and info.plists. - Add workaround for shallow analyzer issues in current Xcode versions (deep analyze gets things correct). - Tweak the Swift based tests to avoid warnings from Xcode 7's XCTest using optionals for autoenclosure results. - No longer tag the ObjC iOS travis test as flaky, xctool seems to manage the simulator pretty well.