| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
| |
Change-Id: Ic07a7c664930209974244c66885d672288982610
|
| |
|
|
| |
Change-Id: I997012e7e9b58d9ec8b2f59429d71c98d81aa40d
|
| |\
| |
| | |
Fix compatibility issues for the future GeneratedMessageV3 change.
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently some public API methods are defined in GenreatedMessage.java
and they have a generric return type:
class GeneratedMessage {
class Builder<BuilderType extends Builder<BuilderType>> {
public BuilderType setField(...);
public BuilderType setExtension(...);
}
}
With these definitions, the compiled byte code of a callsite will have
a direct reference to GeneratedMessage. For example:
fooBuilder.setField(...);
becomes:
##: invokevirtual // Method Builder.setField:(...)LGeneratedMessage.Builder
##: checkcast // class Builder
This will prevent us from updating generated classes to subclass a
different versioned GeneratedMessageV3 class in the future (we can't do
it in a binary compatible way).
This change addresses the problem by overriding these methods directly
in the generated class:
class Foo {
class Builder extends GeneratedMessage.Builder<Builder> {
public Builder setField(...) {
return super.setField(...);
}
}
}
After this, fooBuilder.setField(...) will be compiled to:
##: invokevirtual // Method Builder.setField:(...)LFoo.Builder
The callsites will no longer reference GeneratedMessage directly and we
can change Foo to subclass GeneratedMessageV3 without breaking binary
compatiblity.
The downside of this change is:
1. It increases generated code size (though it saves some instructions
on the callsites).
2. We can never stop generating these overrides because doing that
will break binary compatibility.
Change-Id: I879afbbc1325a66324a51565e017143489b06e97
|
| | |
|
| |\
| |
| | |
Merge C# changes from master to 3.0.0-beta4
|
| | |
| |
| |
| |
| |
| | |
platform (#1727)
This also updates the version number to 3.0.0-beta4
|
| | |
| |
| |
| |
| |
| |
| | |
We now just perform the optimization within AddRange itself.
This is a breaking change in terms of "drop in the DLL", but is
source compatible, which should be fine.
|
| | |
| |
| |
| | |
(Also fix a few more C# 6-isms.)
|
| | |
| |
| |
| | |
This fixes issue #1730.
|
| |/ |
|
| |\
| |
| | |
Update version number to 3.0.0-beta-4
|
| | | |
|
| |\ \
| | |
| | | |
Comment out lite conformance test.
|
| | | | |
|
| |/ /
| |
| |
| | |
The 'lite' generator flag is no longer supported.
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
Remove the baseline files from the make dist file list.
|
| |/
|
|
|
| |
https://github.com/google/protobuf/pull/1762 remove the files, but I forgot to
update Makefile.am to remove them.
|
| | |
|
| |\
| |
| | |
Modify csharp README since there are now two NuGet packages
|
| |\ \
| | |
| | | |
Remove unnecessary reflection call
|
| | | |
| | |
| | |
| | |
| | | |
This is the only call to TypeExtensions.IsValueType, so we can remove
that method, making the whole type conditionally compiled out for .NET 3.5
|
| |\ \ \
| |/ /
|/| | |
Drop the performace baselines.
|
| |/ /
| |
| |
| |
| | |
We weren't really using them, and the nested path causes checkout problems
on windows.
|
| |\ \
| | |
| | | |
Don't #import the .m files.
|
| |\ \ \
| | | |
| | | | |
Change placement of DebuggerNonUserCodeAttribute
|
| |\ \ \ \
| | | | |
| | | | | |
Make sure also Solaris x86 gets PATH_MAX
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This does not affect the generated code.
If we decide we want to apply attributes to generated types, we should start by
just reverting this change.
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Fix problems detected when integrating the code to our internal repo.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
As bazel folks are looking at getting auto generation of module maps going and
the importing of sources files causes issues there. We were only do it to
hack around some of the apple linker behaviors around objc classes and
categories, but even that isn't complete and CocoaPods was already doing -ObjC,
and developers not using pods could have still needed it to ensure everything
was linked anyways; so drop the hack of importing sources.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Fix spelling
|
| | | | | | | |
|
| | | | |/ /
| | |/| | |
|
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
Fixed failing JS tests
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
A couple of small tweaks were needed to fix test failures that were
inadvertently introduced in the last down integration. I also had to add
the map.js file which was missing.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
add nullable qualifier to return types that can be nil, to support Swift 2 try-catch syntax
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add the `nullable` qualifier to return types of Objective-C methods that
can return a nil due to errors. This change makes these methods
compatible with the Swift 2 try-catch syntax.
|
| | | | | | |
|
| | |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I think this has caught everything.
I've left a stub for attributes to be applied to the types themselves, but we don't currently need anything.
Follow-up commit will include the changes to generated code itself.
Fixes #1671.
|
| | | | | |
|
| | |/ /
|/| | |
|
| |\ \ \
| |/ /
|/| | |
Add JsonParseOptions to ignore unknown fields
|
| |\ \ \
| | | |
| | | | |
Fix some failing travis tests.
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
1. Add missing header file to Makefile.am.
2. Re-generate objectivec generated code for well-known types.
Change-Id: If28217c701cf8bd739ea0db240e9eee600f23ee7
|
Feng Xiao
Feng Xiao
Jon Skeet
Jon Skeet
Jisi Liu
Thomas Van Lenten
Jos Hickson
Dagobert Michelsen
Adam Cozzette
Adam Cozzette
Dia Kharrat
Otto Kekäläinen