From a921439a4eb5b0d96182748e779c78e2f6a41a5f Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Tue, 11 Dec 2018 18:48:51 -0500 Subject: Cleanup patch; Moving defvar to toplevel MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Move `defvar`s used to silence warnings outside of eval-when-compile. Make sure they don't actually give a value to the var. * pg-init.el: Simplify. Use (if t ...) to avoid running `require` at compile-time. Don't add subdirs to load-path here since this code is never used. (pg-init--script-full-path, pg-init--pg-root): Inline their definition into their sole user. * generic/proof-utils.el (proof-resize-window-tofit): Inline definitions of window-leftmost-p and window-rightmost-p previously in proof-compat.el. * lib/proof-compat.el (proof-running-on-win32): Remove, not used. (mac-key-mode): Remove, there's no carbon-emacs-package-version in Emacs≥24.3. (pg-custom-undeclare-variable): Use dolist. (save-selected-frame): Remove, save-selected-window also saves&restores the selected frame at the same time. Update all users (which already used save-selected-window around it). (window-leftmost-p, window-rightmost-p, window-bottom-p) (find-coding-system): Remove, unused. * hol-light/hol-light.el (caml-font-lock-keywords): Don't try to defvar it to a dummy value and... (hol-light): ...check its existence before using it instead. * coq/coq.el (coq-may-use-prettify): Simplify initialization. --- pg-init.el | 25 +++++-------------------- 1 file changed, 5 insertions(+), 20 deletions(-) (limited to 'pg-init.el') diff --git a/pg-init.el b/pg-init.el index a6405361..3a2e5492 100644 --- a/pg-init.el +++ b/pg-init.el @@ -3,7 +3,7 @@ ;; This file is part of Proof General. ;; Portions © Copyright 1994-2012 David Aspinall and University of Edinburgh -;; Portions © Copyright 2003, 2012, 2014 Free Software Foundation, Inc. +;; Portions © Copyright 2003-2018 Free Software Foundation, Inc. ;; Portions © Copyright 2001-2017 Pierre Courtieu ;; Portions © Copyright 2010, 2016 Erik Martin-Dorel ;; Portions © Copyright 2011-2013, 2016-2017 Hendrik Tews @@ -42,25 +42,10 @@ ;;; Code: ;;;###autoload -(eval-and-compile - (defvar pg-init--script-full-path - (or (and load-in-progress load-file-name) - (bound-and-true-p byte-compile-current-file) - (buffer-file-name))) - (defvar pg-init--pg-root - (file-name-directory pg-init--script-full-path))) - -;;;###autoload -(unless (bound-and-true-p byte-compile-current-file) - ;; This require breaks compilation, so it must only run when loading the package. - (require 'proof-site (expand-file-name "generic/proof-site" pg-init--pg-root))) - -(eval-when-compile - (let ((byte-compile-directories - '("generic" "lib" - "coq" "easycrypt" "pghaskell" "pgocaml" "pgshell" "phox"))) - (dolist (dir byte-compile-directories) - (add-to-list 'load-path (expand-file-name dir pg-init--pg-root))))) +(if t (require 'proof-site + (expand-file-name "generic/proof-site" + (file-name-directory + (or load-file-name buffer-file-name))))) (provide 'pg-init) ;;; pg-init.el ends here -- cgit v1.2.3