From a921439a4eb5b0d96182748e779c78e2f6a41a5f Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Tue, 11 Dec 2018 18:48:51 -0500 Subject: Cleanup patch; Moving defvar to toplevel MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Move `defvar`s used to silence warnings outside of eval-when-compile. Make sure they don't actually give a value to the var. * pg-init.el: Simplify. Use (if t ...) to avoid running `require` at compile-time. Don't add subdirs to load-path here since this code is never used. (pg-init--script-full-path, pg-init--pg-root): Inline their definition into their sole user. * generic/proof-utils.el (proof-resize-window-tofit): Inline definitions of window-leftmost-p and window-rightmost-p previously in proof-compat.el. * lib/proof-compat.el (proof-running-on-win32): Remove, not used. (mac-key-mode): Remove, there's no carbon-emacs-package-version in Emacsā‰„24.3. (pg-custom-undeclare-variable): Use dolist. (save-selected-frame): Remove, save-selected-window also saves&restores the selected frame at the same time. Update all users (which already used save-selected-window around it). (window-leftmost-p, window-rightmost-p, window-bottom-p) (find-coding-system): Remove, unused. * hol-light/hol-light.el (caml-font-lock-keywords): Don't try to defvar it to a dummy value and... (hol-light): ...check its existence before using it instead. * coq/coq.el (coq-may-use-prettify): Simplify initialization. --- isar/isabelle-system.el | 5 +++-- isar/isar.el | 9 +++++---- 2 files changed, 8 insertions(+), 6 deletions(-) (limited to 'isar') diff --git a/isar/isabelle-system.el b/isar/isabelle-system.el index e399474b..0b61aab0 100644 --- a/isar/isabelle-system.el +++ b/isar/isabelle-system.el @@ -1,6 +1,7 @@ ;; isabelle-system.el --- Interface with Isabelle system ;; ;; Copyright (C) 2000 LFCS Edinburgh, David Aspinall. +;; Copyright (C) 2018 Free Software Foundation, Inc. ;; ;; Author: David Aspinall ;; Maintainer: Proof General maintainer @@ -20,8 +21,8 @@ (require 'scomint) (require 'proof-site) (require 'proof-menu) - (require 'proof-syntax) - (defvar proof-assistant-menu)) + (require 'proof-syntax)) +(defvar proof-assistant-menu) (declare-function mapcan "cl-extra") ; spurious bytecomp warning diff --git a/isar/isar.el b/isar/isar.el index bb755d4f..917f8f6a 100644 --- a/isar/isar.el +++ b/isar/isar.el @@ -1,6 +1,7 @@ ;; isar.el --- Major mode for Isabelle/Isar proof assistant ;; ;; Copyright (C) 1994-2010 LFCS Edinburgh. +;; Copyright (C) 2018 Free Software Foundation, Inc. ;; ;; License: GPL (GNU GENERAL PUBLIC LICENSE) ;; @@ -24,10 +25,10 @@ (require 'proof-syntax) (require 'pg-goals) (require 'pg-vars) - (require 'outline) - (defvar comment-quote-nested) - (defvar isar-use-find-theorems-form) - (defvar isar-use-linear-undo)) + (require 'outline)) +(defvar comment-quote-nested) +(defvar isar-use-find-theorems-form) +(defvar isar-use-linear-undo) (require 'proof) (require 'isabelle-system) ; system code -- cgit v1.2.3