From 98fac43fe2252c58a5ce4d8415924bf355e728b7 Mon Sep 17 00:00:00 2001 From: asraa Date: Mon, 16 Mar 2020 11:46:20 -0400 Subject: fix broken build (#3509) Signed-off-by: Asra Ali --- projects/envoy/build.sh | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'projects/envoy') diff --git a/projects/envoy/build.sh b/projects/envoy/build.sh index 39ef1b26..9ca013cc 100755 --- a/projects/envoy/build.sh +++ b/projects/envoy/build.sh @@ -31,6 +31,14 @@ FUZZER_DICTIONARIES="\ # file. Since the build runs with `-Werror` this will cause it to break, so we # use `--conlyopt` and `--cxxopt` instead of `--copt`. # +# NOTE: We ignore -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION. All envoy fuzz +# targets link this flag through their build target rule. Passing this in via CLI +# will pass this to genrules that build unit tests that rely on production +# behavior. Ignore this flag so these unit tests don't fail by using a modified +# RE2 library. +# TODO(asraa): Figure out how to work around this better. +CFLAGS=${CFLAGS//"-DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION"/} +CXXFLAGS=${CXXFLAGS//"-DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION"/} declare -r EXTRA_BAZEL_FLAGS="$( for f in ${CFLAGS}; do echo "--conlyopt=${f}" "--linkopt=${f}" -- cgit v1.2.3