From 89efd5717ab26cf626ceb67964b9b4af8820e52c Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 31 May 2013 20:40:07 -0400 Subject: emacs: Use streaming S-expr parser for search In addition to being the Right Thing to do, this noticeably improves the time taken to display the first page of search results, since it's roughly an order of magnitude faster than the JSON parser. Interestingly, it does *not* significantly improve the time to completely fill a large search buffer because for large search buffers, the cost of creating author invisibility overlays and inserting text (which slows down with more overlays) dominates. However, the time required to display the first page of results is generally more important to the user experience. --- test/emacs | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'test') diff --git a/test/emacs b/test/emacs index e3cf4690..5bc3efcc 100755 --- a/test/emacs +++ b/test/emacs @@ -858,7 +858,7 @@ test_expect_success "Rendering HTML mail with images" \ test_begin_subtest "Search handles subprocess error exit codes" cat > notmuch_fail < notmuch_fail <&2 echo This is another warning >&2 exit 0 @@ -905,8 +903,6 @@ test_emacs "(let ((notmuch-command \"$PWD/notmuch_fail\")) (test-output))" sed -i -e 's/^\[.*\]$/[XXX]/' ERROR test_expect_equal "$(cat OUTPUT; echo ---; cat MESSAGES; echo ---; cat ERROR)" "\ -Error: Unexpected output from notmuch search: -This is output End of search results. --- This is a warning (see *Notmuch errors* for more details) -- cgit v1.2.3