From 8015cbff263606f009b5750d23b28ee332c25db8 Mon Sep 17 00:00:00 2001
From: Justus Winter <4winter@informatik.uni-hamburg.de>
Date: Sun, 22 Jan 2012 06:14:57 +0100
Subject: python: fix error handling

Before 3434d1940 the return values of libnotmuch functions were
declared as c_void_p and the code checking for errors compared the
returned value to None, which is the ctypes equivalent of a NULL
pointer.

But said commit wrapped all the data types in python classes and the
semantic changed in a subtle way. If a function returns NULL, the
wrapped python value is falsish, but no longer equal to None.
---
 bindings/python/notmuch/message.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'bindings/python/notmuch/message.py')

diff --git a/bindings/python/notmuch/message.py b/bindings/python/notmuch/message.py
index d40a575d..883ed233 100644
--- a/bindings/python/notmuch/message.py
+++ b/bindings/python/notmuch/message.py
@@ -117,7 +117,7 @@ class Messages(object):
         :TODO: Make the iterator work more than once and cache the tags in
                the Python object.(?)
         """
-        if msgs_p is None:
+        if not msgs_p:
             raise NotmuchError(STATUS.NULL_POINTER)
 
         self._msgs = msgs_p
@@ -349,7 +349,7 @@ class Message(Python3StringMixIn):
               automatically delete the parent object once all derived
               objects are dead.
         """
-        if msg_p is None:
+        if not msg_p:
             raise NotmuchError(STATUS.NULL_POINTER)
         self._msg = msg_p
         #keep reference to parent, so we keep it alive
@@ -407,7 +407,7 @@ class Message(Python3StringMixIn):
 
         msgs_p = Message._get_replies(self._msg)
 
-        if msgs_p is None:
+        if not msgs_p:
             return EmptyMessagesResult(self)
 
         return Messages(msgs_p, self)
-- 
cgit v1.2.3