| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
| |
Hopefully this will save some people some head-scratching trying
to figure out how to use it.
|
| |
|
|
|
|
| |
The documentation is quite clear about this case.
With this, we can now byte compile without warnings.
|
| |
|
|
|
| |
We changed from "query" to "thread-id" a while ago, and broke this
error message at the time. Fix it now.
|
| |
|
|
|
| |
Without these, emacs was complaining about "assignment to free variable",
(though only when byte compiling, which is why we didn't notice earlier).
|
| |
|
|
| |
Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
|
| |
|
|
|
|
|
| |
Avoding these is nicer to users, text editors, and our poor little
notmuch.el code itself that would get confused when seeing a copy of
itself in email. (Of course, we should still fix that bug, but this
workaround is good nonetheless.)
|
| |
|
|
|
|
|
|
| |
This patch add notmuch-search-hook that gets run when we
after displaying search results
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Cc:Keith Packard <keithp@keithp.com>
|
| |
|
|
|
|
| |
This is basically right, (I get a message buffer with all the mails
quoted), but somehow notmuch reply is reversing the messages. That's a
nuisance.
|
| |
|
|
|
|
|
| |
This makes things like the goto-address system bring up the right
message composition window.
Signed-off-by: Keith Packard <keithp@keithp.com>
|
| |
|
|
|
|
|
|
|
| |
I created the notmuch-show-hook precisely so I could add these two
options, but I suspect most people will want them, so I just made them
the default. If you don't want them, you can use remove-hook to get
rid of this.
Signed-off-by: Keith Packard <keithp@keithp.com>
|
| |
|
|
|
|
| |
This keeps them from wrapping.
Signed-off-by: Keith Packard <keithp@keithp.com>
|
| |
|
|
|
|
|
|
|
| |
I wanted to enable got-address-mode and visual-line-mode in my show
windows to make messages easier to read and URLs easier to
follow. This hook allows the user to run arbitrary code each time a
message is shown.
Signed-off-by: Keith Packard <keithp@keithp.com>
|
| |
|
|
|
| |
Just using describe-mode for now, (though something more specialized
would be better).
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is what most people want for a _search_ command. It's often
different for actually reading mail in an inbox, (where it makes more
sense to have results displayed in chronological order), but in such a
case, ther user is likely using an interface that can simply pass the
--sort=oldest-first option to "notmuch search".
Here we're also change the sort enum from NOTMUCH_SORT_DATE and
NOTMUCH_SORT_DATE_REVERSE to NOTMUCH_SORT_OLDEST_FIRST and
NOTMUCH_SORT_NEWEST_FIRST. Similarly we replace the --reverse option
to "notmuch search" with two options: --sort=oldest-first and
--sort=newest-first.
Finally, these changes are all tracked in the emacs interface, (which
has no change in its behavior).
|
| |
|
|
|
|
|
|
| |
The documentation for 'next-line' suggests that 'forward-line' is a
better choice for non-interactive usage. That appears to be the case
here; using next-line caused emacs to spin forever for me.
Signed-off-by: Keith Packard <keithp@keithp.com>
|
| |
|
|
|
|
|
| |
This is the default separator used by mailman, so there's a lot of
clutter in thread displays without this. Also, we not provide a nice
variable to the user (notmuch-show-signature-regexp) for configuring
this.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
I think there's a GMime bug that we're getting parts decoded without a
final newline (the encoded parts seem to have them just fine). We can
workaround the bug easily enough by finding a part-closing delimiter
that is not at the beginning of a line, and if so, just insert a
newline.
Without this, the one-line-summary of the next message would continue
on the same line as the last line of the previous message, (and this
would often happen for mailing-list messages where mailman would add
an extra part for its signature block).
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it much easier to actually read the subject lines.
The user can set notmuch-search-authors-width to control the width of
the column.
Two possible ideas for improving this support further:
1. Make the excess authors invisible instead of removing them from
the buffer, (which means that isearch could still find them).
2. Have the user variable control a percentage of the window width
rather than being a fixed number of columns.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we're actually adding text to the buffer for the indentation,
our old aproach of using positions to record regions to manipulate is
now longer correct. Fortunately, it's easy to switch from positions to
markers which are robust, (just call point-marker instead of point and
all relevant functions accept markers as well as points).
I also finally fixed the bug where the text "[6 line signature]" we
display was causing the one-line-summary of the next message to be on
its same line rather than at the beginning of the next line where it
belongs.
|
| |
|
|
|
|
|
| |
Currently just supports viewing all MIME parts in the message. There's
not yet support for selecting and viewing individual parts, but that
should be easy to add from here, (now that we've found
mm-display-parts to do all the heavy lifting).
|
| |
|
|
| |
Available from either the "search" or the "show" view.
|
| |
|
|
|
| |
Not only is "load" probably the wrong thing, but loading cl-seq befoe
cl can cause complaints anyway.
|
| |
|
|
|
| |
This ended up being a bit easier than I thought. Just flip the controlling
variable and then run `notmuch-search-refresh-view'.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This gives us two different default search orders: The inbox view that
comes up from "M-x notmuch" is sorted in chronological order (oldest
threads first). A new global search "M-x notmuch-search" will instead
be in reverse chronological order (newest threads first).
Any filtered searches retain the sort order of the search being
filtered.
There's not yet any interface for changing the sort order of a search
after it is constructed.
|
| |
|
|
|
|
| |
I wrote these originally jsut for debugging. They've never been hooked
up to any keybinding and the existing "M-x visible-mode" does what's
needed anyway.
|
| |
|
|
|
|
| |
This way we get to take advantage of the configuration of the user's
email addresses in notmuch, (rather than expecting the user to
configure all of their email addresses in message mode as well).
|
| |
|
|
|
|
|
| |
We were just starting to get "notmuch reply" into shape in order to
provide the needed functionality here, but then I realized that the
message-reply function built into emacs is already more functional,
(at least for the case of replying to a single message).
|
| |
|
|
|
| |
We were stripping off the "id:" portion of the identifier, only to
put it back on again in all cases. Stop this madness.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Previously, when selecting a thread to view from the search buffer, we
would advance the point by one line before showing the thread, (so
that it would be ready to show the next thread once the user was done
with the current thread). This was annoying when the user temporarily
exited the thread view, (because the "wrong" thread was then selected
in the search view).
We get a more consistent experience by waiting to advance until the
user has finished viewing one thread and is ready to view the next.
|
| |
|
|
|
| |
These were recently broken with the change of "notmuch search" to
prefix thread IDs with "thread:" rather than printing them raw.
|
| |
|
|
|
| |
And change the display code in emacs to display the one-line summary
in inverse video.
|
| |
|
|
|
|
| |
The recent change of the hidden thread-ID syntax caused this message
to instead be replaced with a cryptic "search failed" error and an
internal regular expression. Put our nice message back.
|
| |
|
|
|
|
| |
This is in place now citations and signatures. We'll still need to
add something else for hidden messages (those that are already
read and hidden away).
|
| |
|
|
|
| |
This is useful for when the rest of the thread is visible on screen so
the user really has read the rest of it.
|
| |
|
|
|
|
|
|
|
|
|
| |
The more general command is more consistent, and more useful.
We also fix "notmuch search" to output copy-and-pasteable search terms
for the thread with "thread:" prepended already. Similarly, the
message-ID in the output of "notmuch show" is also now printed as a
valid search term, ("id:<message-id>" rather than "ID: <message-id>").
Naturally, the emacs code is also changed to track these changes.
|
| |
|
|
|
|
| |
The magic space bar is nice, but sometimes there's a message with a
long attachment that I just want to skip, but still consider the
message marked as read.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had implemented this intentionally originally, thinking that it
would be important to see the last message scroll all the way off
screen before the next press of the magic space bar would go and
archive away the whole thread.
But in practice, that just turns out to be annoying, (especially for a
long sequence of single-message threads where the space bar has to be
pressed twice for every one). It's actually quite easy to know if it's
"safe" to press the space bar expecting just a scroll instead of an
archive by simply looking down and seeing if the current window is
full.
And as for the total lack of undo with all of this, I'm getting by by
simply using x to get back to the search view, and then going back
into the thread of interest.
|
| |
|
|
| |
With the obvious keybinding.
|
| |
|
|
|
|
|
| |
More magic for the magic space bar: If a thread is entirely open,
(such as when viewing an old thread where every message is read), the
space bar now visits each message in turn (rather than skipping all of
the unread messages).
|
| |
|
|
|
|
|
|
| |
Otherwise known as "Backspace" on keyboards in the real, (rather than
emacs), world. This will go by screenfuls for long messages, and
message by message for short messages. So it does the reverse of the
magic space bar, (but without reversing any tag-changing magic that
the magic space bar might have done).
|
| |
|
|
|
| |
This takes advantage of the new filename output just added to "notmuch
show".
|
| |
|
|
|
| |
Make at least some attempt to distinguish internal variables from
those that the user is expected to fiddle with.
|
| |
|
|
|
|
|
|
|
| |
Chances are, a signature above a certain threshold isn't just a
signature, (for example, it could be an encrypted messages tacked onto
the end of the file, or could be any sort of PS.)
We add a new variable, notmuch-show-signature-lines-max that can be
used to configure the threshold, (set to 6 by default for now).
|
| |
|
|
| |
Previously, it was reporting that all signatures were 0 lines.
|
| |
|
|
|
|
| |
Presumably the user is trying to view this thread for a reason, so
it's better to actually show *something* rather than just the summary
lines.
|
| |
|
|
|
| |
If there's nothing to scroll but we're not yet on the first or last
message then move point to that message.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I noticed that these functions would sometimes leave point on an
invisible character[*]. The problem would be that point would appear
to be on a particular message, but adding or removing a tag would
actually add/remove a tag from the *previous* message.
Fix the C-n and C-p keybindings at least to call the underlying
command and then advance to a visible character. We set this-command
in our overrides so that the temporary-goal-column feature still
works.
[*] The documentation says that command loop is supposed to move point
outside of any invisible region when a command exits. But apparently
not.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clearly some recent code was very fragile, which I noticed in that the
space bar would no longer scroll a long message if it was the only
message in a thread.
This resulted in a lot of churn, but hopefully things are more robust
now, (for example by using new predicates like
notmuch-show-last-message-p rather than doing heuristics based on
(eobp) or (window-end)).
As usual, the presence of invisible characters complicates the task of
making this stuff robust.
|
| |
|
|
|
|
|
|
| |
With the recent change of showing the first unread message, we would
scroll down to the end of the buffer if all messages were already
read. This would confusingly show nothing visible in the window.
Instead, detect this case and move to the beginning of the buffer.
|
Carl Worth
Mikhail Gusarov
Aneesh Kumar K.V
Keith Packard
Ingmar Vanhassel