| Commit message (Collapse) | Author | Age |
... | |
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This was causing test failures because version strings varied in
length between GNU/Linux and GNU/KFreeBSD. One can also imagine
different versions of gnupg causing the same failure.
|
|
|
|
| |
Transcribed from Felipe's email.
|
| |
|
|
|
|
|
|
|
|
| |
Unfortunately old versions of GCC and clang do not provide byte order
macros, so we re-invent them.
If UTIL_BYTE_ORDER is not defined or defined to 0, we fall back to
macros supported by recent versions of GCC and clang
|
|
|
|
|
| |
We could give more details about how to migrate tags, but I'm not sure
that it's a practical problem, or just a theoretical one.
|
|
|
|
|
|
|
|
|
|
| |
Previously PLATFORM_BYTE_ORDER and IS_LITTLE_ENDIAN were not defined,
so the little endian code was always compiled in.
This will have the effect that the "SHA1s" on big endian architectures
will change (i.e. become actual sha1s). So someone re-indexing their
database could conceivable lose tags on messages without a message-id
header.
|
|
|
|
|
|
| |
Gdb is currently broken on s390x buildd's and porterboxes (see #728705).
By removing it as a build-dep, we disable the (failing) atomicity test on this
architecture
|
|
|
|
| |
Signed-off-by: Ben Gamari <bgamari.foss@gmail.com>
|
|
|
|
| |
This change does not require an SONAME bump because it only adds a symbol.
|
| |
|
|
|
|
|
| |
Various other files are synched using "make update-versions". NEWS
has to be hand edited.
|
|
|
|
| |
Tomi says I have to.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When executed command line is written to *Notmuch errors* buffer,
shell-quote-argument will backslash-escape any char that is not in
"POSIX filename characters" (i.e. matching "[^-0-9a-zA-Z_./\n]").
Currently in two emacs tests shell has expanded $PWD as part of
emacs variable, which will later be fed to #'shell-quote-argument
and finally written to ERROR file. If $PWD contained non-POSIX
filename characters, data in ERROR file will not match $PWD when
later comparing in shell. Therefore, in these two particular cases
the escaped $PWD is replaced with YYY in ERROR file and expected
content is adjusted accordingly.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In emacs 24.3+ the stdout/stderr from externally displaying an
attachment gets inserted into the show buffer. This is caused by
changes in mm-display-external in mm-decode.el.
Ideally, we would put this output in the notmuch errors buffer but the
handler is called asynchronously so we don't know when the output will
appear. Thus if we put it straight into the errors buffer it could get
interleaved with other errors. Also we can't easily tell when we
have got all the error output so can't wait until the process is complete.
One solution would be to create a new buffer for the stderr of each
attachment viewed. Again, since we can't tell when the process has
finished, we can't close these buffers automatically so this will
leave lots of buffers around.
Thus we add a debug variable notmuch-show-attachment-debug: it this is
non-nil we create a new buffer for each viewer; if this variable is
nil we just use a temp buffer which means all error output is
discarded (this is the same behaviour as with emacs pre 24.3).
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
| |
Not on unload, which happens when we switch buffers.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
|
| |
Vim handles the buffers just fine: when one is deleted, we go to the
previous one.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
| |
Now we are the official one.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
| |
In preparation for composing new messages.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
| |
Using $email_address is more straight forward.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
| |
Using Mail as a reference.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
|
|
| |
For example:
:NotMuch date:today
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To minimize memory usage we need to destroy the queries and the
databases, so we should keep track of them.
Each buffer gets a database connection that is destroyed when the buffer
is destroyed, and all the queries along with it.
Ideally notmuch should destroy the queries when the database is
destroyed, but it's not doing that at the moment.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
| |
They are better encoded than Ruby's Mail.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
|
| |
This operation might take a while, and even if it only takes fractions
of a second, that's not what the user might want.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
| |
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
|
|
|
| |
News for
commit 5c19eb46a906819744a022463ee3fd7cdfaabbb9
Author: Jani Nikula <jani@nikula.org>
Date: Sun Sep 1 20:59:53 2013 +0300
emacs: insert quotable parts in reply as they are displayed in show view
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In current emacs (24.3) select-active-regions is set to t by
default. The reply insertion code sets the region to the quoted
message to make it easy to delete (kill-region or C-w). These two
things combine to put the quoted message in the primary selection.
This is not what the user wanted and is a privacy risk (accidental
pasting of the quoted message). We can avoid some of the problems
by let-binding select-active-regions to nil. This fixes if the
primary selection was previously in a non-emacs window but not if
it was in an emacs window. To avoid the problem in the latter case
we deactivate mark.
One key test (which fails under many simpler "fixes") is: open emacs
24.3 with notmuch, open 2 windows (viewing different notmuch buffers),
highlight some text in one, and then reply to a message in the
other. In many of my earlier attempts to fix this big this test fails.
|
|
|
|
|
| |
The error messages written during the steps replacing old
database with new now includes relevant paths and strerror.
|
|
|
|
|
|
| |
In case previous notmuch compact has been interrupted there is old
work-in-progress database compact directory partially filled. Remove
it just before starting to fill the directory with new files.
|
|
|
|
|
|
|
| |
It is less error prone and window of failure opportunity is smaller
if the old (backup) database is always renamed (instead of sometimes
rmtree'd) before new (compacted) database is put into its place.
Finally rmtree() old database in case old database backup is not kept.
|
|
|
|
|
|
| |
catch Xapian::Error in compact code in lib/database.cc to be consistent
with other code in addition to not making software crash on uncaught
other Xapian error.
|
|
|
|
| |
Notmuch compact code whitespace changes to match devel/STYLE.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Following a suggestion by Austin in id:20130915153642.GY1426@mit.edu
we use remap for the over-riding bindings in pick. This means that if
the user modifies the global keymap these modifications will happen in
the tree-view versions of them too.
[tree-view overrides these to do things like close the message pane
before doing the action, so the functionality is very close to the
original common keymap function.]
|
|
|
|
|
|
| |
remaps are a rather unusual keymap consisting of "first key" 'remap
and then "second-key" the remapped-function. Thus we do the
documentation for it separately.
|
|
|
|
|
|
| |
To support key remapping in emacs help we need to know the base keymap
when looking at the remapping. keep track of this while we recurse
down the sub-keymaps in help.
|
|
|
|
|
|
| |
The actual documentation function notmuch-describe-keymap was getting
rather complicated so split out the code for a single key into its own
function notmuch-describe-key.
|