aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
| * Fix SEGV in _thread_cleanup_author if author ends with ', 'Gravatar Dirk Hohndel2010-04-27
| | | | | | | | | | | | | | | | | | | | Admittedly, an author name ending in ',' guarantees this is spam, and indeed this was triggered by a spam email, but that doesn't mean we shouldn't handle this case correctly. We now check that there is actually a component of the name (presumably the first name) after the comma in the author name. Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* | Merge branch '0.3.x'Gravatar Carl Worth2010-04-27
|\| | | | | | | | | | | | | | | This doesn't pull in any code, (everything in 0.3.x was originally cherry-picked from master anyway). But the merge does give us a correct NEWS file showing which fixes are included in 0.3.1 and which features have been commited "since" then, (topologically, not chronologically).
| * NEWS: Add notes for the 0.3.1 releaseGravatar Carl Worth2010-04-27
| | | | | | | | | | This is going to be a bug-fix only release to fix the handful of issue noticed immediately after 0.3 was pushed out.
| * Wrap the compat header in extern "C" { } when compiling C++ sourcesGravatar Tomas Carnecky2010-04-27
| | | | | | | | | | | | | | This fixes a build error on OpenSolaris where the final liking of notmuch fails because the linker can't find strcasestr() referenced from thread.cc. (cherry picked from commit aab54b4ce752b16725399d1543602ef3f7736c91)
| * emacs: Remove conditional from notmuch-fcc-initialization.Gravatar Jesse Rosenthal2010-04-27
| | | | | | | | | | | | | | | | The fcc code would only initialize if notmuch-fcc-dirs was set. This was a problem if you reset the variable, or added the variable later during initialization. Now we always add the fcc hook, but it doesn't do anything unless notmuch-fcc-dirs are set. (cherry picked from commit 80a90787163690d2d87571327ba504a470798c60)
| * emacs: Fix `notmuch-hello-insert-tags' to correctly draw the tags.Gravatar David Edmondson2010-04-27
| | | | | | | | | | | | | | | | The fix in 1e1871154341cdd3413fe3f32e3aae477826d815 broke end-of-row wrapping when drawing the table of tags/saved searches. Fix that and improve the readability of the matrix reflection code to hasten future debugging. (cherry picked from commit 08561d8ae133704fcf15edbdd47f15474dc030d5)
| * emacs: If 'all tags' is not shown, don't use it when calculating widths.Gravatar David Edmondson2010-04-27
| | | | | | | | | | | | | | If the 'all tags' section of the hello buffer will not be shown, don't consider those tags when determining the number of saved searches that can be displayed on a single line. (cherry picked from commit 18d41192d2cf0c71045c2f6420eb2311553f58b4)
| * Rename already used counter var iGravatar Aneesh Kumar K.V2010-04-27
| | | | | | | | | | | | | | | | i is already used in a for loop at this point, so using i here again broke notmuch-reply (it would just hang). Use j instead of i here. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de> (cherry picked from commit 107f58d517e733c53e9d669457db34622337931d)
| * test: Exercise magic-from guessing with a single configured addressGravatar Carl Worth2010-04-27
| | | | | | | | | | | | | | | | | | | | | | Immediately after releasing 0.3 we learned that the magic-from-guessing code could hang in an infinite loop in some cases. The bug occurred only when the user had configured only a primary email addresss and no other email addresses. The test suite wasn't previously covering this case, so address this shortcoming. (cherry picked from commit e0f561049809f2b29068d59b38fce3213131bbd6)
* | NEWS: Note build fix for OpenSolaris (at least).Gravatar Carl Worth2010-04-27
| | | | | | | | | | | | This hit the list just as I sent out my "final call for 0.3.1 testing" and is just the kind of thing that's nice to get into a maintenance release.
* | Wrap the compat header in extern "C" { } when compiling C++ sourcesGravatar Tomas Carnecky2010-04-27
| | | | | | | | | | | | This fixes a build error on OpenSolaris where the final liking of notmuch fails because the linker can't find strcasestr() referenced from thread.cc.
* | NEWS: Add notes for the 0.3.1 releaseGravatar Carl Worth2010-04-27
| | | | | | | | | | I think this is ready to go now, but I'm going to impose a mandatory waiting period this time to catch any last-minute issues.
* | Add notmuch-message.el to emacs/Makefile.localGravatar Jesse Rosenthal2010-04-27
| | | | | | | | | | When notmuch-message.el was added to the emacs directory, I neglected to add it to the makefile as one of the emacs_sources. This patch adds it.
* | test: Exercise magic-from guessing with a single configured addressGravatar Carl Worth2010-04-27
| | | | | | | | | | | | | | | | | | | | Immediately after releasing 0.3 we learned that the magic-from-guessing code could hang in an infinite loop in some cases. The bug occurred only when the user had configured only a primary email addresss and no other email addresses. The test suite wasn't previously covering this case, so address this shortcoming.
* | emacs: Remove conditional from notmuch-fcc-initialization.Gravatar Jesse Rosenthal2010-04-27
| | | | | | | | | | | | | | The fcc code would only initialize if notmuch-fcc-dirs was set. This was a problem if you reset the variable, or added the variable later during initialization. Now we always add the fcc hook, but it doesn't do anything unless notmuch-fcc-dirs are set.
* | Subject: [PATCH] NEWS: add mention of auto-tagging.Gravatar Jesse Rosenthal2010-04-27
| | | | | | | | Describe new auto-tagging functionality in the NEWS.
* | emacs: require notmuch-message.el from notmuch.elGravatar Jesse Rosenthal2010-04-27
| | | | | | | | | | | | Add a (require 'notmuch-message) to notmuch.el. This is for functions that specifically target message mode (and, in the future, notmuch-message mode).
* | emacs: Add auto-tagging for replied messages.Gravatar Jesse Rosenthal2010-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `notmuch-message-mark-replied', a function for automatically tagging replied messages with user-defined tags. The tags (which can be either added or removed) can be customized with the customization variable `notmuch-message-replied-tags'. This is a simple list of strings. Any string prefaced with a "-" will be removed; any string prefaced with a "+" (or neither "+" nor "-") will be added. This adds a new file notmuch-message.el, for functions which target message mode (and in the future, notmuch-message mode). Based on some conversation, notmuch-message.el will probably end up subsuming notmuch-mua.el, but until we figure out exactly how we want to do that, they will remain separate files. Edited-by: Carl Worth <cworth@cworth.org>: Remove trailing whitespace and add newline at end of file.
* | emacs: Add missing parenthesis that was breaking the build.Gravatar Carl Worth2010-04-27
| | | | | | | | | | Someday I'll stop pushing patches without at least compile-testing them. *sigh*
* | emacs/notmuch-wash.el: Add `notmuch-wash-convert-inline-patch-to-part'.Gravatar David Edmondson2010-04-27
| | | | | | | | | | | | Detect inline patches and convert them to fake attachments, in order that `diff-mode' highlighting can be applied to the patch. This can be enabled by customising `notmuch-show-insert-text/plain-hook'.
* | emacs: Fix `notmuch-hello-insert-tags' to correctly draw the tags.Gravatar David Edmondson2010-04-27
| | | | | | | | | | | | | | The fix in 1e1871154341cdd3413fe3f32e3aae477826d815 broke end-of-row wrapping when drawing the table of tags/saved searches. Fix that and improve the readability of the matrix reflection code to hasten future debugging.
* | emacs: If 'all tags' is not shown, don't use it when calculating widths.Gravatar David Edmondson2010-04-27
| | | | | | | | | | | | If the 'all tags' section of the hello buffer will not be shown, don't consider those tags when determining the number of saved searches that can be displayed on a single line.
* | Rename already used counter var iGravatar Aneesh Kumar K.V2010-04-27
|/ | | | | | | i is already used in a for loop at this point, so using i here again broke notmuch-reply (it would just hang). Use j instead of i here. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* debian/changelog: Fix email address to avoid lintian complaint.Gravatar Carl Worth2010-04-27
| | | | | | Otherwise lintian thinks this is an NMU. I definitely need to figure out how to get the emacs mode for debian/changelog to write the correct address into this file in the first place.
* debian/changelog: Add notes for the 0.3 releaseGravatar Carl Worth2010-04-27
| | | | Again, just taking the one-line entries from the NEWS entry for 0.3.
* Increment package version to 0.3.Gravatar Carl Worth2010-04-27
| | | | For the 0.3 release, of course.
* lib: Increment library version to 1.1.0Gravatar Carl Worth2010-04-27
| | | | For the addition of the new NOTMUCH_SORT_UNSORTED value.
* emacs: Fix column alignment in `notmuch-hello-insert-tags'Gravatar David Edmondson2010-04-27
| | | | | | | Re-working the saved search/tag insertion to buttonize only the name of the saved search/tag plus one space broke the calculation of how much filler is required to complete the column, resulting in lines wider than the window.
* lib: Re-implement moving of thread authors.Gravatar Carl Worth2010-04-27
| | | | | | | | | | | | | Just before releasing 0.3 we received reports of crashes that were bisected to the commit adding thread-author moving. Sure enough, valgrind pointed to buffer overruns in _thread_move_matched_author. Rather than trying to make sense of all the by strncpy, strchr, +1, and +2 of that code, I reimplemented thread-author ordering with a pair of hash tables and an array. Valgrind is at least happy now on the test cases it was complaining about previously.
* NEWS: Fix spelling errors.Gravatar Carl Worth2010-04-27
| | | | | I ran the spell-checker prior to the last commit, but apparently I hadn't actually saved the buffer.
* NEWS: Add notes for the 0.3 release.Gravatar Carl Worth2010-04-27
| | | | | Summarizing all the major new features and fixes found in the git log since 0.2. A rather nice list, really.
* emacs: Use message-signature-separator rather than hard-coded string.Gravatar Carl Worth2010-04-26
| | | | | | | | It's possible that the user has instructed message-mode to use some other separator. If so, then that's what we should look for when looking for the signature. Thanks to David Edmondson <dme@dme.org> for pointing this out.
* emacs: Delete some trailing whitespace.Gravatar Carl Worth2010-04-26
| | | | That managed to sneak in with some recent improvements to the Fcc code.
* emacs: Ensure that message-directory for Fcc has a trailing slashGravatar Jesse Rosenthal2010-04-26
| | | | | | Use `file-name-as-directory' to ensure that message-directory has a trailing slash so it can be combined with the notmuch-fcc-dirs correctly.
* emacs: add prompt to create maildir for fcc if it does not exist.Gravatar Jesse Rosenthal2010-04-26
| | | | | | | | If the user specifies a maildir that does not exist, prompt the user to see whether a maildir should be created. This will fail, with the relevant explanation, if the location is not writable, or if a file already exists in that location. If the location is a dir, but not a maildir, this will add /tmp/cur/new to it.
* emacs: fcc should fail at the right time if it doesn't point to a maildirGravatar Jesse Rosenthal2010-04-26
| | | | | | | | | | | | | Throw an error after the maildir is generated but before the message is sent. This change allows the user to edit the maildir if it fails, so that it will point to a correct place. Note that this changes the previous behavior which always overwrote the existing Fcc line. Now, an Fcc line is only auto-generated if there isn't one already there. The ideal change would be to prompt to create a maildir. This should enable a place for doing that in a future patch.
* emacs: Tweak search-buffer naming to search list in reverse orderGravatar Carl Worth2010-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | The complete-string matching of commit f2ebe3ac446afda9ced6507dc391865464ccdcaa defeats the substitution of partial search strings when the user manually types a long search string that just happens to partially match a saved search. For example, typing "tag:inbox and not tag:foo" should result in "[inbox] and not tag:foo" but this has been broken since that commit. As a compromise between this feature and what the commit was trying to achieve, we now reverse the saved-searches list before looking for a match. This happens to work for me, but won't necessarily work in general. What we really want is the longest match, but rassoc-if just gives us the first match. All of this is just about creating slightly nice search-buffer names. So if anyone really cares about making the names *even* nicer, then they could improve this further.
* emacs: Rename search buffers with "saved-search" not "folder"Gravatar Carl Worth2010-04-26
| | | | | | Since we recently renamed everything from notmuch-folders to notmuch-saved-searches, fix up the generated names in the search buffers to match.
* emacs: Match entire saved-search when computing search-view buffer nameGravatar Carl Worth2010-04-26
| | | | | | | | | | I happen to have a lot of saved searches that are variants of the tag:inbox search, (such as "tag:inbox and tag:notmuch"). The logic for these was always matching inbox first, resulting in "[ inbox ] and tag:notmuch" rather than "notmuch" as desired. Anchor the regular expression on both ends to make it look harder for the better match.
* emacs: Rip out all of the notmuch-folder code.Gravatar Carl Worth2010-04-26
| | | | | | | | | | | | We are asserting that the new notmuch-hello implementation, (available by just calling `notmuch') is just as easy to use as the old notmuch-folder. So let's remove what's now a largely redundant implementation. To make this transition easier, we are still supporting the notmuch-folders variable name, and we still provide `notmuch-folder' as an alias which can be invoked to get the new notmuch-hello functionality.
* emacs: Fix notmuch-hello to use its own function for counting search results.Gravatar Carl Worth2010-04-26
| | | | | | | Previously, this was calling into a notmuch-folder-count function. Only, everything related to notmuch-folder is about to go away, so lets have notmuch-hello define its own function (notmuch-saved-search-count) for this purpose.
* emacs: Add a notmuch-saved-searches function.Gravatar Carl Worth2010-04-26
| | | | | | | | | | | | | We use this function to abstract away the common 3-step process for looking for a value for the saved-searches variable: 1. Look at the notmuch-saved-searches variable itself 2. Look at the notmuch-folders vaiable 3. Use a default value We were already using this logic (open-coded) in notmuch-hello, but notmuch.el was accessing notmuch-folders directly for the clever name selection of search buffers.
* emacs: Move declare-function from notmuch-lib.el to notmuch-hello.el.Gravatar Carl Worth2010-04-26
| | | | | | Apparently the declare-function macro doesn't work in a required file as I might like it too. Put it where it needs to go to avoid the warning.
* notmuch-hello: Add a 'G' keybinding.Gravatar Carl Worth2010-04-26
| | | | | Just like the G keybinding we've had in notmuch-folder-mode and notmuch-search-mode, (to call `notmuch-poll' to 'G'et new mail).
* notmuch-hello: Make this work with a notmuch-folders variable set in ~/.emacsGravatar Carl Worth2010-04-26
| | | | | | | I'm planning to rip out the notmuch-folder-mode completely. So as a token kindness to existing users of notmuch-folders, I'm at least making notmuch-hello support the notmuch-folders variable name as an alternate for the new name of notmuch-saved-searches.
* emacs: Remove "hello" from all variables exported through customize.Gravatar Carl Worth2010-04-26
| | | | | | | We've recently changed things so that the notmuch-hello screen is the default view one gets by executing `notmuch'. So hide the "hello" name from everything exposed in the customize interface, (leaving "hello" as just an internal name within the implementation).
* notmuch-hello: Fix a sign error when computing number of padding spaces.Gravatar Carl Worth2010-04-26
| | | | | | | | | | | After the previous commit, toggling the visibility of tags could result in notmuch-hello aborting with: Wrong type argument: wholenump, -1 At least, the error only occurred for me when making tags visible. But that may be because my longest tag name is longer than my longest saved-search name.
* notmuch-hello: Fix ability to isearch to a saved-search and press RETGravatar Carl Worth2010-04-26
| | | | | | | | | | | After isearching for an entire saved-search name, the point will be immediately after that name in the buffer. Before commit c9ba61bebef7733c4bf12adf94222e57621fdcf6 the space right after the name was part of the widget so the user could press RET right after the isearch to activate the saved search. The above commit broke that functionality. Restore it by including a single space after each name as part of the widget.
* emacs: notmuch-hello: Make viewing of all tags conditional.Gravatar Carl Worth2010-04-26
| | | | | | | | | And off by default. There's a notmuch-hello-show-tags option in customize to toggle the default setting, as well as buttons to persistently toggle the visibility for the current session. I have enough tags in my database that it's quite a bit faster for notmuch-hello to come up without showing the tags.
* notmuch-hello: Preserve current position when invoking notmuch-helloGravatar Carl Worth2010-04-26
| | | | | | | Previously, we preserved the current position only when returning to the notmuch-hello buffer or when refreshing it. Fix to also preserve the position when directly invoking notmuch-hello, (such as from a global keybinding).
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-29 18:59:19 +0000