aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* | test: Search for non-existent message should return nothingGravatar Michal Sojka2010-11-04
| | | | | | | | | | | | | | | | | | | | | | | | | | My scripts expect that empty search result is actually empty. Since commit 6dcb7592, even empty search prints a newline character and this breaks my scripts. This patch adds a test for this bug. In the test I cannot use test_expect_equal function as $() operator suppresses the final newline and this kind of difference is not detected. test/search | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
* | debian: Add a file stating the intended symbols to appear in the libraryGravatar Carl Worth2010-11-01
| | | | | | | | | | | | | | This is almost totally clearn. The (mangled) names of the Xapian exception classes appear here. That's not actually desired, as the notmuch library is never intended to throw any exceptions. But Xapian does not currently provide a mechanism for us to avoid these.
* | Makefile: Move the -Wl,-as-needed option earlier in the command line.Gravatar Carl Worth2010-11-01
| | | | | | | | | | | | | | This option wasn't having the desired effect, and sure enough, the documentation states that it only affects the linking of libraries that appear after this option on the command line. So put it early for the desired effect.
* | lib: Eliminate some redundant includes of xapian.hGravatar Carl Worth2010-11-01
| | | | | | | | | | Most files including this already include database-private.h which includes xapian.h already.
* | lib: Add GCC visibility(hidden) pragmas to private header files.Gravatar Carl Worth2010-11-01
| | | | | | | | | | | | This prevents any of the private functions from being leaked out through the library interface (at least when compiling with a recent-enough gcc to support the visibility pragma).
* | lib: Add some missing static qualifiers.Gravatar Carl Worth2010-11-01
| | | | | | | | | | | | These various functions and data are all used only locally, so should be marked static. Ensuring we get these right will avoid us accidentally leaking unintended symbols through the library interface.
* | debian: Use the correct maintainer address for the package upload.Gravatar Carl Worth2010-11-01
| | | | | | | | Otherwise, Debian tools think this is an NMU.
* | debian: Declare conformance with Standard-Version 3.9.1.0Gravatar Carl Worth2010-11-01
| | | | | | | | | | I ran through the upgrading-checklist and found nothing needing to be changed for this package.
* | Makefile: Build library with -Wl,--as-neededGravatar Carl Worth2010-11-01
| | | | | | | | | | | | Previously, we were building the final binary with this option, but not the library. The library can benefit from it as well, (as pointed out by Debian's lintian).
* | manpage: Add escaping for hyphen used as minusGravatar Carl Worth2010-11-01
| | | | | | | | | | As pointed out by Debian lintian, options with '-' might not be copy/pastable if formatted with an unescaped '-' character.
* | debian: Add changelog entry for the 0.4 release.Gravatar Carl Worth2010-11-01
| | | | | | | | Which is just about to be made.
* | Increment notmuch version to 0.4.Gravatar Carl Worth2010-11-01
| | | | | | | | | | As reminded in the RELEASING instructions, the correct version is 0.4, not 0.4.0, so update this in the NEWS file as well.
* | Update library version to 1.2.0Gravatar Carl Worth2010-11-01
| | | | | | | | | | | | | | | | | | | | This increment is for the recently-added functions: notmuch_query_get_query_string notmuch_query_get_sort These were recently added to the library interface, but the library version was not incremented at that time, (shame on me).
* | NEWS: Add notes for the 0.4.0 releaseGravatar Carl Worth2010-11-01
| | | | | | | | Which is about to be pushed out.
* | configure: Add a check for the -Wl,--as-needed flag.Gravatar Carl Worth2010-10-30
| | | | | | | | | | | | This fits with our general build philosophy of checking at configure time for desired support, (rather than putting platform-specific conditionals into our Makefiles).
* | fixupGravatar Carl Worth2010-10-30
| |
* | build: only link to what we really useGravatar Felipe Contreras2010-10-30
| | | | | | | | | | | | At least linux has the -Wl,--as-needed option. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
* | configure: Remove a debugging print message.Gravatar Carl Worth2010-10-30
| | | | | | | | This was never intended to be committed.
* | configure: Test for flag to set rpathGravatar Carl Worth2010-10-30
| | | | | | | | | | This is better than the previous approach which had a hardcoded Linux-specific value in the Makefile.
* | configure: Test for each compiler warning before enabling it.Gravatar Carl Worth2010-10-30
| | | | | | | | | | This should allow the build to be much more automatically portable to compilers with different sets of warning options.
* | test: Test emacs notmuch-hello with no saved searches to display.Gravatar Carl Worth2010-10-29
| | | | | | | | Haippily, this works just fine, but we might as well test that.
* | test: Test emacs notmuch-hello when displaying a saved search with 0 results.Gravatar Carl Worth2010-10-29
| | | | | | | | This test verifies that the bug fix in the previous commit is working.
* | Fix problem with notmuch-hello-nice-numberGravatar Dirk Hohndel2010-10-29
| | | | | | | | | | | | | | | | Without this little patch notmuch fails if asked to display a saved search that has zero results Edited-by: David Edmondson <dme@dme.org>: With code that is a little more "emacsy".
* | emacs: Re-work the implementation of highlighting in notmuch-search-mode.Gravatar David Edmondson2010-10-29
| | | | | | | | | | | | | | Re-write `notmuch-search-color-line', with the following improvements: - create overlays only if they will be needed, - merge the properties specified for a tag on top of any matching a previous tag.
* | debian: Add emacs autoloads for all top-level notmuch functions.Gravatar Carl Worth2010-10-29
| | | | | | | | | | | | With this, users will be able to simply "apt-get install emacs" and then "emacs -f notmuch" without having to edit ~/.emacs to add a ("require 'notmuch)".
* | emacs: Fix the autoload commentsGravatar Carl Worth2010-10-29
| | | | | | | | | | | | | | Remove them from non-top-level entry points, (such as the functions to set notmuch modes and the deprecated notmuch-folder function). And add one to the notmuch-hello function. Also, add missing documentation string to notmuch-hello.
* | configure: Set XAPIAN_CONFIG to only "xapian-config" by default.Gravatar Carl Worth2010-10-29
| | | | | | | | | | | | | | | | | | | | | | | | Previously, we preferred a value of "xapian-config-1.1" first. This was convenient for compiling against Xapian 1.1 while Xapian 1.2 was unreleased. But now that Xapian 1.2 is realease, and since it ships a xapian-config, the xapian-config-1.1 value can mask the newer library. Instead of trying to track the latest xapian-config-1.x in our configure script let's simply expect the user to set XAPIAN_CONFIG=xapian-config-1.x in order to compile against an unreleased Xapian.
* | configure: optimize uname finding a bitGravatar Felipe Contreras2010-10-29
| | | | | | | | Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
* | Makefile: Fix notmuch binary to directly link against Xapian and GMime.Gravatar Carl Worth2010-10-29
| | | | | | | | | | | | Without this, trying to link with the gold linker would fail, (which meant that notmuch could not be compiled out of the box on recent Fedora, nor even on Debian when the binutils-gold package is installed).
* | Don't involve the shell in notmuch searchesGravatar David Benjamin2010-10-29
| | | | | | | | | | | | | | The shell isn't needed to interpret any of the arguments, so don't bother using it at all. Signed-off-by: David Benjamin <davidben@mit.edu>
* | notmuch-setup.c: Initialize getline(3) response_size to 0Gravatar Mike Kelly2010-10-29
| | | | | | | | | | | | | | This appears to be necessary on FreeBSD. If this isn't done, we get a nasty segfault. See: id:20101013094340.41580a2f@pioto.org
* | Do not call ldconfig when building Debian packageGravatar Michal Sojka2010-10-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hi, If I want to build Debian package, it fails with the following message: ldconfig: Can't create temporary cache file /etc/ld.so.cache~: Permission denied make[1]: *** [install-lib] Error 1 The reason is that I build the package as a non-root user and make install invokes ldconfig unconditionally. The following patch contains a workaround, but I think that a more correct solution would be to check the condition LIBDIR_IN_LDCONFIG directly when make install is invoked rather than in configure as it is done now. Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
* | documentation: Add the "files" option to the synopsis of "search --output="Gravatar Carl Worth2010-10-28
| | | | | | | | | | This was inadvertently left off when --output=files was recently added as a new option.
* | python: lambda(p) is not P3k-compliantGravatar Sebastian Spaeth2010-10-28
| | | | | | | | Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* | python: Import explicit including package nameGravatar Sebastian Spaeth2010-10-28
| | | | | | | | | | | | To make python3 happy Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* | test: Emit a friendly error message if run with bash < 4.0.Gravatar Carl Worth2010-10-28
| | | | | | | | | | | | | | | | | | | | The bash code in the test suite is using associative arrays which were only added to bash as of release 4.0. If the test suite is run with an older bash, we now immediately error out and explain the situation, (instead of emitting confusing error messages and failing dozens of tests, which is what happened before this change).
* | test: Avoid using unreliable, hard-coded thread ID values in test suite.Gravatar Carl Worth2010-10-28
| | | | | | | | | | | | | | | | | | | | Some recently-added tests used hard-coded thread ID values in search specifications. This is unreliable since the thread IDs depend on the order in which "notmuch new" encounters new files, (which in turn can depend on inode ordering within the filesystem). Fix these by using the new "notmuch search --output=threads" to find the correct thread IDs given a hard-coded (but reliable) message ID.
* | emacs: Use copy-sequence instead of copy-seq.Gravatar Carl Worth2010-10-28
| | | | | | | | | | | | | | | | | | I don't see copy-seq documented within emacs at all, and some users have encountered failures of the form: notmuch-show-del-tags-worker: Symbol's function definition is void: copy-seq This should eliminate that problem.
* | notmuch search: Add a new "notmuch search --output=files"Gravatar Carl Worth2010-10-28
| | | | | | | | Yet another thing that will be extremely handy for scripts.
* | notmuch search: Add a new --output=(summary|threads|messages|tags) option.Gravatar Carl Worth2010-10-28
| | | | | | | | | | This can be handy for scripts which need to extract just a thread ID from a search term, for example.
* | lib: Add two functions: notmuch_query_get_query_string and _get_sortGravatar Carl Worth2010-10-28
| | | | | | | | | | It can be handy to be able to query these settings from an existing query object.
* | TODO: Remove several items that have been completed.Gravatar Carl Worth2010-10-28
| | | | | | | | | | We've done a lot of work recently without also taking care to update the TODO file to indicate the progress.
* | emacs: Eliminate duplicate From header in replies.Gravatar Carl Worth2010-10-27
| | | | | | | | | | | | | | | | The original code was intended to work, but clearly wasn't tested. Use mail-header (as in existing code) to extract a header from a header alist. This fixes the duplicate-from-line bug that is exercised by the test just added to the test suite.
* | test: Add test for reply functionality within emacs.Gravatar Carl Worth2010-10-27
| | | | | | | | | | | | The reply is primarily taken care of by "notmuch reply" which is already thoroughly tested. But a recent bug is inserting a duplicate From header in the emacs-based reply. So exercise that bug here.
* | notmuch: Eliminate some const-correctness warnings.Gravatar Carl Worth2010-10-27
| | | | | | | | | | | | | | | | These were introduced as a side-effect of commit b9eac48c22f53f84ed1d9c1d8ca862a7b638c9ac (shame on me for doing side-effect commits like that!). For me, at least, compilation is now warning-free.
* | emacs: Eliminate warning of calling function with excess arguments.Gravatar Carl Worth2010-10-27
| | | | | | | | | | | | | | | | Yet another case of "how could this have possibly worked before?!". I guess we were just getting very lucky with the emacs lisp calling conventions and what happens with extra arguments, but, ick! Much better now.
* | emacs: Remove non-interactive call of goto-lineGravatar Carl Worth2010-10-27
| | | | | | | | | | | | As the emacs compiler warns, the goto-line function is only intended for interactive use. Instead use the approach recommended in the goto-line documentation to avoid this.
* | emacs: Fix to eliminate warning in notmuch-query-map-auxGravatar Carl Worth2010-10-27
| | | | | | | | | | | | | | | | | | This is one of those cases where the warning looks absolutely correct, (complaining about a free variable), but I'm left wondering how the original code could have worked at all. From what I can tell, this code wasn't actually being called by any of the current code in notmuch.
* | emacs: Avoid runtime use of `cl'.Gravatar David Edmondson2010-10-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The GNU Emacs Lisp Reference Manual section D.1 says: > * Please don't require the cl package of Common Lisp extensions at > run time. Use of this package is optional, and it is not part of > the standard Emacs namespace. If your package loads cl at run time, > that could cause name clashes for users who don't use that package. > > However, there is no problem with using the cl package at compile > time, with (eval-when-compile (require 'cl)). That's sufficient for > using the macros in the cl package, because the compiler expands > them before generating the byte-code. Follow this advice, requiring the following changes where `cl' was used at runtime: - replace `rassoc-if' in `notmuch-search-buffer-title' with the `loop' macro and inline code. At the same time find the longest prefix which matches the query rather than simply the last, - replace `union', `intersection' and `set-difference' in `notmuch-show-add-tag' and `notmuch-show-remove-tag' with local code to calculate the result of adding and removing a list of tags from another list of tags.
* | Move notmuch-fcc-header-setup to message-header-setup-hook.Gravatar Rob Browning2010-10-27
| | | | | | | | | | | | | | | | | | Call notmuch-fcc-header-setup from message-header-setup-hook rather than message-send-hook. This allows you to see what's going to happen, and to make manual adjustments if desired. Gnus does something similar. Signed-off-by: Rob Browning <rlb@defaultvalue.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-01 16:12:07 +0000