aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Avoid compiler warnings due to ignored write return valuesGravatar Dirk-Jan C. Binnema2009-12-01
| | | | | | | | | | | | | Glibc (at least) provides the warn_unused_result attribute on write, (if optimizing and _FORTIFY_SOURCE is defined). So we explicitly ignore the return value in our signal handler, where we couldn't do anything anyway. Compile with: make CFLAGS="-O -D_FORTIFY_SOURCE" before this commit to see the warning.
* notmuch.el: Make 'x' and 'X' in show-mode archive the current thread.Gravatar Carl Worth2009-11-30
| | | | | | | | | This makes these keys different than 'q' in this mode, (where 'x' and 'q' are identical in all of the other modes currently). The idea here is to make it easier to do non-linear reading of messages, (such as when poking in to read just one or two threads from a search result that returned many threads).
* notmuch.el: Use let to avoid assigning to a free variable.Gravatar Carl Worth2009-11-30
| | | | | | The dynamic scoping of emacs lisp is such that we never want to assign to any variable unless it's something we've defined with `defvar' or else something we're using locally via `let'.
* notmuch.el: Avoid warning about referencing free variable `button'.Gravatar Carl Worth2009-11-30
| | | | | I'm not even sure how the previous code worked at all---it seems clear it was supposed to be using `cite-button' rather than `button'.
* notmuch.el: Avoid calling next/previous-line non-interactively.Gravatar Carl Worth2009-11-30
| | | | Emacs always complains if we use these from lisp code.
* notmuch.el: Make notmuch-help use a full-screen window.Gravatar Carl Worth2009-11-30
| | | | | | | Our documentation is long enough that I think it will be more useful to use an entire window for it (which is easily dismissed with 'q'). This is also kinder for a user not well-initiated with emacs, for whom the multi-window help can be confusing.
* notmuch.el: Make documentation of notmuch-search-mode dynamic.Gravatar Carl Worth2009-11-30
| | | | | | | | Previously, we had some hard-coded keybindings mentioned in the introductory paragraphs of the documentation for notmuch-search-mode. Now, we take advantage of the substitute-command-keys functionality to produce the same text by default, but to dynamically generate the correct text in the face of the user customizing the keybindings.
* notmuch.el: Clean up documentation of notmuch-folder-mode-map commands.Gravatar Carl Worth2009-11-30
| | | | | | Again, ensuring we have standalone first-line documentation strings, and overriding builtin commands to add our own documentation strings to them.
* notmuch.el: Clean up documentation of notmuch-show-mode-map commands.Gravatar Carl Worth2009-11-30
| | | | | | | | | | As we did recently for notmuch-search-mode-map, ensure that the first line of docuemntation for each command stands alone. We also take advantage of the substitute-command-keys functionality within notmuch-help so that the introductory paragraphs can talk about key bindings by key (rather than function name) in a way that will always be current even in the face of the user rebinding keys.
* notmuch.el: Fix notmuch-help to properly display prefixed bindings.Gravatar Carl Worth2009-11-30
| | | | | | | | | | | Previously, we would do only a single-level traverse of the keymap. That meant that for a keybinding such as "M-TAB" we would just see the prefix key ("ESC") and print that it was a keymap---never printing the TAB nor the documentation for the command it is bound to. Now, we do the full walk, constructing a proper description of the full keybdinding with prefix characters, (and converting "ESC" to "M-" for legibility).
* notmuch.el: Clean up documentation of notmuch-search-mode-map commands.Gravatar Carl Worth2009-11-30
| | | | | | | | | | | Since notmuch-help now displays a single line of documentation from each of these commands we ensure that the first line stands alone for each command. We also override some builtin commands with new commands that don't behave any differently, but have our own notmuch-specific documentation, (such as "select next thread" rather than "move point to next line").
* notmuch.el: Fix notmuch-search-goto-last-thread.Gravatar Carl Worth2009-11-30
| | | | | | This broke when we switched to filter-based processing of search results and added the "End of search results" line onto the end. Fix to skip ignore that line when moving to the last thread.
* notmuch.el: Fix notmuch-search-scroll-down to go to first thread.Gravatar Carl Worth2009-11-30
| | | | | | | | When there's no more to scroll, we want to select the first thread. This used to work, and I'm not sure when it broke, (perhaps when we switched from post-process decorating of the search results to filtering). Fix the calculation to work again.
* notmuch.el: Don't document mouse actions in notmuch-help.Gravatar Carl Worth2009-11-30
| | | | | | | | | | The concept behind direct manipulation with mouse clicks is that documentation shouldn't be necessary, (though my original motivation here was simply that "<mouse-1>" was exceeding my TAB width. This does cause a blank line to be added for the mouse binding. This isn't directly desired, but as long as it's there we put it at a natural place for a separator.
* notmuch.el: Reorder notmuch-search-mode keybindings map.Gravatar Carl Worth2009-11-30
| | | | | | | I had originally created this keymap in order from most important to least important commands. But our new notmuch-help command is presented with the list in the reverse order. So we reverse the input so that the user sees the most important commands first.
* notmuch.el: Implement our own notmuch-help instead of describe-mode.Gravatar Carl Worth2009-11-30
| | | | | | | | This gives somewhat friendlier output for the '?' binding than we had previously with `describe-mode'. First, we no longer have the various minor modes cluttering up the output. Second the display of the binding table uses the first line of documentation for the bound function rather than the function name.
* notmuch.el: Add documentation for notmuch-search-show-thread.Gravatar Carl Worth2009-11-30
| | | | | It's especially unkind to leave interactive functions without documentation.
* notmuch.el: Don't use beginning-of-buffer from elisp program.Gravatar Carl Worth2009-11-30
| | | | | | This silences a warning when compiling notmuch.el. The documentation of beginning-of-buffer does say (rather emphatically) that it's not to be used from lisp programs.
* Documentation for notmuch reply --format=(default|headers-only)Gravatar Jed Brown2009-11-28
| | | | Signed-off-by: Jed Brown <jed@59A2.org>
* More portable and easier to read regex in notmuch-search-operate-allGravatar Jed Brown2009-11-28
| | | | | | | The former one worked in 23.1.50.1 but not in 23.1.1. Signed-off-by: Jed Brown <jed@59A2.org> Tested-by: Keith Packard <keithp@keithp.com>
* Avoid bogus internal error reporting duplicate In-Reply-To IDs.Gravatar Carl Worth2009-11-28
| | | | | | | | | | | | | This error was tirggered with a debugging build via: make CXXFLAGS="-DDEBUG" and reported by David Bremner. The actual error is that I'm an idiot that doesn't know how to use strcmp's return value. Of course, the strcmp interface scores a negative 7 on Rusty Russell ranking of bad interfaces: http://ozlabs.org/~rusty/index.cgi/tech/2008-04-01.html
* Adjust autoload commentsGravatar Keith Amidon2009-11-28
| | | | | | The previous location of autoload comments didn't seem to correspond with the functions most likely to be the entry points for using notmuch. This change adjusts them to match those likely entry points.
* notmuch.el: Add face support to search modeGravatar Aneesh Kumar K.V2009-11-27
| | | | | | | | | | | | | | | | | | | | This patch use notmuch-tag-face showing tags in the notmuch-search-mode. We can selectively highlight each tag by setting notmuch-tag-face-alist as below (defface notmuch-tag-unread-face '((((class color)) (:foreground "goldenrod"))) "Notmuch search mode face used to highligh tags.") (defface notmuch-tag-inbox-face '((((class color)) (:foreground "red"))) "Notmuch search mode face used to highligh tags.") (setq notmuch-tag-face-alist '(("unread" . 'notmuch-tag-unread-face) ("inbox" . 'notmuch-tag-inbox-face))) (require 'notmuch) Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
* Send mail to notmuch list, not CarlGravatar Alec Berryman2009-11-27
|
* notmuch-new: Check for non-fatal errors from stat()Gravatar Chris Wilson2009-11-27
| | | | | | | | | | | Currently we assume that all errors on stat() a dname is fatal (but continue anyway and report the error at the end). However, some errors reported by stat() such as a missing file or insufficient privilege, we can simply ignore and skip the file. For the others, such as a fault (unlikely!) or out-of-memory, we handle like the other fatal errors by jumping to the end. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
* Key binding rearrangement for save attachments in show modeGravatar Keith Amidon2009-11-27
| | | | | | | The most obvious bindings for save attachments are already taken. The existing 'w' binding was bound to view the raw message. This commit moves it to 'V' which still seems somewhat mnemonic and uses 'w' for save (write) attachments.
* Provide ability to save attachmentsGravatar Keith Amidon2009-11-27
| | | | | Previously the only way to save an attachment was to attempt to view it and then save it from within the viewer program.
* Forward individual messages using message-forwardGravatar Keith Amidon2009-11-27
| | | | | | Sometimes forwarding a message is preferable to replying and modifying the set of recipients. This commit provides that ability using the message-forward function.
* Factor out message buffer mgmt from notmuch-show-view-all-mime-partsGravatar Keith Amidon2009-11-27
| | | | | | | | | | | | The ability to temporarily create a buffer containing only the contents of the currently selected message in notmuch show mode is generally useful. This commit factors the majority of the code required to do so out of notmuch-show-view-all-mime-parts into a macro called with-current-notmuch-show-message and rewrites the original function in terms of the macro. A future set of commits will provide additional functionality using the macro as well.
* Add key binding for notmuch-search in show-modeGravatar Keith Amidon2009-11-27
| | | | | It's not uncommon to want to start a search as a result of something read in a message so this is convenient.
* notmuch.el: Use message-mode font-face to highlight mail headersGravatar Aneesh Kumar K.V2009-11-27
| | | | Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
* correct message flag enum value so that it matches the typeGravatar Bart Trojanowski2009-11-27
| | | | | | | As per Carl's request, this patch corrects the only value defined under the notmuch_message_flag_t enum typedef to match the name of the type. Signed-off-by: Bart Trojanowski <bart@jukie.net>
* Add some very rudimentary support for handling html partsGravatar Alexander Botero-Lowry2009-11-27
| | | | | | | If there is an html mime-part in the message and it's the first part, it gets inlined using `mm-display-part' to convert it to plain text. The HTML content is still available as a non-text part as well.
* add missing comma in debugging codeGravatar David Bremner2009-11-27
|
* notmuch.el: Require message mode to avoid undefined function in replies.Gravatar Eric Anholt2009-11-27
| | | | | Otherwise, those without keithp's .emacs would end up with reply mode not being entered. Suggested by keithp.
* Fix up whitespace styling from previous commit.Gravatar Carl Worth2009-11-27
| | | | | Function name in definition belong left-aligned. Body of if statement cannot be on the same line as the "if".
* notmuch-new: Test if directory looks like Maildir before skipping tmp.Gravatar Jan Janak2009-11-27
| | | | | | | | | | | | | | | | | 'notmuch new' skips directory entries with the name 'tmp'. This is to prevent notmuch from processing possibly incomplete Maildir messages stored in that directory. This patch attempts to refine the feature. If "tmp" entry is found, it first checks if the containing directory looks like a Maildir directory. This is done by searching for other common Maildir subdirectories. If they exist and if the entry "tmp" is a directory then it is skipped. Files and subdirectories with the name "tmp" that do not look like Maildir will still be processed by 'notmuch new'. Signed-off-by: Jan Janak <jan@ryngle.com>
* Silence compiler warning by initializing a variable.Gravatar Jeffrey C. Ollie2009-11-27
| | | | | | | | If Xapian threw an exception on notmuch_query_count_messages the count variable could be used uninitialized. Initialize count to solve the problem. Signed-off-by: Jeffrey C. Ollie <jeff@ocjtech.us>
* Merge remote branch 'jukie/vim'Gravatar Carl Worth2009-11-27
|\
* | notmuch-new: Fix notmuch new to look at files within symbolic linksGravatar Aneesh Kumar K.V2009-11-27
| | | | | | | | | | | | | | | | | | | | | | | | | | We look at the modified time of the database and the directory to decide whether we need to look at only the subdirectories. ie, if directory modified time is < database modified time then we have already looking at all the files withing the directory. So we just need to iterate through the subdirectories But with symlinks we need to make sure we follow them even if the directory modified time is less than database modified time Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
* | notmuch-show: identify which messages printed matched the query stringGravatar Bart Trojanowski2009-11-27
| | | | | | | | | | | | | | | | | | The show command outputs all messages in the threads that match the search-terms. This patch introduces a 'match:[01]' entry to the 'message{' line output by the show command. Value of 1 indicates that the message is matching the search expression. Signed-off-by: Bart Trojanowski <bart@jukie.net>
* | have _notmuch_thread_create mark which messages matched the queryGravatar Bart Trojanowski2009-11-27
| | | | | | | | | | | | | | | | | | When _notmuch_thread_create() is given a query string, it can return more messages than just those matching the query. To distinguish those that matched the query expression, the MATCHING_SEARCH flag is set appropriately. Signed-off-by: Bart Trojanowski <bart@jukie.net>
* | message: add flags to notmuch_message_tGravatar Bart Trojanowski2009-11-27
| | | | | | | | | | | | | | | | This patch allows for different flags, internal to notmuch, to be set on a message object. The patch does not define any such flags, just the facilities to manage these flags. Signed-off-by: Bart Trojanowski <bart@jukie.net>
* | reply --format=headers-only: set In-Reply-To header, with ID *last* in ↵Gravatar Jed Brown2009-11-27
| | | | | | | | | | | | | | References Apparently this is actually the correct way to do it, it's silly to do it wrong just to conform to one of git's internal data structures.
* | notmuch-reply.c: implement notmuch_reply_format_headers_onlyGravatar Jed Brown2009-11-27
| | | | | | | | | | | | | | | | | | | | | | | | This command only generates References, To, and Cc headers. The purpose is primarily for use in git send-email --notmuch id:<MESSAGE-ID> to get proper threading and address the relevant parties. Hooks for other SCMs may come later. Signed-off-by: Jed Brown <jed@59A2.org>
* | notmuch-reply.c: accept the --format=default default option.Gravatar Jed Brown2009-11-27
| | | | | | | | | | | | | | | | This factors actual generation of the reply out of notmuch_reply_command into notmuch_reply_format_default(), in preparation for other --format= options. Signed-off-by: Jed Brown <jed@59A2.org>
| * vim: use <Space> more consistently in search viewGravatar Bart Trojanowski2009-11-27
| | | | | | | | | | | | In search view <Space> will show the thead, but folding messages that don't match the current search expression. Conversly, <Enter> always shows all messages in the thread.
| * Merge remote branch 'origin/master' into vimGravatar Bart Trojanowski2009-11-27
| |\
| * | vim: make it possible to start a search in show modeGravatar Bart Trojanowski2009-11-27
| | |
| * | vim: don't toggle folds that are inside closed folds in show modeGravatar Bart Trojanowski2009-11-27
| | |
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-22 10:56:28 +0000