aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Put signatures at the very end of the messageGravatar Dirk Hohndel2010-04-26
| | | | | | | | | | | The existing code inserts the signature before inserting the message body (which it puts at the very end of the buffer - therefore AFTER the signature). This little snippet makes us search backwards and insert the message body before a signature, if it exists. This also fixes a small indentation issue in David's code. Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* Add NEWS updates for my last batch of patchesGravatar Dirk Hohndel2010-04-26
| | | | | | | in the future I'll include those with my patches. Hope it's ok to do this as one single patch for this series. Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* TODO: Add some ideas for notmuch-hello cleanups.Gravatar Carl Worth2010-04-26
| | | | | I discussed these on the list while wrapping up the 0.3 release. They may not make it in for that, but I don't want to forget them at least.
* emacs: Fix to generate error if fcc directory is not a maildirGravatar Carl Worth2010-04-26
| | | | | | | Previously this was just a message that was almost impossible for the user to see. Now, the user gets to see the error message, and is presented with a buffer that actually contains the Fcc header of interest.
* Rearchitect From: header guessing code for repliesGravatar Dirk Hohndel2010-04-26
| | | | | | | | | | | | | | | | | | | | | We want to be able to correctly guess the best From: header to use when replying to emails. This is what we are looking at now: 1 is one of the users' mail addresses in the To: or Cc: header 2 check for an Envelope-to: header 3 check for an X-Original-To: header 4 check for a (for <email@add.res>) clause in Received: headers 5 check for the domain part of known email addresses in the 'by' part of Received headers 6 fall back to the primary email address This patch changes the algorithm for steps 2-5 of this process. Prior to this patch we had a first attempt to implement only step 5 - but this broke in many email setups where mail delivery to the local machine added additional Received: lines. Steps 2-4 are new, step 5 now analyzes the concatenated Received: header (this was in the previous patch) to do this analysis. Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* Make Received: header special in notmuch_message_file_get_headerGravatar Dirk Hohndel2010-04-26
| | | | | | | | | | | | With this patch the Received: header becomes special in the way we treat headers - this is the only header for which we concatenate all the instances we find (instead of just returning the first one). This will be used in the From guessing code for replies as we need to be able to walk ALL of the Received: headers in a message to have a good chance to guess which mailbox this email was delivered to. Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* Integrate notmuch-fcc mechansimGravatar Sebastian Spaeth2010-04-26
| | | | | | | | | | | | | | I have gone wild and added a defcustom "notmuch-fcc-dirs". Depending on the value of that variable we will not do any maildir fcc at all (nil, the default), or it is of the format (("defaultsentbox") ("full name <email@address>" . "Work/sentbox") ("full name2 <email2@address2>" . "Work2/sentbox")) The outbox name will be concatenated with the message mode variable "message-directory" which is "~/Mail/" by default. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* notmuch-maildir-fcc: elisp syntax fixesGravatar Sebastian Spaeth2010-04-26
| | | | | | | | | | | | | | | 1)use insert-buffer-substring Rather than the insert-buffer. Emacs complains that it is for interactive use and not for use within elisp. So use insert-buffer-substring which does the same thing when not handed any 'begin' 'end' parameters. 2)replace caddr with (car (cdr (cdr))) The former requires 'cl to be loaded and during make install emacs complained about not knowing it. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* Integrate notmuch-maildir-fcc into notmuchGravatar Sebastian Spaeth2010-04-26
| | | | | | | Require notmuch-maildir-fcc and also install it. Rename all jkr/* functions to notmuch-maildir-fcc-* Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* Add elisp file for FCC to maildir solutionGravatar Jesse Rosenthal2010-04-26
| | | | | | | File grabbed from http://jkr.acm.jhu.edu/jkr-maildir.el but not integrated yet. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* Simple attempt to display author names in a friendlier wayGravatar Dirk Hohndel2010-04-26
| | | | | | | | | | | | This patch only addresses the typical Outlook/Exchange case where we have "Last, First" <first.last@company.com> or "Last, First MI" <first.mi.last@company.com>. In the future we should be more fexible as to the formats we recognize, but for now we address this one as it is the Exchange default setting and therefore the most common one. Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* Add tests for author name reordering in search resultsGravatar Dirk Hohndel2010-04-26
| | | | | | This should be required for all patches :-) Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* Add NEWS section for author reorderingGravatar Dirk Hohndel2010-04-26
| | | | | | This should be required in all patches Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* Reorder displayed names of thread authorsGravatar Dirk Hohndel2010-04-26
| | | | | | | | | | | | | | | | | | When displaying threads as result of a search it makes sense to list those authors first who match the search. The matching authors are separated from the non-matching ones with a '|' instead of a ',' Imagine the default "+inbox" query. Those mails in the thread that match the query are actually "new" (whatever that means). And some people seem to think that it would be much better to see those author names first. For example, imagine a long and drawn out thread that once was started by me; you have long read the older part of the thread and removed the inbox tag. Whenever a new email comes in on this thread, prior to this patch the author column in the search display will first show "Dirk Hohndel" - I think it should first show the actual author(s) of the new mail(s). Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* Add authors member to messageGravatar Dirk Hohndel2010-04-26
| | | | | | | message->authors contains the author's name (as we want to print it) get / set methods are declared in notmuch-private.h Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* emacs: Tell the user how many addresses matched when completingGravatar David Edmondson2010-04-26
| | | | | | | | When completing an address, tell the user how many addresses in the database matched the query. Edited-by: Carl Worth <cworth@cworth.org>: Removed a stray numeric literal that was causing a compiler warning.
* emacs: Remove duplicate declaration of `notmuch-folders'Gravatar David Edmondson2010-04-26
| | | | | | | Reviewed-by: Carl Worth <cworth@cworth.org> This variable was moved from notmuch.el to notmuch-lib.el some time ago, but the declaration in notmuch.el was left around. Clean that up.
* emacs: `notmuch' should display the `notmuch-hello' interfaceGravatar David Edmondson2010-04-26
| | | | | | | | | | | | | | | | | Reviewed-by: Carl Worth <cworth@cworth.org> The notmuch-hello functionality is now sufficiently useful that we want to make it the default view of notmuch for new users. This also effectively hides the "hello" name from the user, so we'll be free to change that in the implementation if necessary. This change also shuffles the requires between notmuch.el and notmuch-hello.el. This fixes things so that our documented (require 'notmuch) is sufficient for getting the notmuch-hello functionality. Finally, the shuffling caused the notmuch-search-oldest-first variable from one file to the other. While doing that, give this variable the defcustom treatment for easier customization.
* emacs: Fix `notmuch-show-rewind' in the presence of invisible textGravatar David Edmondson2010-04-26
| | | | | | | | | | When determining whether or not to re-align the head of the current message with the top of the window, use `count-screen-lines' rather than `count-lines' to allow for invisible text in the preceding message. When comparing that number of lines against `next-screen-context-lines', realign if the number of lines of the previous message visible is 'smaller than or equal to' rather than just 'smaller than' to improve usability.
* emacs: More DWIM when editing messagesGravatar David Edmondson2010-04-26
| | | | | | | For composing new messages and forwarding, leave the cursor on the 'To:' field. For replies, leave the cursor at the start of the body. In all cases, mark the buffer as not modified so that the user is not prompted if she decides to immediately kill the buffer.
* emacs: Add more functions to clean up text/plain partsGravatar David Edmondson2010-04-26
| | | | | | | | | | | | | | | | | | Add: - notmuch-wash-wrap-long-lines: Wrap lines longer than the width of the current window whilst maintaining any citation prefix. - notmuch-wash-tidy-citations: Tidy up citations by: - compress repeated otherwise blank citation lines, - remove otherwise blank citation lines at the head and tail of a citation, - notmuch-wash-elide-blank-lines: Compress repeated blank lines and remove leading and trailing blank lines. None of these is enabled by default - add them to `notmuch-show-insert-text/plain-hook' to use. Reviewed-by: Carl Worth <cworth@cworth.org>: I previously committed a stale version of this patch.
* Revert "emacs: Add more functions to clean up text/plain parts"Gravatar Carl Worth2010-04-26
| | | | This reverts commit 97570954cb583cacac35b0235cbe449a07630ae3.
* emacs: Fix `notmuch-search-insert-field'Gravatar David Edmondson2010-04-26
| | | | | | Compare the formatted version of the authors with the formatted sample string rather than the un-formatted authors with the formatted sample string.
* emacs: Hide the "User-Agent:" when composing messagesGravatar David Edmondson2010-04-26
| | | | | Add a list of headers to those hidden by `message-mode' when composing. By default the list includes only "User-Agent:".
* emacs: Automatically load "notmuch-address"Gravatar David Edmondson2010-04-26
| | | | | | "notmuch-address.el" tries to be careful to insinuate itself into message mode only if it will do something useful, so it's safe to load it all of the time.
* emacs: Correct message/header/citation/signature hidingGravatar David Edmondson2010-04-26
| | | | | | | | | | Set `buffer-invisibility-spec' to `nil' (a list) if it is just `t' before inserting any body parts, otherwise removing items from `buffer-invisibility-spec' (which is what `notmuch-show-headers-visible' and `notmuch-show-message-visible' do) is a no-op and has no effect. This caused threads with only matching messages to have those messages hidden initially because `buffer-invisibility-spec' stayed `t'.
* test: Comment why we need to set TZGravatar Michal Sojka2010-04-26
|
* emacs: Add a search to the 'recent searches' list once onlyGravatar David Edmondson2010-04-26
| | | | | | Avoiding adding the same search string to the 'recent searches' list more than once by testing whether the string was already used with `member' rather than `memq'.
* emacs: Remove the accelerator keys from the hello bufferGravatar David Edmondson2010-04-26
| | | | | Carl though that the recent search accelerator keys are not useful, so remove them.
* emacs: Adapt the logo background colour to that of the frameGravatar David Edmondson2010-04-26
| | | | | | | | | The notmuch logo uses transparency. That can display poorly when inserting the image into an emacs buffer (black logo on a black background), so force the background colour of the image. We use a face (`notmuch-hello-logo-background') to represent the colour so that `defface' can be used to declare the different possible colours, which depend on whether the frame has a light or dark background.
* configure: add ignored options for compatibility.Gravatar Cédric Cabessa2010-04-26
| | | | | | gentoo's ebuild script expects 2 more options for configure: --host (same format as --build) --datadir
* emacs: Sort headers when composingGravatar David Edmondson2010-04-26
| | | | Always sort the headers in the message composition window.
* emacs: Suppress window creation when replyingGravatar David Edmondson2010-04-26
| | | | | The buffer used to edit a reply should overlay the original message. Encourage this by setting `same-window-regexps' locally.
* TODO: Add idea to make content available to isearch in search-results mode.Gravatar Carl Worth2010-04-26
| | | | | | We can't fit all the authors and the various changed subjects in 80 columns, but it would be great is isearch could still find these, (and automatically expand the hidden content as necessary).
* emacs: Add more functions to clean up text/plain partsGravatar David Edmondson2010-04-24
| | | | | | | | | | | | | | | | | | | | | | | Add: - notmuch-wash-wrap-long-lines: Wrap lines longer than the width of the current window whilst maintaining any citation prefix. - notmuch-wash-tidy-citations: Tidy up citations by: - compress repeated otherwise blank citation lines, - remove otherwise blank citation lines at the head and tail of a citation and remove blank lines between attribution statements and the citation, - notmuch-wash-compress-blanks: Compress repeated blank lines and remove leading and trailing blank lines. Enable `notmuch-wash-tidy-citations' and `notmuch-wash-compress-blanks' by default by adding them to `notmuch-show-insert-text/plain-hook'. `notmuch-wash-wrap-long-lines' is not enabled by default. If `notmuch-wash-wrap-long-lines' is enabled, word wrapping of the buffer leads to an unappealing display of text, so provide a function to disable it and add it to the list of `notmuch-show-mode' hook functions.
* emacs: Fix i-search to open up invisible citations as necessaryGravatar David Edmondson2010-04-24
| | | | | | Add an `isearch-open-invisible' property to the overlays used to hide citations and signatures, together with an appropriate function to leave the invisible text visible should that be required.
* lib: Ensure notmuch_query_search_messages returns NULL on an exception.Gravatar Carl Worth2010-04-24
| | | | | Previously, this function may have segfaulted immediately after reporting the exception.
* lib: Document that notmuch_query_count_messages may return 0 if an exception ↵Gravatar Carl Worth2010-04-24
| | | | | | occurs This isn't a behavioral change---just a calrification in the documentation.
* lib: Audit all notmuch_database call for Xapian exception handling.Gravatar Carl Worth2010-04-24
| | | | | | Our current approach is for top-level entry poitns in the library to have try/catch blocks that catch any Xapian exception and print a message. Add a few missing blocks and fix up the documentation.
* lib: Audit calls to notmuch_message_get_header to handle NULL returnGravatar Carl Worth2010-04-24
| | | | | | | | | Sebastian Spaeth reported [*] a segfault within libnotmuch when running notmuch operations while an asyncronous offlineimap job had removed some files from the mail store. Avoid this by handling all cases where notmuch_message_get_header could return NULL. [*] See message id:87d3xqti3o.fsf@SSpaeth.de on notmuch@notmuchmail.org
* lib: Simplify code to set subject from matched message.Gravatar Carl Worth2010-04-24
| | | | | Simply moving the code from _add_matched_message to a new _set_subject_from_message function.
* notmuch reply: Handle notmuch_message_get_header returning NULL.Gravatar Carl Worth2010-04-24
| | | | | | | | This seems a rather unlikely case, (replying to a message that disappears out from under us half way through the reply), but notmuch_message_get_header is documented to return NULL in error cases, so we might as well deal sanely with that (rather than just crashing).
* emacs: Make notmuch-hello jumpt to search bar by default.Gravatar Carl Worth2010-04-24
| | | | | | | This isn't ideal for me personally, since I usually want to inovke a saved search rather than entering a new search textually. But it's at least better than just putting point in the upper-left corner where it doesn't do anything.
* emacs: Rename notmuch-show-headers to notmuch-message-headersGravatar Carl Worth2010-04-24
| | | | | | | | | | And similarly for notmuch-show-headers-visible to notmuch-message-headers-visible. I've never liked notmuch-show as a namespace prefix, but it looks especially bad when it appears as "Notmuch Show Headers Visible" in the customize buffer. Give nicer names to these variables which are exported for user manipulation.
* emacs: Don't display From header by default.Gravatar Carl Worth2010-04-24
| | | | | This header is redundant with the summary-line of each message which contains the same information.
* emacs: Allow user to customize which headers are visible.Gravatar Carl Worth2010-04-24
| | | | | Continuing our tradition of making more and more of the notmuch functionality configurable fromt eh customize interface.
* emacs: Change message headers (To, CC, From, and Date) to be visible by defaultGravatar Carl Worth2010-04-24
| | | | | | Users can still toggle these to be hidden by default, and can still toggle visibility of headers for a single message with the 'h' command.
* emacs: Allow headers to be shown by default in show modeGravatar David Edmondson2010-04-24
| | | | | Add `notmuch-show-headers-visible' which, when set `t', causes headers to be shown by default.
* removed unused variablesGravatar Dirk Hohndel2010-04-23
| | | | | | trivial compiler warning fix Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* emacs: Add notmuch-address.el for address completion using notmuchGravatar David Edmondson2010-04-23
| | | | | | | | A tool `notmuch-addresses' is required to produce addresses which match a query string. An example of a suitable script can be found in the git repository at http://jkr.acm.jhu.edu/git/notmuch_addresses.git There are no doubt others.