aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* emacs: make "+" and "-" tagging operations in notmuch-show more flexibleGravatar Dmitry Kurochkin2012-02-08
| | | | | | | | | | Before the change, "+" and "-" tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in notmuch-show view allow to both add and remove multiple tags. The only difference between "+" and "-" is the minibuffer initial input ("+" and "-" respectively).
* emacs: make "+" and "-" tagging operations in notmuch-search more flexibleGravatar Dmitry Kurochkin2012-02-08
| | | | | | | | | | | Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in notmuch-search view allow to both add and remove multiple tags. The only difference between "+" and "-" is the minibuffer initial input ("+" and "-" respectively).
* emacs: remove text properties from `notmuch-search-get-tags' resultGravatar Dmitry Kurochkin2012-02-08
|
* emacs: move tag format validation to `notmuch-tag' functionGravatar Dmitry Kurochkin2012-02-08
| | | | | | | Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation.
* tag: remove unused attribute from notmuch_tag_command() argumentsGravatar Dmitry Kurochkin2012-02-08
| | | | | Argc and argv arguments are used in notmuch_tag_command() function. So unused attribute is not appropriate for them.
* emacs: use mark instead of point-max in MML quoting.Gravatar David Bremner2012-02-04
| | | | | | | | | | | As Aaron explains in id:"m2vco72tf3.fsf@wal122.wireless-pennnet.upenn.edu" Using point-max would include the signature in the quoting as well. It would probably be fairly odd to want to put an MML tag in one’s signature, but that doesn’t mean that we should break that usage. We had to use point-max in the 0.11.1 bug-fix release, because the mark functionality was added post 0.11.
* test: Fix up date in MML quoting tests.Gravatar David Bremner2012-02-04
| | | | | | based on id:"1328264649-27346-3-git-send-email-pieter@praet.org" Commit 66ecd9063 made dates "real", but it hasn't hit release yet.
* Merge commit '0.11.1'Gravatar David Bremner2012-02-04
|\ | | | | | | | | | | | | | | | | | | Conflicts: NEWS bindings/python/notmuch/database.py bindings/python/notmuch/message.py notmuch.1 NEWS merged by hand, others taken from master.
* | emacs: fix `notmuch-wash-region-to-button' to work at beginning of bufferGravatar Dmitry Kurochkin2012-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well. The patch fixes this. There are two parts in the fix: * Use `insert-before-markers' instead of `insert' for creating the button, so that it does not get added to the hidden overlay. * Stop using PREFIX argument for adding a newline before the button. The newline should not be added before a button at the beginning of buffer. The corresponding test is fixed now.
* | test: add test for hiding Original Message region at beginning of a messageGravatar Dmitry Kurochkin2012-02-04
| | | | | | | | | | | | | | | | | | | | The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:"1327562380-12894-4-git-send-email-dme@dme.org"
* | emacs: Move the blank line from the bottom of the headers to the top of the ↵Gravatar David Edmondson2012-02-03
| | | | | | | | | | | | | | | | | | body. The blank line doesn't really change position, but is now considered to be part of the body rather than part of the headers. This means that it is visible when the body is visible rather than when the headers are visible.
* | emacs: More address cleaning.Gravatar David Edmondson2012-02-03
| | | | | | | | | | | | | | Remove outer single-quotes from the mailbox part. Allow for multiple sets of nested single and double quotes. Add more tests.
* | emacs: Prefer '[No Subject]' to blank subjects.Gravatar David Edmondson2012-02-03
| |
* | emacs: Stop the `truncate-string-to-width' madness.Gravatar David Edmondson2012-02-03
| | | | | | | | | | There's no need to call `truncate-string-to-width' twice in this code path.
* | lib: Use talloc to simplify cleanup in notmuch_database_openGravatar Austin Clements2012-02-03
| | | | | | | | | | | | | | Previously, we manually "free"d various pointers in notmuch_database_open. Use a local talloc context instead to simplify cleanup and eliminate various NULL pointer initializations and conditionals.
* | lib: Release resources if notmuch_database_open failsGravatar Austin Clements2012-02-03
| | | | | | | | | | Previously, if a Xapian exception occurred in notmuch_database_open, we failed to clean up the allocated notmuch_database_t object.
* | lib: Don't delete uninitialized pointersGravatar Austin Clements2012-02-03
| | | | | | | | | | | | | | | | | | In the error-handling paths of notmuch_database_open, we call notmuch_database_close, which "delete"s several objects referenced by the notmuch_database_t object. However, some of these pointers may be uninitialized, resulting in undefined behavior. Hence, allocate the notmuch_database_t with talloc_zero to make sure these pointers are NULL so that "delete"ing them is harmless.
* | test: remove ".sh" extension from the recently added Emacs testsGravatar Dmitry Kurochkin2012-02-03
| | | | | | | | | | All test files, except for the recently added Emacs tests, do not have ".sh" extension. So remove it from the new test files for consistency.
* | configure: update explicit check for glib : >= 2.22Gravatar Pieter Praet2012-02-03
| | | | | | | | | | | | | | | | | | | | | | As of commit b3caef1f, we're using g_array_unref() in 'lib/query.cc', which was only introduced in glib 2.22, so update the dependency. Thanks to datapipe@gmail.com for reporting this [1]. Also see commit b88e6abc. [1] id:"alpine.DEB.2.02.1201132130220.21970@ltspubuntu4.int.smq.datapipe.net"
| * debian: changelog for 0.11.1Gravatar David Bremner2012-02-03
| | | | | | | | mention the two bugfixes
| * version: bump to 0.11.1Gravatar David Bremner2012-02-03
| | | | | | | | also semi-automatically update man page and python bindings versions.
| * NEWS: set release date for 0.11.1Gravatar David Bremner2012-02-03
| |
| * emacs: quote MML tags in repliesGravatar Aaron Ecay2012-02-03
| | | | | | | | | | | | | | | | | | Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user’s files could be exposed. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch.
| * test: add tests for quoting of MML tags in repliesGravatar Aaron Ecay2012-02-03
| | | | | | | | | | | | | | | | The test is broken at this time; the next commit will introduce a fix. Edited-by: Pieter Praet <pieter@praet.org>: Rebased to release branch, moved expected output into the actual test, and fixed "Fcc:" line.
* | emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."Gravatar Pieter Praet2012-02-01
| | | | | | | | Less code, same results, without sacrificing readability.
* | emacs: fix show-previous-message doc stringGravatar Jameson Graef Rollins2012-01-30
| |
* | emacs: modify the default show-mode key bindings for archivingGravatar Jameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | | | This changes the default key bindings for the 'a' key in notmuch-show mode. Instead of archiving the entire thread, it now just archives the current message, and then advance to the next open message (archive-message-then-next). 'A' is now bound to the previous archive-thread-then-next function.
* | emacs: use pop-at-end functionality in show-archive-message-then-next functionGravatar Jameson Graef Rollins2012-01-30
| | | | | | | | | | This provides a smoother message processing flow by reducing the number of key presses needed for these common operations.
* | emacs: add option to show-next-{, open-}message functions to pop out to ↵Gravatar Jameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | | | parent buffer if at end This will allow for keybindings that achieve a smoother message processing flow by reducing the number of key presses needed for most common operations.
* | emacs: add message archiving functionsGravatar Jameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | This adds two new message archiving functions that parallel the thread archiving functions: notmuch-show-archive-message{,-then-next}. The former also takes a prefix argument to unarchive the message (ie. put back in inbox).
* | emacs: break out thread navigation from notmuch-show-archive-threadGravatar Jameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | | | | | | | | | This function is now just for archiving the current thread. A new function is created to archive-then-next. The 'a' key binding is updated accordingly. This will allow people to bind to the simple thread archiving function without the extra navigation. The archive-thread function now also takes a prefix to unarchive the current thread (ie. put the whole thread back in the inbox).
* | emacs: break up notmuch-show-archive-thread-internal into two more generally ↵Gravatar Jameson Graef Rollins2012-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | useful functions Break up notmuch-show-archive-thread-internal into two new functions: notmuch-show-tag-thread-internal: applies a tag to all messages in thread. If option remove flag is t, tags will be removed instead of added. notmuch-show-next-thread: moves to the next thread in the search result. If given a prefix, will show the next result, otherwise will just move to it in the search view. Two new interactive functions, notmuch-show-{add,remove}-tag-thread, are also added. Together, these provide a better suit of thread tagging and navigation tools. The higher level thread archiving functions are modified to use these new function.
* | emacs: use search-next-thread to move to next thread in show modeGravatar Jameson Graef Rollins2012-01-30
| | | | | | | | | | We should always use the dedicated search mode navigation functions, in case navigation mechanics change down the line.
* | moved _config_(get|set)_list () functions earlier in the fileGravatar Tomi Ollila2012-01-30
| | | | | | | | | | | | Moved static functions _config_get_list () and _config_set_list () closer to the beginning of file so that their definition is known (without adding forward declarations) in upcoming changes.
* | emacs: Don't mark messages as "unsaved" when printing.Gravatar David Edmondson2012-01-27
| | | | | | | | | | `ps-print-buffer' notes that a buffer is unsaved unless `buffer-modified-p' returns `nil', so ensure that it does.
* | emacs: Another special case for `notmuch-show-clean-address'.Gravatar David Edmondson2012-01-27
| | | | | | | | Remove backslashes.
* | test: Updated expected output for new `notmuch-show-clean-address'.Gravatar David Edmondson2012-01-27
| |
* | emacs: Avoid `mail-header-parse-address' in `notmuch-show-clean-address'.Gravatar David Edmondson2012-01-27
| | | | | | | | | | | | | | | | | | | | `mail-header-parse-address' expects un-decoded mailbox parts, which is not what we have at this point. Replace it with simple string deconstruction. Mark the corresponding test as no longer broken. Minor whitespace cleanup.
* | emacs: Re-enable line wrapping in `notmuch-show-mode'.Gravatar David Edmondson2012-01-27
| | | | | | | | | | Turn on `visual-line-mode' via a hook, so that those who so choose can avoid it.
* | emacs: `notmuch-search-operate-all' code cleanup, no functional changesGravatar Dmitry Kurochkin2012-01-27
| |
* | emacs: add completion to "tag all" operation ("*" binding)Gravatar Dmitry Kurochkin2012-01-27
| | | | | | | | | | The patch adds <tab> completion to "tag all" operation bound to "*" (`notmuch-search-operate-all' function).
* | test: `notmuch-test-run' should protect against buffer switching.Gravatar David Edmondson2012-01-26
| | | | | | | | | | | | The body of the test may cause the current buffer to change. Ensure that the output goes to the correct buffer by switching back before inserting it.
* | test: `visible-buffer-substring' should not return text properties.Gravatar David Edmondson2012-01-26
| | | | | | | | | | When using `visible-buffer-substring' to examine a buffer, the text properties are not useful, so don't include them.
* | emacs: polish notmuch-hello help textGravatar Dmitry Kurochkin2012-01-26
| | | | | | | | Make `=' binding description consistent with others.
* | emacs: Fix a notmuch-print.el compiler warning.Gravatar David Edmondson2012-01-26
| | | | | | | | `notmuch-show-get-prop' should be declared.
* | emacs: Make the part content available to `mm-inlinable-p'.Gravatar David Edmondson2012-01-26
| | | | | | | | | | | | | | | | | | | | The `mm-inlinable-p' function works better if it has access to the data of the relevant part, so load that content before calling it. Don't load the content for parts that the user has indicated no desire to inline. This fixes the display of attached image/jpeg parts, for example.
* | emacs: bind "s" to `notmuch-hello-search' in notmuch-hello bufferGravatar Dmitry Kurochkin2012-01-25
| | | | | | | | | | `notmuch-hello-search' uses `notmuch-search' function but refreshes notmuch-hello buffer when the search buffer is closed.
* | emacs: use a single history for all searchesGravatar Dmitry Kurochkin2012-01-25
| | | | | | | | | | | | | | | | There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to "s". Before the change, these search mechanisms used different history lists. The patch makes notmuch-hello search use the same history list as `notmuch-search' function.
* | emacs: bind "s" to `notmuch-search' in notmuch-hello bufferGravatar Dmitry Kurochkin2012-01-25
| | | | | | | | | | | | Before the change, "s" in notmuch-hello buffer would jump to the search box. The patch changes the binding to `notmuch-search' which is consistent with all other notmuch buffers.
* | uncrustify.cfg: label indent, some known types, not, # and ##Gravatar Tomi Ollila2012-01-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adjusted some uncrustify variables to get closer to prevailing style: * Label indent (for goto) relative to current indentation. * Registered GMimeObject and mime_node_t being as types. * Space after ! (not) operator. * No space after 'stringify' (#) preprosessor token. * No spacing change around ## (option not versatile enough). There are at least 3 cases where attention needs to be paid: * If there is newline between function name and open paren in function call, the paren (and args) are indented too far right. * #define HOUR (60 *MINUTE) -- i.e. no space after star (*). * void (*foo)(args) -- i.e no space between (name) and (args).