aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* lib: Ensure notmuch_query_search_messages returns NULL on an exception.Gravatar Carl Worth2010-04-24
| | | | | Previously, this function may have segfaulted immediately after reporting the exception.
* lib: Document that notmuch_query_count_messages may return 0 if an exception ↵Gravatar Carl Worth2010-04-24
| | | | | | occurs This isn't a behavioral change---just a calrification in the documentation.
* lib: Audit all notmuch_database call for Xapian exception handling.Gravatar Carl Worth2010-04-24
| | | | | | Our current approach is for top-level entry poitns in the library to have try/catch blocks that catch any Xapian exception and print a message. Add a few missing blocks and fix up the documentation.
* lib: Audit calls to notmuch_message_get_header to handle NULL returnGravatar Carl Worth2010-04-24
| | | | | | | | | Sebastian Spaeth reported [*] a segfault within libnotmuch when running notmuch operations while an asyncronous offlineimap job had removed some files from the mail store. Avoid this by handling all cases where notmuch_message_get_header could return NULL. [*] See message id:87d3xqti3o.fsf@SSpaeth.de on notmuch@notmuchmail.org
* lib: Simplify code to set subject from matched message.Gravatar Carl Worth2010-04-24
| | | | | Simply moving the code from _add_matched_message to a new _set_subject_from_message function.
* notmuch reply: Handle notmuch_message_get_header returning NULL.Gravatar Carl Worth2010-04-24
| | | | | | | | This seems a rather unlikely case, (replying to a message that disappears out from under us half way through the reply), but notmuch_message_get_header is documented to return NULL in error cases, so we might as well deal sanely with that (rather than just crashing).
* emacs: Make notmuch-hello jumpt to search bar by default.Gravatar Carl Worth2010-04-24
| | | | | | | This isn't ideal for me personally, since I usually want to inovke a saved search rather than entering a new search textually. But it's at least better than just putting point in the upper-left corner where it doesn't do anything.
* emacs: Rename notmuch-show-headers to notmuch-message-headersGravatar Carl Worth2010-04-24
| | | | | | | | | | And similarly for notmuch-show-headers-visible to notmuch-message-headers-visible. I've never liked notmuch-show as a namespace prefix, but it looks especially bad when it appears as "Notmuch Show Headers Visible" in the customize buffer. Give nicer names to these variables which are exported for user manipulation.
* emacs: Don't display From header by default.Gravatar Carl Worth2010-04-24
| | | | | This header is redundant with the summary-line of each message which contains the same information.
* emacs: Allow user to customize which headers are visible.Gravatar Carl Worth2010-04-24
| | | | | Continuing our tradition of making more and more of the notmuch functionality configurable fromt eh customize interface.
* emacs: Change message headers (To, CC, From, and Date) to be visible by defaultGravatar Carl Worth2010-04-24
| | | | | | Users can still toggle these to be hidden by default, and can still toggle visibility of headers for a single message with the 'h' command.
* emacs: Allow headers to be shown by default in show modeGravatar David Edmondson2010-04-24
| | | | | Add `notmuch-show-headers-visible' which, when set `t', causes headers to be shown by default.
* removed unused variablesGravatar Dirk Hohndel2010-04-23
| | | | | | trivial compiler warning fix Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* emacs: Add notmuch-address.el for address completion using notmuchGravatar David Edmondson2010-04-23
| | | | | | | | A tool `notmuch-addresses' is required to produce addresses which match a query string. An example of a suitable script can be found in the git repository at http://jkr.acm.jhu.edu/git/notmuch_addresses.git There are no doubt others.
* emacs: Rename notmuch-show-toggle-all to notmuch-show-open-or-close-allGravatar Carl Worth2010-04-23
| | | | | | | | The function was named and documented incorrectly before, saying that it would "change the visibility of all messages". Instead it only opens the messages that are closed---it doesn't simultanesously close the messages that are open. (Granted, nobody would *want* that behavior I don't think, but the naming was confusing before.)
* emacs/notmuch-show.el: Add `notmuch-show-toggle-all' bound to M-RETGravatar David Edmondson2010-04-23
| | | | | | `notmuch-show-toggle-all' changes the visibility all of the messages in the current thread. By default it makes all of the messages visible. With a prefix argument, it makes them all not visible.
* fix expected test result to include Bcc linesGravatar Dirk Hohndel2010-04-23
| | | | | | | | | | | | | | | | this test actually tests behavior that I consider as broken. The Bcc should be to the same address as used in the From line, otherwise we are creating a potential information leak as email that is related to one email account (say, work) is copied to a different account Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Reviewed-by: Carl Worth <cworth@cworth.org> These tests don't actually pass yet, since the feature being tested has not been merged. But gettting these tests in first will let us more easily test that the feature actually works, (and will help us ensure we don't forget the feature before the next release).
* add From guessing tests to test suiteGravatar Dirk Hohndel2010-04-23
| | | | | | | | right now these are not trying to be overly fancy simply one test per strategy that we apply to figure out the best from address - including the fallback if there's nothing to go on Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* emacs: Use single-quote not double-quote when constructing searchGravatar Carl Worth2010-04-23
| | | | | | | | | | | | | | | | | | | | Commit 44982ab33295009137e3740e644e793a08629762 added some extra quoting when constructing a search. A previous version of this patch had used single-quotation marks (') while this version used double-quotation marks ("). The intent of the extra quoting was to allow notmuch-command to be set to a script invoking ssh. What actually happens, however is that the extra quotation marks make it all the way into the query string seen by Xapian. And the double quotes trigger phrase searching, (which isn't desired here). The side-effect of that is that the emacs code would fallback to an unqalified query and display all threads with all messages open. We fix that side-effect now by using single-quote characters, but we'll want a better fix in the future to avoid Xapian seeing these characters at all I think.
* emacs: Re-arrange message sending codeGravatar David Edmondson2010-04-23
| | | | | | | | | | | | | | | Define a new `mail-user-agent' (`notmuch-user-agent') and use it by default. Re-arrange various routines that send mail to use this (compose, reply, forward). Insert a `User-Agent:' header by default. This is the real commit for this functionality this time. The previous attempt to merge this code: commit 57926bc7b0f784cbacb620fda0ee5157e2e0ff27 was botched (by Carl Worth, not David) to include only the Makefile change. So the build was broken until this commit that actually adds the new file.
* test: Set fixed time zoneGravatar Michal Sojka2010-04-23
| | | | | | | | | | | | | | | | | | | | | | | When the test suite is run in a different time zone that where Carl lives, some tests may fail depending on the time when the test suite is run. For example, just now I get: Search for all messages ("*"):... FAIL --- test-031.expected 2010-04-23 09:33:47.898634822 +0200 +++ test-031.output 2010-04-23 09:33:47.898634822 +0200 @@ -1,5 +1,5 @@ -thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Test message #6 (inbox unread) -thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Test message #14 (inbox unread) +thread:XXX 2001-01-06 [1/1] Notmuch Test Suite; Test message #6 (inbox unread) +thread:XXX 2001-01-06 [1/1] Notmuch Test Suite; Test message #14 (inbox unread) thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; body search (inbox unread) thread:XXX 2000-01-01 [1/1] searchbyfrom; search by from (inbox unread) thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; search by to (inbox unread) By setting a fixed time zone in the test script, these problems should be eliminated. Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
* emacs: Push the cursor to point-max on `n' or `N' at the end of a threadGravatar David Edmondson2010-04-23
| | | | | | Sebastian pointed out that the pre-JSON UI would move the cursor to the end of the buffer if `n' or `N' is hit when on the last (unread) message. Mimic that behaviour in the new UI.
* emacs: Re-arrange message sending codeGravatar David Edmondson2010-04-23
| | | | | | Define a new `mail-user-agent' (`notmuch-user-agent') and use it by default. Re-arrange various routines that send mail to use this (compose, reply, forward). Insert a `User-Agent:' header by default.
* emacs: Fix some compilation warnings.Gravatar Carl Worth2010-04-23
| | | | | | Fix missing argumen in declaration of notmuch-search function and add a definition of notmuch-search-continuation to avoid warning about assignment to a free variable.
* emacs: Add notmuch-hello.el, a friendly frontend to notmuchGravatar David Edmondson2010-04-23
| | | | | | | This is based on the prototype that Carl Worth described in the TODO file. It provides a search bar as well as support for recent searches, saved searches, and a list of all tags in the database (as well as the number of messages with each tag).
* emacs: Remove `notmuch-search-authors-width' and fix the use of ↵Gravatar David Edmondson2010-04-23
| | | | | | | | | | | | | | | | | | `notmuch-search-result-format' accordingly The width of the authors field in search output was previously specified in two places: - `notmuch-search-authors-width': the limit beyond which the authors names are truncated, - `notmuch-search-result-format': the layout of the search results. Changing the configuration of one of these may have required the user to know about and adapt the other accordingly. This led to confusion. Instead, remove `notmuch-search-authors-width' and perform truncation based on the relevant field in `notmuch-search-result-format'. Approved-By: Jameson Rollins <jrollins@finestructure.net>
* Reintroduce patch to quote args in notmuch-show to facilitate remote useGravatar Jesse Rosenthal2010-04-23
| | | | | This reintroduces the patch committed in 9193455fa1, which was reverted during the upgrade to the JSON emacs UI.
* notmuch setup: Prompt for tags to set on new messages.Gravatar Carl Worth2010-04-23
| | | | | Our "notmuch setup" command is only really helpful if it guides the user through all the possible options. So add this one.
* config: Rename messages.new_tags to just new.tagsGravatar Carl Worth2010-04-23
| | | | | | I think one configuration group for each top-level command makes a lot of sense. And this makes the existing naming of set_new_tags and get_new_tags also very reasonable.
* Clarify the documentation for the new_tags configuration option.Gravatar Carl Worth2010-04-23
| | | | | Specifically mentioning that it's a list separated by ';' and use "will" instead of "should".
* notmuch setup: Fix new configuration-file groups to get commentsGravatar Carl Worth2010-04-23
| | | | | | | | | | Our intent has always been that when new configuration-file settings are created by notmuch, that they get created with comments telling the user how to use them. But this was only working before when the entire configuration file was created. We fix this so that when a new group is added, (such as the recently- added [messages] section) that it gets its documentation.
* Sprinkle some const-correctness around new_tags.Gravatar Carl Worth2010-04-23
| | | | To eliminate a compiler warning.
* notmuch-config: make new message tags configurableGravatar Ben Gamari2010-04-23
| | | | | | Add a new_tags option in the [messages] section of the configuration file to allow the user to specify which tags should be added to new messages by notmuch new.
* python: Add UNSORTED as Query.SORT optionGravatar Sebastian Spaeth2010-04-23
| | | | | | Keep up to date with the libnotmuch.so API. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* python: Delete unused filesGravatar Sebastian Spaeth2010-04-23
| | | | | | | | No more .hg files needed in the git repo. No stock notmuch-test suite needed in a subdirectory. We have the real one in this repository Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* test: Put the json tests into their own section.Gravatar Carl Worth2010-04-22
| | | | | Not that the sections actually mean anything yet, but it makes for clean output.
* notmuch search: Fix timezone of timestamp in --format=json outputGravatar Carl Worth2010-04-22
| | | | | This is one of those cases that I move love. Deleting code fixes a bug, (test suite now passes again).
* First tests for JSON output and UTF-8 in mail body and subjectGravatar Gregor Hoffleit2010-04-22
| | | | | | | | | | | | | | | | | | | | The test suite doesn't yet cover --format=json output nor UTF-8 in subject or body. This patch starts with test cases for 'search --format=json' and 'show --format=json'. Furthermore, it has test cases for a search for a UTF-8 string in a mail body for a UTF-8 string in a mail subject. Finally, it has a test case for --format=json with UTF-8 messages, demonstrating the fix in 1267697893-sup-4538@sam.mediasupervision.de. Reviewed-by: Carl Worth <cworth@cworth.org> Updated tests to current implementation of the test suite. These tests demonstrate a bug in the current implementation of "notmuch show --format=json", (timestamp output is changed depending on current timezone).
* test: Make existing "notmuch show" test more resilientGravatar Carl Worth2010-04-22
| | | | | | | If future updates to the test suite add more messages to the database before this "notmuch show" test, then the message-ID numbers in the expected output will all change. But we can at least compute the numbers so that this test will continue to pass.
* json: Replace `date_unix' with `timestamp' in show outputGravatar David Edmondson2010-04-22
| | | | | Search output was already using `timestamp' for a very similar field, so follow that.
* emacs: Add customize treatment and rename refresh-script to notmuch-poll-scriptGravatar Carl Worth2010-04-22
| | | | | | | | | With defcustom the user can easily find this variable (and its documentation) within "M-x customize-group" "notmuch" (though finding *that* is still tricky). The new name of notmuch-poll-script is also easier to remember, (for me at least).
* emacs: Use consistent naming for the two new poll functions.Gravatar Carl Worth2010-04-22
| | | | | | Emacs scoping rules strongly encourage us to have fully-namespaced function names. A prefix like "notmuch-search" is a pretty ugly namespace name, but it's what we have for now.
* Add 'G' keybinding to folder and search view that triggers external pollGravatar Dirk Hohndel2010-04-22
| | | | | | | | | | | | The new functions first check if an external poll script has been defined in the variable 'notmuch-external-refresh-script and if yes, runs that script before executing the existing refresh function (which is bound to '=') This can be used to have 'G' mimic the mutt behavior of polling an external mail server - or if the mail polling is already automatic, it can trigger the call to notmuch new and any necessary automatic tagging of new email. Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
* Revert "thread: Simplify code for assigning the subject."Gravatar Carl Worth2010-04-22
| | | | | | | This reverts commit 36e4459a328b8449b3e9d510be81a332a9b35aaa. With the two previous reverts, this fixes the recent message-sorting regression, so the test suite now passes again.
* Revert "thread: Fix sort of search when constructing threads."Gravatar Carl Worth2010-04-22
| | | | This reverts commit f43990ce134d838cdb2cdd5d0752a602e81cfdd9.
* Revert "thread: Removed unsed sort argument from _thread_add_matched_message"Gravatar Carl Worth2010-04-22
| | | | This reverts commit 7fb56f9dc5d8e66f717f5e48ecbfbc11c8190182.
* test: Add a test to demonstrate message-sorting regression.Gravatar Carl Worth2010-04-22
| | | | | | | | | | | In the recent change to rename threads based on changing subject lines, I broke message ordering within "notmuch show" output. But our test suite didn't catch that regressions, because we didn't have any tests of "notmuch show". This adds one "notmuch show" test along with the thread-naming tests. It's not a whole suite of "notmuch show" testing, but it does catch this regression at least.
* test: When a test fails, show diff only (save complete output to a file)Gravatar Carl Worth2010-04-22
| | | | | | | | We're starting to get test output that's fairly long, so it's much kinder to just show a diff rather than displaying the complete expected and actual output. To allow the user to investigate things after the fact, we save the expected and actual output to files named test-${test_number}.expected and test-${test_number}.output .
* test: Improve grammar in test-message subjects.Gravatar Carl Worth2010-04-22
| | | | | Before codifying these in any expected test output, I'd like them to at least resemble English.
* Fix help message for "show"Gravatar Jameson Rollins2010-04-21
| | | | | Help message for "show" mistakenly refers to '--output' instead of '--format'.
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-04 02:32:24 +0000