aboutsummaryrefslogtreecommitdiffhomepage
path: root/devel
diff options
context:
space:
mode:
authorGravatar Austin Clements <amdragon@MIT.EDU>2013-10-24 11:19:11 -0400
committerGravatar David Bremner <david@tethera.net>2013-11-08 20:52:00 -0400
commit96c0ce28f8288773870bff5a6ef1c43ff3a931f8 (patch)
treee73cb062ce08cee5557e1a7f3e7a46f71581097d /devel
parent23fb842e04938513517adfed860d8b40ad910096 (diff)
emacs: Fix search tagging races
This fixes races in thread-local and global tagging in notmuch-search (e.g., "+", "-", "a", "*", etc.). Previously, these would modify tags of new messages that arrived after the search. Now they only operate on the messages that were in the threads when the search was performed. This prevents surprises like archiving messages that arrived in a thread after the search results were shown. This eliminates `notmuch-search-find-thread-id-region(-search)' because these functions strongly encouraged racy usage. This fixes the two broken tests added by the previous patch.
Diffstat (limited to 'devel')
-rw-r--r--devel/TODO5
1 files changed, 0 insertions, 5 deletions
diff --git a/devel/TODO b/devel/TODO
index f2124834..1cf4089f 100644
--- a/devel/TODO
+++ b/devel/TODO
@@ -14,11 +14,6 @@ sender's name containing ';' which causes emacs to drop a search
result.) This may require removing the outer array from the current
"notmuch search --format=json" results.
-Fix '*' to work by simply calling '+' or '-' on a region consisting of
-the entire buffer, (this would avoid one race condition---while still
-leaving other race conditions---but could also potentially make '*' a
-very expensive operation).
-
Add a global keybinding table for notmuch, and then view-specific
tables that add to it.