diff options
| author |  Kevin J. McCarthy <kevin@8t8.us> | 2013-09-07 10:07:57 -0700 |
|---|---|---|
| committer |  David Bremner <bremner@debian.org> | 2013-09-08 22:47:51 -0300 |
| commit | f3dc5be6f2c870ca9edf7d60a8c7b80984c37bbf (patch) | |
| tree | f905501c55a287f53cc73fdbb89d8454cfe889c8 /contrib | |
| parent | fae15296eca133c53e17e379e2efc839e4c1907e (diff) | |
notmuch-mutt: Fix tagging issues
This patch fixes three issues with "notmuch-mutt tag":
1. The message_id was not shell quoted.
Thanks to Jason Miller for the bug report and patch.
2. The tags passed into tag_action() were not being properly quoted.
The "join before shell_quote" was combining multiple tags into a
single argument to notmuch tag: '+one -two -three' instead of
'+one' '-two' '-three'.
3. A "--" was added between the tags and search-term as shown in the
current notmuch-tag man page.
Thanks to Tomi Ollila for suggesting the simple fix of using
the list form of system(), which bypasses the shell.
Diffstat (limited to 'contrib')
| -rwxr-xr-x | contrib/notmuch-mutt/notmuch-mutt | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt index c69b35c9..4969e4be 100755 --- a/contrib/notmuch-mutt/notmuch-mutt +++ b/contrib/notmuch-mutt/notmuch-mutt @@ -113,9 +113,7 @@ sub tag_action(@) { my $mid = get_message_id(); defined $mid or die "notmuch-mutt: cannot find Message-Id, abort.\n"; - system("notmuch tag " - . shell_quote(join(' ', @_)) - . " id:$mid"); + system("notmuch", "tag", @_, "--", "id:$mid"); } sub die_usage() { |