From 3debf75eb9229144a05701e03ba59408a75dd815 Mon Sep 17 00:00:00 2001 From: Frédéric Guillot Date: Thu, 26 Dec 2019 15:26:23 -0800 Subject: Normalize URL query string before executing HTTP requests - Make sure query strings parameters are encoded - As opposed to the standard library, do not append equal sign for query parameters with empty value - Strip URL fragments like Web browsers --- reader/feed/handler.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'reader/feed') diff --git a/reader/feed/handler.go b/reader/feed/handler.go index b272ea1..7dd0bc7 100644 --- a/reader/feed/handler.go +++ b/reader/feed/handler.go @@ -52,7 +52,7 @@ func (h *Handler) CreateFeed(userID, categoryID int64, url string, crawler bool, return nil, errors.NewLocalizedError(errDuplicate, response.EffectiveURL) } - subscription, parseErr := parser.ParseFeed(response.String()) + subscription, parseErr := parser.ParseFeed(response.BodyAsString()) if parseErr != nil { return nil, parseErr } @@ -106,7 +106,7 @@ func (h *Handler) RefreshFeed(userID, feedID int64) error { if response.IsModified(originalFeed.EtagHeader, originalFeed.LastModifiedHeader) { logger.Debug("[Handler:RefreshFeed] Feed #%d has been modified", feedID) - updatedFeed, parseErr := parser.ParseFeed(response.String()) + updatedFeed, parseErr := parser.ParseFeed(response.BodyAsString()) if parseErr != nil { originalFeed.WithError(parseErr.Localize(printer)) h.store.UpdateFeedError(originalFeed) -- cgit v1.2.3