From 3a1641a7c7fbef9420fee48ba25b95fc94ef6673 Mon Sep 17 00:00:00 2001 From: Daryle Walker Date: Tue, 29 Dec 2015 00:18:13 -0500 Subject: Remove extraneous group parameter from fetch-article-by-message-ID methods. --- src/objc/nntp/MCONNTPSession.h | 12 +++++++++++- src/objc/nntp/MCONNTPSession.mm | 8 ++++++-- 2 files changed, 17 insertions(+), 3 deletions(-) (limited to 'src/objc') diff --git a/src/objc/nntp/MCONNTPSession.h b/src/objc/nntp/MCONNTPSession.h index 0637ec7e..6b540947 100644 --- a/src/objc/nntp/MCONNTPSession.h +++ b/src/objc/nntp/MCONNTPSession.h @@ -138,12 +138,22 @@ /** Returns an operation that will fetch the content of a message with the given messageID. + MCONNTPFetchArticleOperation * op = [session fetchArticleOperationWithMessageID:@""]; + [op start:^(NSError * __nullable error, NSData * messageData) { + // messageData is the RFC 822 formatted message data. + }]; + */ +- (MCONNTPFetchArticleOperation *) fetchArticleOperationWithMessageID:(NSString *)messageID; + +/** + Obsolete. Use -fetchArticleOperationWithMessageID: instead. + MCONNTPFetchArticleOperation * op = [session fetchArticleOperationWithMessageID:@"" inGroup:@"comp.lang.c"]; [op start:^(NSError * __nullable error, NSData * messageData) { // messageData is the RFC 822 formatted message data. }]; */ -- (MCONNTPFetchArticleOperation *) fetchArticleOperationWithMessageID:(NSString *)messageID inGroup:(NSString *)group; +- (MCONNTPFetchArticleOperation *) fetchArticleOperationWithMessageID:(NSString *)messageID inGroup:(NSString * __nullable)group; /** Returns an operation that will fetch the server's date and time. diff --git a/src/objc/nntp/MCONNTPSession.mm b/src/objc/nntp/MCONNTPSession.mm index 374e6018..cc47ae5e 100644 --- a/src/objc/nntp/MCONNTPSession.mm +++ b/src/objc/nntp/MCONNTPSession.mm @@ -176,11 +176,15 @@ MCO_OBJC_SYNTHESIZE_SCALAR(dispatch_queue_t, dispatch_queue_t, setDispatchQueue, return MCO_TO_OBJC_OP(coreOp); } -- (MCONNTPFetchArticleOperation *) fetchArticleOperationWithMessageID:(NSString *)messageID inGroup:(NSString *)group { - mailcore::NNTPFetchArticleOperation * coreOp = MCO_NATIVE_INSTANCE->fetchArticleByMessageIDOperation(MCO_FROM_OBJC(mailcore::String, group), MCO_FROM_OBJC(mailcore::String, messageID)); +- (MCONNTPFetchArticleOperation *) fetchArticleOperationWithMessageID:(NSString *)messageID { + mailcore::NNTPFetchArticleOperation * coreOp = MCO_NATIVE_INSTANCE->fetchArticleByMessageIDOperation(MCO_FROM_OBJC(mailcore::String, messageID)); return MCO_TO_OBJC_OP(coreOp); } +- (MCONNTPFetchArticleOperation *) fetchArticleOperationWithMessageID:(NSString *)messageID inGroup:(NSString * __nullable)group { + return [self fetchArticleOperationWithMessageID:messageID]; +} + - (MCONNTPFetchOverviewOperation *)fetchOverviewOperationWithIndexes:(MCOIndexSet *)indexes inGroup:(NSString *)group { mailcore::NNTPFetchOverviewOperation * coreOp = MCO_NATIVE_INSTANCE->fetchOverviewOperationWithIndexes(MCO_FROM_OBJC(mailcore::String, group), MCO_FROM_OBJC(mailcore::IndexSet, indexes)); return MCO_TO_OBJC_OP(coreOp); -- cgit v1.2.3