From a55c8f370bd663ea1d31fed230987711aa1cf176 Mon Sep 17 00:00:00 2001 From: "Hoa V. DINH" Date: Thu, 3 Mar 2016 22:45:19 -0800 Subject: Thread safety on logger --- src/async/nntp/MCNNTPAsyncSession.cpp | 4 ++-- src/async/pop/MCPOPAsyncSession.cpp | 4 ++-- src/async/smtp/MCSMTPAsyncSession.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/async') diff --git a/src/async/nntp/MCNNTPAsyncSession.cpp b/src/async/nntp/MCNNTPAsyncSession.cpp index eeed1244..fdf1165c 100644 --- a/src/async/nntp/MCNNTPAsyncSession.cpp +++ b/src/async/nntp/MCNNTPAsyncSession.cpp @@ -285,13 +285,13 @@ void NNTPAsyncSession::setConnectionLogger(ConnectionLogger * logger) { pthread_mutex_lock(&mConnectionLoggerLock); mConnectionLogger = logger; - if (mConnectionLogger != NULL) { + pthread_mutex_unlock(&mConnectionLoggerLock); + if (logger != NULL) { mSession->setConnectionLogger(mInternalLogger); } else { mSession->setConnectionLogger(NULL); } - pthread_mutex_unlock(&mConnectionLoggerLock); } ConnectionLogger * NNTPAsyncSession::connectionLogger() diff --git a/src/async/pop/MCPOPAsyncSession.cpp b/src/async/pop/MCPOPAsyncSession.cpp index dead660f..f1897b84 100644 --- a/src/async/pop/MCPOPAsyncSession.cpp +++ b/src/async/pop/MCPOPAsyncSession.cpp @@ -240,13 +240,13 @@ void POPAsyncSession::setConnectionLogger(ConnectionLogger * logger) { pthread_mutex_lock(&mConnectionLoggerLock); mConnectionLogger = logger; - if (mConnectionLogger != NULL) { + pthread_mutex_unlock(&mConnectionLoggerLock); + if (logger != NULL) { mSession->setConnectionLogger(mInternalLogger); } else { mSession->setConnectionLogger(NULL); } - pthread_mutex_unlock(&mConnectionLoggerLock); } ConnectionLogger * POPAsyncSession::connectionLogger() diff --git a/src/async/smtp/MCSMTPAsyncSession.cpp b/src/async/smtp/MCSMTPAsyncSession.cpp index 46b25184..8ec8e2d4 100644 --- a/src/async/smtp/MCSMTPAsyncSession.cpp +++ b/src/async/smtp/MCSMTPAsyncSession.cpp @@ -277,13 +277,13 @@ void SMTPAsyncSession::setConnectionLogger(ConnectionLogger * logger) { pthread_mutex_lock(&mConnectionLoggerLock); mConnectionLogger = logger; - if (mConnectionLogger != NULL) { + pthread_mutex_unlock(&mConnectionLoggerLock); + if (logger != NULL) { mSession->setConnectionLogger(mInternalLogger); } else { mSession->setConnectionLogger(NULL); } - pthread_mutex_unlock(&mConnectionLoggerLock); } ConnectionLogger * SMTPAsyncSession::connectionLogger() -- cgit v1.2.3