From 7c090f8215b692ff90dbc287db2318dda355de1d Mon Sep 17 00:00:00 2001 From: yang-g Date: Mon, 7 Dec 2015 15:46:04 -0800 Subject: add tests for the error messages --- test/core/surface/invalid_channel_args_test.c | 183 ++++++++++++++++++++++++++ 1 file changed, 183 insertions(+) create mode 100644 test/core/surface/invalid_channel_args_test.c (limited to 'test/core/surface/invalid_channel_args_test.c') diff --git a/test/core/surface/invalid_channel_args_test.c b/test/core/surface/invalid_channel_args_test.c new file mode 100644 index 0000000000..9b7dc43e8a --- /dev/null +++ b/test/core/surface/invalid_channel_args_test.c @@ -0,0 +1,183 @@ +/* + * + * Copyright 2015, Google Inc. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above + * copyright notice, this list of conditions and the following disclaimer + * in the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Google Inc. nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + */ + +#include +#include + +#include +#include +#include +#include "test/core/util/test_config.h" + +static char *g_last_log_error_message = NULL; +static const char *g_file_name = "channel.c"; + +static int ends_with(const char *src, const char *suffix) { + size_t src_len = strlen(src); + size_t suffix_len = strlen(suffix); + if (src_len < suffix_len) { + return 0; + } + return strcmp(src + src_len - suffix_len, suffix) == 0; +} + +static void log_error_sink(gpr_log_func_args *args) { + if (args->severity == GPR_LOG_SEVERITY_ERROR && + ends_with(args->file, g_file_name)) { + g_last_log_error_message = gpr_strdup(args->message); + } +} + +static void verify_last_error(const char *message) { + if (message == NULL) { + GPR_ASSERT(g_last_log_error_message == NULL); + return; + } + GPR_ASSERT(strcmp(message, g_last_log_error_message) == 0); + gpr_free(g_last_log_error_message); + g_last_log_error_message = NULL; +} + +static char *compose_error_string(const char *key, const char *message) { + char *ret; + gpr_asprintf(&ret, "%s%s", key, message); + return ret; +} + +static void one_test(grpc_channel_args *args, char *expected_error_message) { + grpc_channel *chan = + grpc_insecure_channel_create("nonexistant:54321", args, NULL); + verify_last_error(expected_error_message); + gpr_free(expected_error_message); + grpc_channel_destroy(chan); +} + +static void test_no_error_message() { one_test(NULL, NULL); } + +static void test_max_message_length_type() { + grpc_arg client_arg; + grpc_channel_args client_args; + char *expected_error_message; + + client_arg.type = GRPC_ARG_STRING; + client_arg.key = GRPC_ARG_MAX_MESSAGE_LENGTH; + + client_args.num_args = 1; + client_args.args = &client_arg; + expected_error_message = compose_error_string( + GRPC_ARG_MAX_MESSAGE_LENGTH, " ignored: it must be an integer"); + one_test(&client_args, expected_error_message); +} + +static void test_max_message_length_negative() { + grpc_arg client_arg; + grpc_channel_args client_args; + char *expected_error_message; + + client_arg.type = GRPC_ARG_INTEGER; + client_arg.key = GRPC_ARG_MAX_MESSAGE_LENGTH; + client_arg.value.integer = -1; + + client_args.num_args = 1; + client_args.args = &client_arg; + expected_error_message = compose_error_string(GRPC_ARG_MAX_MESSAGE_LENGTH, + " ignored: it must be >= 0"); + one_test(&client_args, expected_error_message); +} + +static void test_default_authority_type() { + grpc_arg client_arg; + grpc_channel_args client_args; + char *expected_error_message; + + client_arg.type = GRPC_ARG_INTEGER; + client_arg.key = GRPC_ARG_DEFAULT_AUTHORITY; + + client_args.num_args = 1; + client_args.args = &client_arg; + expected_error_message = compose_error_string( + GRPC_ARG_DEFAULT_AUTHORITY, " ignored: it must be a string"); + one_test(&client_args, expected_error_message); +} + +static void test_ssl_name_override_type() { + grpc_arg client_arg; + grpc_channel_args client_args; + char *expected_error_message; + + client_arg.type = GRPC_ARG_INTEGER; + client_arg.key = GRPC_SSL_TARGET_NAME_OVERRIDE_ARG; + + client_args.num_args = 1; + client_args.args = &client_arg; + expected_error_message = compose_error_string( + GRPC_SSL_TARGET_NAME_OVERRIDE_ARG, " ignored: it must be a string"); + one_test(&client_args, expected_error_message); +} + +static void test_ssl_name_override_failed() { + grpc_arg client_arg[2]; + grpc_channel_args client_args; + char *expected_error_message; + + client_arg[0].type = GRPC_ARG_STRING; + client_arg[0].key = GRPC_ARG_DEFAULT_AUTHORITY; + client_arg[0].value.string = "default"; + client_arg[1].type = GRPC_ARG_STRING; + client_arg[1].key = GRPC_SSL_TARGET_NAME_OVERRIDE_ARG; + client_arg[1].value.string = "ssl"; + + client_args.num_args = 2; + client_args.args = client_arg; + expected_error_message = + compose_error_string(GRPC_SSL_TARGET_NAME_OVERRIDE_ARG, + " ignored: default host already set some other way"); + one_test(&client_args, expected_error_message); +} + +int main(int argc, char **argv) { + grpc_test_init(argc, argv); + grpc_init(); + gpr_set_log_function(log_error_sink); + + test_no_error_message(); + test_max_message_length_type(); + test_max_message_length_negative(); + test_default_authority_type(); + test_ssl_name_override_type(); + test_ssl_name_override_failed(); + + grpc_shutdown(); + + return 0; +} -- cgit v1.2.3 From 26fdaa575177b77307c04a90d86e0b942c1849a2 Mon Sep 17 00:00:00 2001 From: yang-g Date: Tue, 8 Dec 2015 08:05:19 -0800 Subject: Fix msan --- test/core/surface/invalid_channel_args_test.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'test/core/surface/invalid_channel_args_test.c') diff --git a/test/core/surface/invalid_channel_args_test.c b/test/core/surface/invalid_channel_args_test.c index 9b7dc43e8a..5e7f90da5e 100644 --- a/test/core/surface/invalid_channel_args_test.c +++ b/test/core/surface/invalid_channel_args_test.c @@ -91,6 +91,7 @@ static void test_max_message_length_type() { client_arg.type = GRPC_ARG_STRING; client_arg.key = GRPC_ARG_MAX_MESSAGE_LENGTH; + client_arg.value.string = NULL; client_args.num_args = 1; client_args.args = &client_arg; @@ -122,6 +123,7 @@ static void test_default_authority_type() { client_arg.type = GRPC_ARG_INTEGER; client_arg.key = GRPC_ARG_DEFAULT_AUTHORITY; + client_arg.value.integer = 0; client_args.num_args = 1; client_args.args = &client_arg; @@ -137,6 +139,7 @@ static void test_ssl_name_override_type() { client_arg.type = GRPC_ARG_INTEGER; client_arg.key = GRPC_SSL_TARGET_NAME_OVERRIDE_ARG; + client_arg.value.integer = 0; client_args.num_args = 1; client_args.args = &client_arg; -- cgit v1.2.3 From 0346883b0b0afe2ce25bc89918051b1dd7fcffb2 Mon Sep 17 00:00:00 2001 From: yang-g Date: Tue, 8 Dec 2015 10:10:44 -0800 Subject: do the right thing? --- test/core/surface/invalid_channel_args_test.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'test/core/surface/invalid_channel_args_test.c') diff --git a/test/core/surface/invalid_channel_args_test.c b/test/core/surface/invalid_channel_args_test.c index 5e7f90da5e..1b1b8b8f92 100644 --- a/test/core/surface/invalid_channel_args_test.c +++ b/test/core/surface/invalid_channel_args_test.c @@ -82,9 +82,9 @@ static void one_test(grpc_channel_args *args, char *expected_error_message) { grpc_channel_destroy(chan); } -static void test_no_error_message() { one_test(NULL, NULL); } +static void test_no_error_message(void) { one_test(NULL, NULL); } -static void test_max_message_length_type() { +static void test_max_message_length_type(void) { grpc_arg client_arg; grpc_channel_args client_args; char *expected_error_message; @@ -100,7 +100,7 @@ static void test_max_message_length_type() { one_test(&client_args, expected_error_message); } -static void test_max_message_length_negative() { +static void test_max_message_length_negative(void) { grpc_arg client_arg; grpc_channel_args client_args; char *expected_error_message; @@ -116,7 +116,7 @@ static void test_max_message_length_negative() { one_test(&client_args, expected_error_message); } -static void test_default_authority_type() { +static void test_default_authority_type(void) { grpc_arg client_arg; grpc_channel_args client_args; char *expected_error_message; @@ -132,7 +132,7 @@ static void test_default_authority_type() { one_test(&client_args, expected_error_message); } -static void test_ssl_name_override_type() { +static void test_ssl_name_override_type(void) { grpc_arg client_arg; grpc_channel_args client_args; char *expected_error_message; @@ -148,7 +148,7 @@ static void test_ssl_name_override_type() { one_test(&client_args, expected_error_message); } -static void test_ssl_name_override_failed() { +static void test_ssl_name_override_failed(void) { grpc_arg client_arg[2]; grpc_channel_args client_args; char *expected_error_message; -- cgit v1.2.3