From f0798f91ff0cc2cbb1424dd896a91972c47a8a7f Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Thu, 18 Jan 2018 15:19:04 -0800 Subject: Solve a stack_use_after_scope issue in sockaddr_resolver_test --- test/core/client_channel/resolvers/sockaddr_resolver_test.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'test/core/client_channel') diff --git a/test/core/client_channel/resolvers/sockaddr_resolver_test.cc b/test/core/client_channel/resolvers/sockaddr_resolver_test.cc index 4d16a77924..645749ffef 100644 --- a/test/core/client_channel/resolvers/sockaddr_resolver_test.cc +++ b/test/core/client_channel/resolvers/sockaddr_resolver_test.cc @@ -63,8 +63,10 @@ static void test_succeeds(grpc_resolver_factory* factory, const char* string) { grpc_resolver_next_locked(resolver, &on_res_arg.resolver_result, on_resolution); GRPC_RESOLVER_UNREF(resolver, "test_succeeds"); - grpc_uri_destroy(uri); + /* Flush ExecCtx to avoid stack-use-after-scope on on_res_arg which is + * accessed in the closure on_resolition_cb */ + grpc_core::ExecCtx::Get()->Flush(); } static void test_fails(grpc_resolver_factory* factory, const char* string) { -- cgit v1.2.3 From 45e754a5afe955526b9309f362953c8258da1cca Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Thu, 18 Jan 2018 15:28:09 -0800 Subject: Fix typo s/resolition/resolution --- test/core/client_channel/resolvers/sockaddr_resolver_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/core/client_channel') diff --git a/test/core/client_channel/resolvers/sockaddr_resolver_test.cc b/test/core/client_channel/resolvers/sockaddr_resolver_test.cc index 645749ffef..07ee133ee3 100644 --- a/test/core/client_channel/resolvers/sockaddr_resolver_test.cc +++ b/test/core/client_channel/resolvers/sockaddr_resolver_test.cc @@ -65,7 +65,7 @@ static void test_succeeds(grpc_resolver_factory* factory, const char* string) { GRPC_RESOLVER_UNREF(resolver, "test_succeeds"); grpc_uri_destroy(uri); /* Flush ExecCtx to avoid stack-use-after-scope on on_res_arg which is - * accessed in the closure on_resolition_cb */ + * accessed in the closure on_resolution_cb */ grpc_core::ExecCtx::Get()->Flush(); } -- cgit v1.2.3