From f4bc99eb004f11e4fd75cccb863b65e9e6cbe414 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Mon, 25 Apr 2016 09:13:38 -0700 Subject: address comments --- .../Program.cs | 35 +++++++++++++++++++++- .../Grpc.IntegrationTesting/StressTestClient.cs | 34 +++++++++++++++++---- 2 files changed, 62 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/csharp/Grpc.IntegrationTesting.StressClient/Program.cs b/src/csharp/Grpc.IntegrationTesting.StressClient/Program.cs index 4285146756..dffdf22fa5 100644 --- a/src/csharp/Grpc.IntegrationTesting.StressClient/Program.cs +++ b/src/csharp/Grpc.IntegrationTesting.StressClient/Program.cs @@ -1,4 +1,37 @@ -using System; +#region Copyright notice and license + +// Copyright 2016, Google Inc. +// All rights reserved. +// +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following disclaimer +// in the documentation and/or other materials provided with the +// distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived from +// this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +#endregion + +using System; namespace Grpc.IntegrationTesting.StressClient { diff --git a/src/csharp/Grpc.IntegrationTesting/StressTestClient.cs b/src/csharp/Grpc.IntegrationTesting/StressTestClient.cs index b12b28b9a3..8db691cb04 100644 --- a/src/csharp/Grpc.IntegrationTesting/StressTestClient.cs +++ b/src/csharp/Grpc.IntegrationTesting/StressTestClient.cs @@ -269,6 +269,8 @@ namespace Grpc.IntegrationTesting class MetricsServiceImpl : MetricsService.MetricsServiceBase { + const string GaugeName = "csharp_overall_qps"; + readonly Histogram histogram; readonly WallClockStopwatch wallClockStopwatch = new WallClockStopwatch(); @@ -277,20 +279,40 @@ namespace Grpc.IntegrationTesting this.histogram = histogram; } - public override async Task GetAllGauges(EmptyMessage request, IServerStreamWriter responseStream, ServerCallContext context) + public override Task GetGauge(GaugeRequest request, ServerCallContext context) { - var snapshot = histogram.GetSnapshot(true); - var elapsedSnapshot = wallClockStopwatch.GetElapsedSnapshot(true); + if (request.Name == GaugeName) + { + long qps = GetQpsAndReset(); - double qps = snapshot.Count / elapsedSnapshot.Seconds; + return Task.FromResult(new GaugeResponse + { + Name = GaugeName, + LongValue = qps + }); + } + throw new RpcException(new Status(StatusCode.InvalidArgument, "Gauge does not exist")); + } + + public override async Task GetAllGauges(EmptyMessage request, IServerStreamWriter responseStream, ServerCallContext context) + { + long qps = GetQpsAndReset(); var response = new GaugeResponse { - Name = "csharp_overall_qps", - DoubleValue = qps + Name = GaugeName, + LongValue = qps }; await responseStream.WriteAsync(response); } + + long GetQpsAndReset() + { + var snapshot = histogram.GetSnapshot(true); + var elapsedSnapshot = wallClockStopwatch.GetElapsedSnapshot(true); + + return (long) (snapshot.Count / elapsedSnapshot.Seconds); + } } } } -- cgit v1.2.3