From 0c475f0ad78e5848438e1a690b826fe0b6eb26fe Mon Sep 17 00:00:00 2001 From: nnoble Date: Fri, 5 Dec 2014 15:37:39 -0800 Subject: Updating moe_db.txt with the latest equivalence since the ruby import changed the exported structure. Change on 2014/12/01 by nnoble ------------- new [] file for grpc testing. Change on 2014/12/02 by donnadionne ------------- Fix unfinished calls in thread_stress_test. Previously we had an early return if we cancelled a stream part way through a message. Correct this, so that half close and full close signals are propagated up the stack correctly so that higher level state machines can see the termination. Change on 2014/12/02 by ctiller ------------- Remove dependency on internal C code. Change on 2014/12/02 by ctiller ------------- Turn off the flaky bit from thread_stress_test. Change on 2014/12/02 by ctiller ------------- Add test cases of empty request/response, request streaming, response streaming, and half duplex streaming. Bring up the GFE/ESF for mannual test: [] build java/com/google/net/[]/testing/integration/hexa:server_components_env []-bin/java/com/google/net/[]/testing/integration/hexa/server_components_env --manual --rpc_port=25000 --use_autobahn Change on 2014/12/02 by chenw ------------- Make echo/server.c and fling/server.c shutdown cleanly on SIGINT, and update the relevant tests to exercise this mechanism. Now "[] coverage" and the memory leak detector are able to see into the server processes. Change on 2014/12/02 by pmarks ------------- Allow the # of channels to be configurable in this performance test. The threads will use the channels in statically-defined round-robin order (not based on when RPCs complete on any channel). The interesting cases are #channels=1 or #channels=#threads (we previously only had the latter case) Change on 2014/12/02 by vpai ------------- Fixed a typo and reworded a comment. Change on 2014/12/02 by gnezdo ------------- Require the grpc_call in this ClientContext to be NULL before allowing set_call to be invoked. Otherwise, it's an indication of a leak somewhere. Change on 2014/12/02 by vpai ------------- Correctly return status other than ok and add a test for it. Change on 2014/12/02 by yangg ------------- Better C++ guards for grpc_security.h Change on 2014/12/02 by nnoble ------------- Use nullptr instead of NULL for consistency. Change on 2014/12/02 by vpai ------------- Updates the ruby gRPC service class to require the serialization method to be a static method - this brings it inline with the proto3 ruby API - it adds a monkey patch to allow existing proto (beefcake) to continue working. Change on 2014/12/02 by temiola ------------- Adding a buildable unit to the blue print file. Added the buildable unit as its name will be usesd as tap project id. This test will fail right away in tap until tests are actually added. Change on 2014/12/02 by donnadionne ------------- Move interop ESF C++ server from Java to grpc directory. Tests passed: [] test javatests/com/google/net/[]/testing/integration/hexa/... [] test net/grpc/testing/interop/esf_server/... Change on 2014/12/02 by chenw ------------- Return a lame channel as opposed to NULL when secure channel creation fails. - Looks like we're going to need something similar server-side. - I changed the prototype of the lame client channel factory to take an explicit void as I think this is better practice in C. Let me know if you disagree and I will revert these changes. Change on 2014/12/02 by jboeuf ------------- Putting ALPN support where it belongs. Change on 2014/12/02 by jboeuf ------------- GOAWAY send path. Sends a GOAWAY frame when shutting down. This is not read and understood yet. Change on 2014/12/03 by ctiller ------------- Adds support for secure channels and servers. - wraps new C apis (credentials, server_credentials) and Server#add_secure_http_port - adds tests to ensure credentials and server credentials can be created - updates client_server_spec to run the client_server wrapper layer end-to-end tests using a secure channel Change on 2014/12/03 by temiola ------------- Fix existing issues regarding out of order events. At the client side, using pluck as the client_metadata_read can happen anytime after invoke. At the server side, allow halfclose_ok and rpc_end to come in reverse order. Change on 2014/12/03 by yangg ------------- Don't track coverage of tests. Change on 2014/12/03 by ctiller ------------- Change UnaryCall to conform standard test requirement of LargeUnaryCall. Change on 2014/12/03 by yangg ------------- updating alpn version to h2-15 ensure all interop are on the same version and working. Java and go are not ready for h2-16 yet. Change on 2014/12/03 by donnadionne ------------- Add config to bring echo server in []. This is used to test production GFE as its bckend. Change on 2014/12/03 by chenw ------------- In preparation for fixing shutdown race issues, change em to take ownership of the file descriptor. Add an API to grpc_tcp to take an already created grpc_em_fd object, and change tcp_client to use that API. This is needed because otherwise an em user's close() of the file descriptor may race with libevent internals. That's not an issue yet because destroy() frees the events inline, but that can't be done safely if there is a concurrent poller. Change on 2014/12/03 by klempner ------------- Fixing TAP opensource build We don't want to compile and run C++ tests in the C target. Change on 2014/12/03 by nnoble ------------- Move and separate interop tests by languages. Small fixes to the test runner. Improving logging. Change on 2014/12/03 by donnadionne ------------- Fixing the opensource build: -) The C/C++ split wasn't done up to the 'dep' target level -) The alpn.c file was missing from build.json Change on 2014/12/03 by nnoble ------------- Adding blue print files after projects exist Change on 2014/12/03 by donnadionne ------------- Refactor StreamContext using the new completion_queue_pluck API. The dedicated the poller thread has been removed. This CL keeps the current behavior to make it short. There is one following to make it usable for both client and server. The tags for pluck is based on the address of this StreamContext object for potential debug use. The Read/Write and Wait cannot be called concurrently now and this might need to be fixed. Change on 2014/12/03 by yangg ------------- Binary encoding utilities. Support base64 encoding, HPACK static huffman encoding, and doing both at once. Change on 2014/12/03 by ctiller ------------- Enforce Makefile regeneration in presubmits. Change on 2014/12/03 by ctiller ------------- Make CloseSend() send a real zero-length control message to indicate EOS. Change on 2014/12/03 by zhaoq ------------- Prefer to create dualstack sockets for TCP clients and servers, with automatic fallback for environments where IPV6_V6ONLY can't be turned off. Change on 2014/12/03 by pmarks ------------- Add opensource path to build targets. Ensure that MOE is going to run. Change on 2014/12/03 by ctiller ------------- Add PingPong test case. Delete FullDuplex test case. The latter is not specified for client in https://docs.google.com/document/d/1dwrPpIu5EqiKVsquZfoOqTj7vP8fa1i49gornJo50Qw/edit# Change on 2014/12/03 by chenw ------------- Make generate_projects.sh check out the generated targets. Change on 2014/12/03 by ctiller ------------- rspec cleanup - stops declaring specs within the GRPC module - splits Bidi streaming specs into a separate test suite adding tests in the GRPC module was a mistake, it pollutes the module and can affect other tests that run later by the test runner the bidi tests are currently flaky, having them run in their own test suite allows having two separate continuous builds (once ruby gRPC is on GitHub), one that includes bidi where we tolerate flakiness, and another that does not, where there should be no flakiness at all Change on 2014/12/03 by temiola ------------- Adding support for composite and IAM credentials. - For now, we don't do any checks on credentials compatibility in the composite credentials. Maybe we'll add that later. - Refactored the end to end security tests so that we always use the public API (except for the fake security context which is not exposed). Change on 2014/12/03 by jboeuf ------------- Make GPR library buildable in Visual Studio 2013. Change on 2014/12/04 by jtattermusch ------------- Adds codegen for ruby This is being added now that ruby's proto and grpc apis are defined and stable Change on 2014/12/04 by temiola ------------- Prevent NewStream() from sending negative or 0 timeout. Change on 2014/12/04 by zhaoq ------------- Add a grpc_sockaddr_to_string() function, and use it when logging bind failures. Also improve const-correctness in some earlier code. I'm not certain whether inet_ntop() will need any platform-specific implementations, but for now the compiler offers no complaints. Demo: $ []-bin/net/grpc/c/echo_server 1.2.3.4:80 ... tcp_server.c:139] bind addr=[::ffff:1.2.3.4]:80: Permission denied Change on 2014/12/04 by pmarks ------------- Refactoring - moves c wrapped classes to a submodule Google::RPC::Core - this allows for an explicit rule when reading through gRPC ruby code for telling when an object is pure ruby or wrapped C Change on 2014/12/04 by temiola ------------- Fixes the bidi_call [] Change on 2014/12/04 by temiola ------------- Fixing dev build when activating surface traces. Change on 2014/12/04 by nnoble ------------- Updates the tests to reflect that fact that some Credentials compose works. Change on 2014/12/04 by temiola ------------- Making the generate_project_test actually do something. Change on 2014/12/04 by nnoble ------------- Rename "esf_server" to "[]4_server". Delete "test_sever" from Java directory. Change on 2014/12/04 by chenw ------------- Added PHP client interop tests. Tested large_unary against the C++ server. Change on 2014/12/04 by mlumish ------------- Refactor grpc_create_dualstack_socket() by pulling the setsockopt into its own function. This separates the magic test flag from the real fallback logic. Change on 2014/12/04 by pmarks ------------- Fixes the type of the constant used for test cert hostname Change on 2014/12/04 by temiola ------------- Disabling these tests as they're causing flakiness. Change on 2014/12/04 by ctiller ------------- Change intptr --> uintptr. Handles the case where a void* turns into a negative number, which then gets hashed into a negative bucket and segfaults. Change on 2014/12/04 by ctiller ------------- Add a test fixture to force parsers to handle one byte at a time. This should expand coverage and hopefully prevent errors at some point (it seems to pass out of the box for now though). Change on 2014/12/04 by ctiller ------------- The code generator isn't +x. Change on 2014/12/04 by ctiller ------------- Updates math_client and math_server to allow construction using crednetials By: - Extending rpc_server constructor so that it takes a credentials keyword param - Extending client_stub constructor so that it takes a credentials keyword param Change on 2014/12/04 by temiola ------------- Format output a little more nicely. Print each line of output separately - previously logging.info was truncating this at some maximum length, and logs were getting lost. Change on 2014/12/04 by ctiller ------------- Up timeout for this test. Under TSAN, if we process one byte at a time, this timeout can be reached - and I think this is the cause of the following flake: [] Change on 2014/12/05 by ctiller ------------- Adding more error logging for ssl. Change on 2014/12/05 by jboeuf ------------- Read path for goaway. Still need to add hooks to deprecate a channel on the client side when goaway is received. Change on 2014/12/05 by ctiller ------------- Separate accept() into server_accept() and server_end_of_initial_metadata(). This allows servers to initiate reads before finishing writing metadata. Change on 2014/12/05 by ctiller ------------- Fix for breakage 11512317 - adding missing test files. Change on 2014/12/05 by nnoble ------------- grpc c++ server side streaming support. This is based on [] There is a lot of room to clean up the internal implementation which may require refactoring of CompletionQueue. The current cl serves as a working implementation with the missing interfaces. The sample generated files are included and will be removed before submitting. Change on 2014/12/05 by yangg ------------- Changed to the latest timeout format again (search "grpc-timeout" in [] for the spec). Change on 2014/12/05 by zhaoq ------------- Fixing opensource build. Change on 2014/12/05 by nnoble ------------- Making absolutely sure we can do the moe export by adding a sh_test for it. Change on 2014/12/05 by nnoble ------------- Change :scheme psuedo-header from "grpc" to "http" or "https". Change on 2014/12/05 by zhaoq ------------- Add server credential wrapping for c++ server. It only wraps ssl and []2 for now. The ServerCredentials class and the factory class are in a similar fashion as client side wrapping. The difference is the factory method returns shared_ptr instead of unique_ptr as the server builder needs to keep a reference to it for actually creating the server later. The integration will happen in a following cl. Change on 2014/12/05 by yangg ------------- Fixed bugs in new_grpc_docker_builder.sh Change on 2014/12/05 by mlumish ------------- In secure endpoint, hold a refcount for the life of a write callback if the write does not complete immediately. Change on 2014/12/05 by klempner ------------- Add migration support to MOE and have TAP verify it doesn't break. Migration support allows mirroring commits from [] into the git repo, instead of just a dump of the current source. Change on 2014/12/05 by ejona ------------- Change initial window size to 65535 according http2 draft 15. Change on 2014/12/05 by zhaoq ------------- Re-enable the flaky cases in dualstack_socket_test, with additional logging to help track down the problem if it surfaces again. This also seems like a good opportunity to make grpc_socket_utils a separate library, as it's not really specific to TCP. Example output: logspam: [], 26570) resolved 2 addrs in 37ms: logspam: [0] [::1]:26570 logspam: [1] 127.0.0.1:26570 Change on 2014/12/05 by pmarks ------------- Opensource build fixes. -) A function that has a return type should actually return something. -) Don't pass unsigned chars to strlen and strncmp. Change on 2014/12/05 by nnoble ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=81458281 --- src/ruby/lib/grpc.rb | 5 ++- src/ruby/lib/grpc/beefcake.rb | 62 +++++++++++++++++++++++++++ src/ruby/lib/grpc/core/event.rb | 40 ++++++++++++++++++ src/ruby/lib/grpc/core/time_consts.rb | 72 ++++++++++++++++++++++++++++++++ src/ruby/lib/grpc/event.rb | 38 ----------------- src/ruby/lib/grpc/generic/active_call.rb | 43 +++++++++---------- src/ruby/lib/grpc/generic/bidi_call.rb | 17 ++++---- src/ruby/lib/grpc/generic/client_stub.rb | 20 +++++---- src/ruby/lib/grpc/generic/rpc_desc.rb | 9 ++-- src/ruby/lib/grpc/generic/rpc_server.rb | 25 +++++++---- src/ruby/lib/grpc/generic/service.rb | 18 ++++---- src/ruby/lib/grpc/time_consts.rb | 69 ------------------------------ 12 files changed, 252 insertions(+), 166 deletions(-) create mode 100644 src/ruby/lib/grpc/beefcake.rb create mode 100644 src/ruby/lib/grpc/core/event.rb create mode 100644 src/ruby/lib/grpc/core/time_consts.rb delete mode 100644 src/ruby/lib/grpc/event.rb delete mode 100644 src/ruby/lib/grpc/time_consts.rb (limited to 'src/ruby/lib') diff --git a/src/ruby/lib/grpc.rb b/src/ruby/lib/grpc.rb index 60a3b96527..1012a836b7 100644 --- a/src/ruby/lib/grpc.rb +++ b/src/ruby/lib/grpc.rb @@ -27,12 +27,13 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -require 'grpc/event' +require 'grpc/beefcake' # extends beefcake require 'grpc/errors' require 'grpc/grpc' require 'grpc/logconfig' -require 'grpc/time_consts' require 'grpc/version' +require 'grpc/core/event' +require 'grpc/core/time_consts' # alias GRPC GRPC = Google::RPC diff --git a/src/ruby/lib/grpc/beefcake.rb b/src/ruby/lib/grpc/beefcake.rb new file mode 100644 index 0000000000..e8d7f0c2cd --- /dev/null +++ b/src/ruby/lib/grpc/beefcake.rb @@ -0,0 +1,62 @@ +# Copyright 2014, Google Inc. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above +# copyright notice, this list of conditions and the following disclaimer +# in the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Google Inc. nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +require 'beefcake' + +# Re-open the beefcake message module to add a static encode +# +# This is a temporary measure while beefcake is used as the default proto +# library for developing grpc ruby. Once that changes to the official proto +# library this can be removed. It's necessary to allow the update the service +# module to assume a static encode method. +# +# TODO(temiola): remove me, once official code generation is available in protoc +module Beefcake + module Message + + # additional mixin module that adds static encode method when include + module StaticEncode + + # encodes o with its instance#encode method + def encode(o) + o.encode + end + + end + + # extend self.included in Beefcake::Message to include StaticEncode + def self.included(o) + o.extend StaticEncode + o.extend Dsl + o.extend Decode + o.send(:include, Encode) + end + + end +end diff --git a/src/ruby/lib/grpc/core/event.rb b/src/ruby/lib/grpc/core/event.rb new file mode 100644 index 0000000000..29486763d5 --- /dev/null +++ b/src/ruby/lib/grpc/core/event.rb @@ -0,0 +1,40 @@ +# Copyright 2014, Google Inc. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above +# copyright notice, this list of conditions and the following disclaimer +# in the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Google Inc. nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +module Google + module RPC + module Core + class Event # Add an inspect method to C-defined Event class. + def inspect + '<%s: type:%s, tag:%s result:%s>' % [self.class, type, tag, result] + end + end + end + end +end diff --git a/src/ruby/lib/grpc/core/time_consts.rb b/src/ruby/lib/grpc/core/time_consts.rb new file mode 100644 index 0000000000..52e4c3f9b9 --- /dev/null +++ b/src/ruby/lib/grpc/core/time_consts.rb @@ -0,0 +1,72 @@ +# Copyright 2014, Google Inc. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above +# copyright notice, this list of conditions and the following disclaimer +# in the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Google Inc. nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +require 'grpc' + +module Google + module RPC + module Core + + module TimeConsts # re-opens a module in the C extension. + + # Converts a time delta to an absolute deadline. + # + # Assumes timeish is a relative time, and converts its to an absolute, + # with following exceptions: + # + # * if timish is one of the TimeConsts.TimeSpec constants the value is + # preserved. + # * timish < 0 => TimeConsts.INFINITE_FUTURE + # * timish == 0 => TimeConsts.ZERO + # + # @param timeish [Number|TimeSpec] + # @return timeish [Number|TimeSpec] + def from_relative_time(timeish) + if timeish.is_a?TimeSpec + timeish + elsif timeish.nil? + TimeConsts::ZERO + elsif !timeish.is_a?Numeric + raise TypeError('Cannot make an absolute deadline from %s', + timeish.inspect) + elsif timeish < 0 + TimeConsts::INFINITE_FUTURE + elsif timeish == 0 + TimeConsts::ZERO + else !timeish.nil? + Time.now + timeish + end + end + + module_function :from_relative_time + + end + end + end +end diff --git a/src/ruby/lib/grpc/event.rb b/src/ruby/lib/grpc/event.rb deleted file mode 100644 index c108cd4c1e..0000000000 --- a/src/ruby/lib/grpc/event.rb +++ /dev/null @@ -1,38 +0,0 @@ -# Copyright 2014, Google Inc. -# All rights reserved. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions are -# met: -# -# * Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# * Redistributions in binary form must reproduce the above -# copyright notice, this list of conditions and the following disclaimer -# in the documentation and/or other materials provided with the -# distribution. -# * Neither the name of Google Inc. nor the names of its -# contributors may be used to endorse or promote products derived from -# this software without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - -module Google - module RPC - class Event # Add an inspect method to C-defined Event class. - def inspect - '<%s: type:%s, tag:%s result:%s>' % [self.class, type, tag, result] - end - end - end -end diff --git a/src/ruby/lib/grpc/generic/active_call.rb b/src/ruby/lib/grpc/generic/active_call.rb index d987b3966f..de35f278a1 100644 --- a/src/ruby/lib/grpc/generic/active_call.rb +++ b/src/ruby/lib/grpc/generic/active_call.rb @@ -40,8 +40,9 @@ module GRPC # The ActiveCall class provides simple methods for sending marshallable # data to a call class ActiveCall - include CompletionType - include StatusCodes + include Core::CompletionType + include Core::StatusCodes + include Core::TimeConsts attr_reader(:deadline) # client_start_invoke begins a client invocation. @@ -55,15 +56,15 @@ module GRPC # @param q [CompletionQueue] used to wait for INVOKE_ACCEPTED # @param deadline [Fixnum,TimeSpec] the deadline for INVOKE_ACCEPTED def self.client_start_invoke(call, q, deadline) - raise ArgumentError.new('not a call') unless call.is_a?Call - if !q.is_a?CompletionQueue + raise ArgumentError.new('not a call') unless call.is_a?Core::Call + if !q.is_a?Core::CompletionQueue raise ArgumentError.new('not a CompletionQueue') end invoke_accepted, client_metadata_read = Object.new, Object.new finished_tag = Object.new call.start_invoke(q, invoke_accepted, client_metadata_read, finished_tag) # wait for the invocation to be accepted - ev = q.pluck(invoke_accepted, TimeConsts::INFINITE_FUTURE) + ev = q.pluck(invoke_accepted, INFINITE_FUTURE) raise OutOfTime if ev.nil? finished_tag end @@ -93,8 +94,8 @@ module GRPC # @param started [true|false] (default true) indicates if the call has begun def initialize(call, q, marshal, unmarshal, deadline, finished_tag: nil, started: true) - raise ArgumentError.new('not a call') unless call.is_a?Call - if !q.is_a?CompletionQueue + raise ArgumentError.new('not a call') unless call.is_a?Core::Call + if !q.is_a?Core::CompletionQueue raise ArgumentError.new('not a CompletionQueue') end @call = call @@ -178,11 +179,11 @@ module GRPC # FINISHED. def writes_done(assert_finished=true) @call.writes_done(self) - ev = @cq.pluck(self, TimeConsts::INFINITE_FUTURE) + ev = @cq.pluck(self, INFINITE_FUTURE) assert_event_type(ev.type, FINISH_ACCEPTED) logger.debug("Writes done: waiting for finish? #{assert_finished}") if assert_finished - ev = @cq.pluck(@finished_tag, TimeConsts::INFINITE_FUTURE) + ev = @cq.pluck(@finished_tag, INFINITE_FUTURE) raise "unexpected event: #{ev.inspect}" if ev.nil? return @call.status end @@ -193,9 +194,9 @@ module GRPC # It blocks until the remote endpoint acknowledges by sending a FINISHED # event. def finished - ev = @cq.pluck(@finished_tag, TimeConsts::INFINITE_FUTURE) + ev = @cq.pluck(@finished_tag, INFINITE_FUTURE) raise "unexpected event: #{ev.inspect}" unless ev.type == FINISHED - if ev.result.code != StatusCodes::OK + if ev.result.code != Core::StatusCodes::OK raise BadStatus.new(ev.result.code, ev.result.details) end res = ev.result @@ -223,11 +224,11 @@ module GRPC else payload = @marshal.call(req) end - @call.start_write(ByteBuffer.new(payload), self) + @call.start_write(Core::ByteBuffer.new(payload), self) # call queue#pluck, and wait for WRITE_ACCEPTED, so as not to return # until the flow control allows another send on this call. - ev = @cq.pluck(self, TimeConsts::INFINITE_FUTURE) + ev = @cq.pluck(self, INFINITE_FUTURE) assert_event_type(ev.type, WRITE_ACCEPTED) ev = nil end @@ -240,8 +241,8 @@ module GRPC # FINISHED. def send_status(code=OK, details='', assert_finished=false) assert_queue_is_ready - @call.start_write_status(Status.new(code, details), self) - ev = @cq.pluck(self, TimeConsts::INFINITE_FUTURE) + @call.start_write_status(Core::Status.new(code, details), self) + ev = @cq.pluck(self, INFINITE_FUTURE) assert_event_type(ev.type, FINISH_ACCEPTED) logger.debug("Status sent: #{code}:'#{details}'") if assert_finished @@ -257,7 +258,7 @@ module GRPC # FINISHED, it returns nil if the status is OK, otherwise raising BadStatus def remote_read @call.start_read(self) - ev = @cq.pluck(self, TimeConsts::INFINITE_FUTURE) + ev = @cq.pluck(self, INFINITE_FUTURE) assert_event_type(ev.type, READ) logger.debug("received req: #{ev.result.inspect}") if !ev.result.nil? @@ -291,7 +292,7 @@ module GRPC return enum_for(:each_remote_read) if !block_given? loop do resp = remote_read() - break if resp.is_a?Status # this will be an OK status, bad statii raise + break if resp.is_a?Core::Status # is an OK status, bad statii raise break if resp.nil? # the last response was received yield resp end @@ -321,7 +322,7 @@ module GRPC return enum_for(:each_remote_read_then_finish) if !block_given? loop do resp = remote_read - break if resp.is_a?Status # this will be an OK status, bad statii raise + break if resp.is_a?Core::Status # is an OK status, bad statii raise if resp.nil? # the last response was received, but not finished yet finished break @@ -339,7 +340,7 @@ module GRPC remote_send(req) writes_done(false) response = remote_read - if !response.is_a?(Status) # finish if status not yet received + if !response.is_a?(Core::Status) # finish if status not yet received finished end response @@ -360,7 +361,7 @@ module GRPC requests.each { |r| remote_send(r) } writes_done(false) response = remote_read - if !response.is_a?(Status) # finish if status not yet received + if !response.is_a?(Core::Status) # finish if status not yet received finished end response @@ -472,7 +473,7 @@ module GRPC # shutdown. def assert_queue_is_ready begin - ev = @cq.pluck(self, TimeConsts::ZERO) + ev = @cq.pluck(self, ZERO) raise "unexpected event #{ev.inspect}" unless ev.nil? rescue OutOfTime # expected, nothing should be on the queue and the deadline was ZERO, diff --git a/src/ruby/lib/grpc/generic/bidi_call.rb b/src/ruby/lib/grpc/generic/bidi_call.rb index a3566e1118..91ceaa90e5 100644 --- a/src/ruby/lib/grpc/generic/bidi_call.rb +++ b/src/ruby/lib/grpc/generic/bidi_call.rb @@ -35,8 +35,9 @@ module GRPC # The BiDiCall class orchestrates exection of a BiDi stream on a client or # server. class BidiCall - include CompletionType - include StatusCodes + include Core::CompletionType + include Core::StatusCodes + include Core::TimeConsts # Creates a BidiCall. # @@ -59,8 +60,8 @@ module GRPC # @param deadline [Fixnum] the deadline for the call to complete # @param finished_tag [Object] the object used as the call's finish tag, def initialize(call, q, marshal, unmarshal, deadline, finished_tag) - raise ArgumentError.new('not a call') unless call.is_a?Call - if !q.is_a?CompletionQueue + raise ArgumentError.new('not a call') unless call.is_a?Core::Call + if !q.is_a?Core::CompletionQueue raise ArgumentError.new('not a CompletionQueue') end @call = call @@ -210,7 +211,7 @@ module GRPC # send the payload payload = @marshal.call(req) - @call.start_write(ByteBuffer.new(payload), self) + @call.start_write(Core::ByteBuffer.new(payload), self) logger.debug("rwloop: sent payload #{req.inspect}") in_write = true return [in_write, done_writing] @@ -259,10 +260,10 @@ module GRPC logger.debug('waiting for another event') if in_write or !done_reading or !pre_finished logger.debug('waiting for another event') - ev = @cq.pluck(self, TimeConsts::INFINITE_FUTURE) + ev = @cq.pluck(self, INFINITE_FUTURE) elsif !finished logger.debug('waiting for another event') - ev = @cq.pluck(@finish_tag, TimeConsts::INFINITE_FUTURE) + ev = @cq.pluck(@finished_tag, INFINITE_FUTURE) else next # no events to wait on, but not done writing end @@ -270,7 +271,7 @@ module GRPC break if done_writing and done_reading if in_write or !done_reading logger.debug('waiting for another event') - ev = @cq.pluck(self, TimeConsts::INFINITE_FUTURE) + ev = @cq.pluck(self, INFINITE_FUTURE) else next # no events to wait on, but not done writing end diff --git a/src/ruby/lib/grpc/generic/client_stub.rb b/src/ruby/lib/grpc/generic/client_stub.rb index fee31e3353..144f9d93ec 100644 --- a/src/ruby/lib/grpc/generic/client_stub.rb +++ b/src/ruby/lib/grpc/generic/client_stub.rb @@ -35,7 +35,7 @@ module GRPC # ClientStub represents an endpoint used to send requests to GRPC servers. class ClientStub - include StatusCodes + include Core::StatusCodes # Default deadline is 5 seconds. DEFAULT_DEADLINE = 5 @@ -62,23 +62,29 @@ module GRPC # when present, this is the default deadline used for calls # # @param host [String] the host the stub connects to - # @param q [TaggedCompletionQueue] used to wait for events - # @param channel_override [Channel] a pre-created channel + # @param q [Core::CompletionQueue] used to wait for events + # @param channel_override [Core::Channel] a pre-created channel # @param deadline [Number] the default deadline to use in requests + # @param creds [Core::Credentials] secures and/or authenticates the channel # @param kw [KeywordArgs] the channel arguments def initialize(host, q, channel_override:nil, deadline:DEFAULT_DEADLINE, + creds:nil, **kw) - if !q.is_a?CompletionQueue + if !q.is_a?Core::CompletionQueue raise ArgumentError.new('not a CompletionQueue') end @host = host if !channel_override.nil? ch = channel_override - raise ArgumentError.new('not a Channel') unless ch.is_a?(Channel) + raise ArgumentError.new('not a Channel') unless ch.is_a?(Core::Channel) + elsif creds.nil? + ch = Core::Channel.new(host, kw) + elsif !creds.is_a?(Core::Credentials) + raise ArgumentError.new('not a Credentials') else - ch = Channel.new(host, **kw) + ch = Core::Channel.new(host, kw, creds) end @deadline = deadline @@ -347,7 +353,7 @@ module GRPC # @param unmarshal [Function] f(string)->obj that unmarshals responses # @param deadline [TimeConst] def new_active_call(ch, marshal, unmarshal, deadline=nil) - absolute_deadline = TimeConsts.from_relative_time(deadline) + absolute_deadline = Core::TimeConsts.from_relative_time(deadline) call = @ch.create_call(ch, @host, absolute_deadline) ActiveCall.new(call, @queue, marshal, unmarshal, absolute_deadline, started:false) diff --git a/src/ruby/lib/grpc/generic/rpc_desc.rb b/src/ruby/lib/grpc/generic/rpc_desc.rb index 43b4d4ffc6..eef886a72f 100644 --- a/src/ruby/lib/grpc/generic/rpc_desc.rb +++ b/src/ruby/lib/grpc/generic/rpc_desc.rb @@ -34,6 +34,7 @@ module GRPC # RpcDesc is a Descriptor of an RPC method. class RpcDesc < Struct.new(:name, :input, :output, :marshal_method, :unmarshal_method) + include Core::StatusCodes # Used to wrap a message class to indicate that it needs to be streamed. class Stream @@ -46,7 +47,7 @@ module GRPC # @return [Proc] { |instance| marshalled(instance) } def marshal_proc - Proc.new { |o| o.method(marshal_method).call.to_s } + Proc.new { |o| o.class.method(marshal_method).call(o).to_s } end # @param [:input, :output] target determines whether to produce the an @@ -82,7 +83,7 @@ module GRPC else # is a bidi_stream active_call.run_server_bidi(mth) end - send_status(active_call, StatusCodes::OK, 'OK') + send_status(active_call, OK, 'OK') active_call.finished rescue BadStatus => e # this is raised by handlers that want GRPC to send an application @@ -97,7 +98,7 @@ module GRPC # This is raised when active_call#method.call exceeeds the deadline # event. Send a status of deadline exceeded logger.warn("late call: #{active_call}") - send_status(active_call, StatusCodes::DEADLINE_EXCEEDED, 'late') + send_status(active_call, DEADLINE_EXCEEDED, 'late') rescue EventError => e # This is raised by GRPC internals but should rarely, if ever happen. # Log it, but don't notify the other endpoint.. @@ -107,7 +108,7 @@ module GRPC # Send back a UNKNOWN status to the client logger.warn("failed handler: #{active_call}; sending status:UNKNOWN") logger.warn(e) - send_status(active_call, StatusCodes::UNKNOWN, 'no reason given') + send_status(active_call, UNKNOWN, 'no reason given') end end diff --git a/src/ruby/lib/grpc/generic/rpc_server.rb b/src/ruby/lib/grpc/generic/rpc_server.rb index e6efdc32c1..ebbf3f9780 100644 --- a/src/ruby/lib/grpc/generic/rpc_server.rb +++ b/src/ruby/lib/grpc/generic/rpc_server.rb @@ -38,7 +38,8 @@ module GRPC # RpcServer hosts a number of services and makes them available on the # network. class RpcServer - include CompletionType + include Core::CompletionType + include Core::TimeConsts extend ::Forwardable def_delegators :@server, :add_http2_port @@ -57,7 +58,7 @@ module GRPC # instance, however other arbitrary are allowed and when present are used # to configure the listeninng connection set up by the RpcServer. # - # * server_override: which if passed must be a [GRPC::Server]. When + # * server_override: which if passed must be a [GRPC::Core::Server]. When # present. # # * poll_period: when present, the server polls for new events with this @@ -70,30 +71,38 @@ module GRPC # completion_queue that the server uses to receive network events, # otherwise its creates a new instance itself # + # * creds: [GRPC::Core::ServerCredentials] + # the credentials used to secure the server + # # * max_waiting_requests: the maximum number of requests that are not # being handled to allow. When this limit is exceeded, the server responds # with not available to new requests def initialize(pool_size:DEFAULT_POOL_SIZE, max_waiting_requests:DEFAULT_MAX_WAITING_REQUESTS, - poll_period:TimeConsts::INFINITE_FUTURE, + poll_period:INFINITE_FUTURE, completion_queue_override:nil, + creds:nil, server_override:nil, **kw) if !completion_queue_override.nil? cq = completion_queue_override - if !cq.is_a?(CompletionQueue) + if !cq.is_a?(Core::CompletionQueue) raise ArgumentError.new('not a CompletionQueue') end else - cq = CompletionQueue.new + cq = Core::CompletionQueue.new end @cq = cq if !server_override.nil? srv = server_override - raise ArgumentError.new('not a Server') unless srv.is_a?(Server) + raise ArgumentError.new('not a Server') unless srv.is_a?(Core::Server) + elsif creds.nil? + srv = Core::Server.new(@cq, kw) + elsif !creds.is_a?(Core::ServerCredentials) + raise ArgumentError.new('not a ServerCredentials') else - srv = Server.new(@cq, **kw) + srv = Core::Server.new(@cq, kw, creds) end @server = srv @@ -236,7 +245,7 @@ module GRPC # Accept the call. This is necessary even if a status is to be sent back # immediately finished_tag = Object.new - call_queue = CompletionQueue.new + call_queue = Core::CompletionQueue.new call.accept(call_queue, finished_tag) # Send UNAVAILABLE if there are too many unprocessed jobs diff --git a/src/ruby/lib/grpc/generic/service.rb b/src/ruby/lib/grpc/generic/service.rb index 1a3d0dc63e..05bb0af809 100644 --- a/src/ruby/lib/grpc/generic/service.rb +++ b/src/ruby/lib/grpc/generic/service.rb @@ -88,12 +88,12 @@ module GRPC # - unmarshal_class method must be a class method on the serializable # message type that takes a string (byte stream) and produces and object # - # - marshal_instance_method is called on a serializable message instance + # - marshal_class_method is called on a serializable message instance # and produces a serialized string. # # The Dsl verifies that the types in the descriptor have both the # unmarshal and marshal methods. - attr_writer(:marshal_instance_method, :unmarshal_class_method) + attr_writer(:marshal_class_method, :unmarshal_class_method) attr_accessor(:service_name) # Adds an RPC spec. @@ -113,7 +113,7 @@ module GRPC assert_can_marshal(input) assert_can_marshal(output) rpc_descs[name] = RpcDesc.new(name, input, output, - marshal_instance_method, + marshal_class_method, unmarshal_class_method) end @@ -125,8 +125,8 @@ module GRPC end # the name of the instance method used to marshal events to a byte stream. - def marshal_instance_method - @marshal_instance_method ||= :marshal + def marshal_class_method + @marshal_class_method ||= :marshal end # the name of the class method used to unmarshal from a byte stream. @@ -144,9 +144,9 @@ module GRPC raise ArgumentError, "#{cls} needs #{cls}.#{mth}" end - mth = marshal_instance_method - if !cls.instance_methods.include?(mth) - raise ArgumentError, "#{cls} needs #{cls}.new.#{mth}" + mth = marshal_class_method + if !cls.methods.include?(mth) + raise ArgumentError, "#{cls} needs #{cls}.#{mth}" end end @@ -173,7 +173,7 @@ module GRPC # @param kw [KeywordArgs] the channel arguments, plus any optional # args for configuring the client's channel def initialize(host, **kw) - super(host, CompletionQueue.new, **kw) + super(host, Core::CompletionQueue.new, **kw) end # Used define_method to add a method for each rpc_desc. Each method diff --git a/src/ruby/lib/grpc/time_consts.rb b/src/ruby/lib/grpc/time_consts.rb deleted file mode 100644 index 2cbab5d965..0000000000 --- a/src/ruby/lib/grpc/time_consts.rb +++ /dev/null @@ -1,69 +0,0 @@ -# Copyright 2014, Google Inc. -# All rights reserved. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions are -# met: -# -# * Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# * Redistributions in binary form must reproduce the above -# copyright notice, this list of conditions and the following disclaimer -# in the documentation and/or other materials provided with the -# distribution. -# * Neither the name of Google Inc. nor the names of its -# contributors may be used to endorse or promote products derived from -# this software without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - -require 'grpc' - -module Google - module RPC - module TimeConsts # re-opens a module in the C extension. - - # Converts a time delta to an absolute deadline. - # - # Assumes timeish is a relative time, and converts its to an absolute, - # with following exceptions: - # - # * if timish is one of the TimeConsts.TimeSpec constants the value is - # preserved. - # * timish < 0 => TimeConsts.INFINITE_FUTURE - # * timish == 0 => TimeConsts.ZERO - # - # @param timeish [Number|TimeSpec] - # @return timeish [Number|TimeSpec] - def from_relative_time(timeish) - if timeish.is_a?TimeSpec - timeish - elsif timeish.nil? - TimeConsts::ZERO - elsif !timeish.is_a?Numeric - raise TypeError('Cannot make an absolute deadline from %s', - timeish.inspect) - elsif timeish < 0 - TimeConsts::INFINITE_FUTURE - elsif timeish == 0 - TimeConsts::ZERO - else !timeish.nil? - Time.now + timeish - end - end - - module_function :from_relative_time - - end - end -end -- cgit v1.2.3