From 2ad8d21158df8b9a7e37b0a966f76b52a61f25e6 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Sat, 7 Mar 2015 08:39:22 -0800 Subject: strcmp: change all !str[n]cmp to str[n]cmp == 0 Change all !str[n]cmp to be str[n]cmp == 0 consistently across the codebase. Issue #231 Signed-off-by: Ronnie Sahlberg --- src/core/tsi/fake_transport_security.c | 4 ++-- src/core/tsi/ssl_transport_security.c | 5 +++-- src/core/tsi/transport_security.c | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) (limited to 'src/core/tsi') diff --git a/src/core/tsi/fake_transport_security.c b/src/core/tsi/fake_transport_security.c index f58f04ea20..9ce1ddb95e 100644 --- a/src/core/tsi/fake_transport_security.c +++ b/src/core/tsi/fake_transport_security.c @@ -102,8 +102,8 @@ static tsi_result tsi_fake_handshake_message_from_string( const char* msg_string, tsi_fake_handshake_message* msg) { int i; for (i = 0; i < TSI_FAKE_HANDSHAKE_MESSAGE_MAX; i++) { - if (!strncmp(msg_string, tsi_fake_handshake_message_strings[i], - strlen(tsi_fake_handshake_message_strings[i]))) { + if (strncmp(msg_string, tsi_fake_handshake_message_strings[i], + strlen(tsi_fake_handshake_message_strings[i])) == 0) { *msg = i; return TSI_OK; } diff --git a/src/core/tsi/ssl_transport_security.c b/src/core/tsi/ssl_transport_security.c index dc43f7e270..33645ca8b8 100644 --- a/src/core/tsi/ssl_transport_security.c +++ b/src/core/tsi/ssl_transport_security.c @@ -1083,7 +1083,8 @@ static int does_entry_match_name(const char* entry, size_t entry_length, if (entry_length == 0) return 0; } - if ((name_length == entry_length) && !strncmp(name, entry, entry_length)) { + if ((name_length == entry_length) && + strncmp(name, entry, entry_length) == 0) { return 1; /* Perfect match. */ } if (entry[0] != '*') return 0; @@ -1110,7 +1111,7 @@ static int does_entry_match_name(const char* entry, size_t entry_length, name_subdomain_length--; } return ((entry_length > 0) && (name_subdomain_length == entry_length) && - !strncmp(entry, name_subdomain, entry_length)); + strncmp(entry, name_subdomain, entry_length) == 0); } static int ssl_server_handshaker_factory_servername_callback(SSL* ssl, int* ap, diff --git a/src/core/tsi/transport_security.c b/src/core/tsi/transport_security.c index c8c74c5de5..f4ab9d2bc6 100644 --- a/src/core/tsi/transport_security.c +++ b/src/core/tsi/transport_security.c @@ -208,7 +208,7 @@ const tsi_peer_property* tsi_peer_get_property_by_name(const tsi_peer* self, return property; } if (name != NULL && property->name != NULL && - !strcmp(property->name, name)) { + strcmp(property->name, name) == 0) { return property; } } -- cgit v1.2.3