From cf1a7e03e73b5e9b3c01d56398869650eb5ccb48 Mon Sep 17 00:00:00 2001 From: Vijay Pai Date: Sat, 4 Apr 2015 10:15:08 -0700 Subject: Remove the racy check added in commit i74c14e5ac752edc7e1dc0aaf31abfd1153df1d0a. This is potentially unsafe since checking the deadline involves more than 1 word read. --- src/core/iomgr/alarm.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/core/iomgr/alarm.c') diff --git a/src/core/iomgr/alarm.c b/src/core/iomgr/alarm.c index 3b7092449a..5860834de3 100644 --- a/src/core/iomgr/alarm.c +++ b/src/core/iomgr/alarm.c @@ -307,10 +307,6 @@ static int run_some_expired_alarms(gpr_mu *drop_mu, gpr_timespec now, /* TODO(ctiller): verify that there are any alarms (atomically) here */ - if (gpr_time_cmp(g_shard_queue[0]->min_deadline, now) >= 0) { - return 0; - } - if (gpr_mu_trylock(&g_checker_mu)) { gpr_mu_lock(&g_mu); -- cgit v1.2.3