From 7ce14d2a008d0df70ec0a43235728f4d5781ee36 Mon Sep 17 00:00:00 2001 From: "Mark D. Roth" Date: Fri, 16 Sep 2016 13:03:46 -0700 Subject: Code review changes. --- src/core/ext/client_config/lb_policy_factory.c | 3 ++- src/core/ext/lb_policy/grpclb/grpclb.c | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/core/ext') diff --git a/src/core/ext/client_config/lb_policy_factory.c b/src/core/ext/client_config/lb_policy_factory.c index e5e416ced9..f86117aa38 100644 --- a/src/core/ext/client_config/lb_policy_factory.c +++ b/src/core/ext/client_config/lb_policy_factory.c @@ -63,8 +63,9 @@ void grpc_lb_addresses_destroy(grpc_lb_addresses* addresses, void (*user_data_destroy)(void*)) { for (size_t i = 0; i < addresses->num_addresses; ++i) { gpr_free(addresses->addresses[i].balancer_name); - if (user_data_destroy != NULL) + if (user_data_destroy != NULL) { user_data_destroy(addresses->addresses[i].user_data); + } } gpr_free(addresses->addresses); gpr_free(addresses); diff --git a/src/core/ext/lb_policy/grpclb/grpclb.c b/src/core/ext/lb_policy/grpclb/grpclb.c index 999122fbe0..36db8ab00d 100644 --- a/src/core/ext/lb_policy/grpclb/grpclb.c +++ b/src/core/ext/lb_policy/grpclb/grpclb.c @@ -354,8 +354,7 @@ static bool is_server_valid(const grpc_grpclb_server *server, size_t idx, return true; } -/* populate \a addresses according to \a serverlist. Returns the number of - * addresses successfully parsed and added to \a addresses */ +/* Returns addresses extracted from \a serverlist. */ static grpc_lb_addresses *process_serverlist( const grpc_grpclb_serverlist *serverlist) { size_t num_valid = 0; -- cgit v1.2.3