From b460622c2d8be2bddcb60cf0682d1b88d9c2357e Mon Sep 17 00:00:00 2001 From: Vijay Pai Date: Tue, 30 Oct 2018 12:35:56 -0700 Subject: Address reviewer comments --- include/grpcpp/impl/codegen/rpc_service_method.h | 10 +++++++++- include/grpcpp/impl/codegen/server_context.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) (limited to 'include') diff --git a/include/grpcpp/impl/codegen/rpc_service_method.h b/include/grpcpp/impl/codegen/rpc_service_method.h index 44d9b8ad63..1890e4254d 100644 --- a/include/grpcpp/impl/codegen/rpc_service_method.h +++ b/include/grpcpp/impl/codegen/rpc_service_method.h @@ -40,6 +40,14 @@ class MethodHandler { public: virtual ~MethodHandler() {} struct HandlerParameter { + /// Constructor for HandlerParameter + /// + /// \param c : the gRPC Call structure for this server call + /// \param context : the ServerContext structure for this server call + /// \param req : the request payload, if appropriate for this RPC + /// \param req_status : the request status after any interceptors have run + /// \param renew : used only by the callback API. It is a function + /// called by the RPC Controller to request another RPC HandlerParameter(Call* c, ServerContext* context, void* req, Status req_status, std::function renew) : call(c), @@ -120,7 +128,7 @@ class RpcServiceMethod : public RpcMethod { const char* TypeToString(RpcServiceMethod::ApiType type) { switch (type) { case ApiType::SYNC: - return "unset"; + return "sync"; case ApiType::ASYNC: return "async"; case ApiType::RAW: diff --git a/include/grpcpp/impl/codegen/server_context.h b/include/grpcpp/impl/codegen/server_context.h index ebbf64bc6d..ecb9073cf9 100644 --- a/include/grpcpp/impl/codegen/server_context.h +++ b/include/grpcpp/impl/codegen/server_context.h @@ -292,6 +292,7 @@ class ServerContext { void BindDeadlineAndMetadata(gpr_timespec deadline, grpc_metadata_array* arr); void Clear(); + void Setup(gpr_timespec deadline); uint32_t initial_metadata_flags() const { return 0; } -- cgit v1.2.3