From ca014e4d5ef0fd72bd9b0b72c427572b85dc795e Mon Sep 17 00:00:00 2001 From: "Mark D. Roth" Date: Wed, 29 Nov 2017 11:34:58 -0800 Subject: Clean up semantics of test code. --- test/core/transport/chttp2/settings_timeout_test.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/core/transport/chttp2/settings_timeout_test.cc b/test/core/transport/chttp2/settings_timeout_test.cc index a1e748d21c..670eae1f79 100644 --- a/test/core/transport/chttp2/settings_timeout_test.cc +++ b/test/core/transport/chttp2/settings_timeout_test.cc @@ -122,8 +122,8 @@ class Client { } // Reads until an error is returned. - // Returns false if no error is returned by the deadline. - bool Read() { + // Returns true if an error was encountered before the deadline. + bool ReadUntilError() { grpc_exec_ctx exec_ctx = GRPC_EXEC_CTX_INIT; grpc_slice_buffer read_buffer; grpc_slice_buffer_init(&read_buffer); @@ -233,7 +233,7 @@ TEST(SettingsTimeout, Basic) { client.Connect(); // Client read. Should fail due to server dropping connection. gpr_log(GPR_INFO, "starting client read"); - EXPECT_TRUE(client.Read()); + EXPECT_TRUE(client.ReadUntilError()); // Shut down client. gpr_log(GPR_INFO, "shutting down client"); client.Shutdown(); -- cgit v1.2.3