From 60478685e72a0bedb740f1f7a5322f3a1bb5e59d Mon Sep 17 00:00:00 2001 From: Nathaniel Manista Date: Mon, 24 Aug 2015 22:35:26 +0000 Subject: Use a custom exception in test_control Use of ValueError is too easily misconstrued as an actual defect in the system under test. --- .../grpcio_test/grpc_test/framework/common/test_control.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/python/grpcio_test/grpc_test/framework/common/test_control.py b/src/python/grpcio_test/grpc_test/framework/common/test_control.py index 3960c4e649..8d6eba5c2c 100644 --- a/src/python/grpcio_test/grpc_test/framework/common/test_control.py +++ b/src/python/grpcio_test/grpc_test/framework/common/test_control.py @@ -34,6 +34,14 @@ import contextlib import threading +class Defect(Exception): + """Simulates a programming defect raised into in a system under test. + + Use of a standard exception type is too easily misconstrued as an actual + defect in either the test infrastructure or the system under test. + """ + + class Control(object): """An object that accepts program control from a system under test. @@ -62,7 +70,7 @@ class PauseFailControl(Control): def control(self): with self._condition: if self._fail: - raise ValueError() + raise Defect() while self._paused: self._condition.wait() -- cgit v1.2.3