From 9f85ead667121f5c74fe232e7908ab774131e1e2 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Wed, 9 Jan 2019 12:06:24 -0800 Subject: Add new proto in examples --- examples/BUILD | 5 +++++ examples/protos/keyvaluestore.proto | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) create mode 100644 examples/protos/keyvaluestore.proto diff --git a/examples/BUILD b/examples/BUILD index c4f25d0de9..b6cb9d48d3 100644 --- a/examples/BUILD +++ b/examples/BUILD @@ -38,6 +38,11 @@ grpc_proto_library( srcs = ["protos/route_guide.proto"], ) +grpc_proto_library( + name = "keyvaluestore", + srcs = ["protos/keyvaluestore.proto"], +) + cc_binary( name = "greeter_client", srcs = ["cpp/helloworld/greeter_client.cc"], diff --git a/examples/protos/keyvaluestore.proto b/examples/protos/keyvaluestore.proto new file mode 100644 index 0000000000..06b516a150 --- /dev/null +++ b/examples/protos/keyvaluestore.proto @@ -0,0 +1,33 @@ +// Copyright 2018 gRPC authors. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +syntax = "proto3"; + +package keyvaluestore; + +// Key value store service definition. +service KeyValueStore { + // Provides a value for each key reques + rpc GetValues (stream Key) returns (stream Value) {} +} + +// The request message containing the key +message Key { + string key = 1; +} + +// The response message containing the greetings +message Value { + string value = 1; +} -- cgit v1.2.3 From 93e84947dfa3c3af2fdaaf5af0c6d6c93dd4e9fc Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Wed, 9 Jan 2019 14:58:50 -0800 Subject: Reviewer comments --- examples/protos/keyvaluestore.proto | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/protos/keyvaluestore.proto b/examples/protos/keyvaluestore.proto index 06b516a150..9b5e53d813 100644 --- a/examples/protos/keyvaluestore.proto +++ b/examples/protos/keyvaluestore.proto @@ -18,16 +18,16 @@ package keyvaluestore; // Key value store service definition. service KeyValueStore { - // Provides a value for each key reques - rpc GetValues (stream Key) returns (stream Value) {} + // Provides a value for each key request + rpc GetValues (stream Request) returns (stream Response) {} } // The request message containing the key -message Key { +message Request { string key = 1; } -// The response message containing the greetings -message Value { +// The response message containing the value associated with the key +message Response { string value = 1; } -- cgit v1.2.3 From de902e18b7db2cd93deff87a17d76ced99a2305a Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Wed, 9 Jan 2019 16:03:29 -0800 Subject: Reviewer comments --- examples/protos/keyvaluestore.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/protos/keyvaluestore.proto b/examples/protos/keyvaluestore.proto index 9b5e53d813..74ad57e029 100644 --- a/examples/protos/keyvaluestore.proto +++ b/examples/protos/keyvaluestore.proto @@ -16,7 +16,7 @@ syntax = "proto3"; package keyvaluestore; -// Key value store service definition. +// A simple key-value storage service service KeyValueStore { // Provides a value for each key request rpc GetValues (stream Request) returns (stream Response) {} -- cgit v1.2.3