From 1c8f36c40b1696ee2fe62cd2d088e4de97e65b14 Mon Sep 17 00:00:00 2001 From: Nathaniel Manista Date: Thu, 21 May 2015 00:09:04 +0000 Subject: Fix mistaken method name: "append", not "add" This defect was originally introduced in Google-internal source control on 18 August 2014. Wow. Clearly unit test coverage is needed for this feature. --- src/python/src/grpc/framework/face/_calls.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/python/src/grpc/framework/face/_calls.py b/src/python/src/grpc/framework/face/_calls.py index 75a550e3c7..87edeb0f0e 100644 --- a/src/python/src/grpc/framework/face/_calls.py +++ b/src/python/src/grpc/framework/face/_calls.py @@ -248,7 +248,7 @@ class _OperationFuture(future.Future): """See future.Future.add_done_callback for specification.""" with self._condition: if self._callbacks is not None: - self._callbacks.add(fn) + self._callbacks.append(fn) return callable_util.call_logging_exceptions(fn, _DONE_CALLBACK_LOG_MESSAGE, self) -- cgit v1.2.3