aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
...
* | | | | | | | | Merge pull request #13834 from dgquintas/debug_location_namespaceGravatar David G. Quintas2017-12-20
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Add namespace to macro expansion
| | * | | | | | | | Disable so_reuseport for Python testsGravatar Ken Payson2017-12-20
| | | | | | | | | |
| | | * | | | | | | Add a start_cb to grpc_udp_listener to be called when listener isGravatar Dan Zhang2017-12-20
| |_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | created.
| * | | | | | | | Add namespace to macro expansionGravatar David Garcia Quintas2017-12-20
| | | | | | | | |
* | | | | | | | | Merge pull request #13811 from ita9naiwa/masterGravatar Noah Eisen2017-12-19
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Typo fix
* \ \ \ \ \ \ \ \ \ Merge pull request #13831 from dgquintas/fix_wrong_slice_unrefGravatar David G. Quintas2017-12-19
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fix wrong unreffing of slice
* \ \ \ \ \ \ \ \ \ \ Merge pull request #13833 from ncteisen/commentsGravatar Noah Eisen2017-12-19
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / |/| | | | | | | | | | Add ownership semantic comments to error.h
| | | | | * | | | | | Bump to 1.8.2Gravatar Ken Payson2017-12-19
| | | | | | | | | | |
| | | | | * | | | | | Merge pull request #13665 from kpayson64/poll_spin_bugGravatar kpayson642017-12-19
| | | | | |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix a Python spinlock bug
| * | | | | | | | | | | Add ownership semantic comments to error.hGravatar ncteisen2017-12-19
| | | | | | | | | | | |
| | * | | | | | | | | | Fix wrong unreffing of sliceGravatar David Garcia Quintas2017-12-19
| |/ / / / / / / / / / |/| | | | | | | | | |
| | | | | * | | | | | Fix a Python spinlock bugGravatar Ken Payson2017-12-19
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #13494 from dgquintas/backoff_cppGravatar David G. Quintas2017-12-19
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | C++-ize backoff
| * | | | | | | | | | | Create copy of "ac" data instead of stretching the locked sectionGravatar David Garcia Quintas2017-12-19
| | | | | | | | | | | |
| * | | | | | | | | | | Fix use-after-free caused by unsync'd access in tcp_client_posix.Gravatar David Garcia Quintas2017-12-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tc_on_alarm() and on_writable() race, resulting in the following: ``` D1219 08:59:33.425951347 86323 tcp_client_posix.cc:143] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_writable: error="No Error" D1219 08:59:33.426032150 86342 tcp_client_posix.cc:104] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_alarm: error="No Error" // At this point, note that the callbacks are running on different threads. D1219 08:59:33.426063521 86323 tcp_client_posix.cc:218] XXX on_writable ac->addr_str 0x603000008dd0 before unlock. # refs 2->1. Done 0 // on_writable() unrefs while still holding the lock. Because refs > 0, it marks its "done" as false and unlocks. D1219 08:59:33.426125130 86342 tcp_client_posix.cc:113] XXX tc_on_alarm ac->addr_str 0x603000008dd0 before unlock. # refs 1->0. Done 1 // right after on_writable() unlocks, tc_on_alarm() acquires the lock and unrefs, this time getting to zero and marking its "done" as true. // It then proceeds to destroy "ac", and, in particular for this failure, "ac->addr_str". D1219 08:59:33.426139370 86323 tcp_client_posix.cc:234] XXX on_writable about to read from ac->addr_str 0x603000008dd0. Done 0, error=OS Error // When on_writable() tries to read ac->addr_str to assemble its error details, it causes a use-after-free. ``` The problem is the lock isn't held long enough by on_writable(). Alternatively, a copy of ac->addr_str could be made in on_writable() while still holding the lock, but that seems more fragile. It doesn't seem that holding the lock longer would be a performance issue, given we are in a failure scenario.
* | | | | | | | | | | | Fix internal TSAN bugGravatar Noah Eisen2017-12-19
| |/ / / / / / / / / / |/| | | | | | | | | |
| | | | | | | | | * | Merge branch 'master' of https://github.com/grpc/grpc into flow-control-part4Gravatar ncteisen2017-12-18
| | | | | | | | | |\ \ | |_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | |
* | | | | | | | | | | Merge pull request #13798 from apolcyn/min_max_rpc_version_constantsGravatar apolcyn2017-12-18
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Define RPC protocol version constants
| * | | | | | | | | | | Define RPC protocol version constantsGravatar Alexander Polcyn2017-12-18
| | |_|_|_|_|_|_|/ / / | |/| | | | | | | | |
* | | | | | | | | | | Merge pull request #13777 from frankyn/patch-1Gravatar apolcyn2017-12-18
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / / / |/| | | | | | | | | | [Ruby] Specify module init in README
| | | | * | | | | | | minor typo : becuase -> becauseGravatar ita9naiwa2017-12-19
| |_|_|/ / / / / / / |/| | | | | | | | |
* | | | | | | | | | Merge pull request #13776 from ncteisen/executor-tsanGravatar Noah Eisen2017-12-15
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fix shutdown executor tsan bug
* \ \ \ \ \ \ \ \ \ \ Merge pull request #13771 from yang-g/deleteGravatar Yang Gao2017-12-15
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Mark tcp errors as UNAVAILABLE
| | | | | * \ \ \ \ \ \ Merge branch 'master' of github.com:grpc/grpc into backoff_cppGravatar David Garcia Quintas2017-12-15
| | | | | |\ \ \ \ \ \ \ | |_|_|_|_|/ / / / / / / |/| | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #13774 from apolcyn/disable_soreuseport_in_ruby_testsGravatar apolcyn2017-12-15
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Tentatively disable so_reuseport in ruby tests
| | | | | | | | * \ \ \ \ Merge pull request #13759 from murgatroid99/node_deletion_againGravatar Michael Lumish2017-12-14
| | | | | | | | |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Delete node-related files again
| | | | | | | | * | | | | | Bump version to 1.8.1Gravatar Mehrdad Afshari2017-12-14
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge pull request #13789 from grpc/v1.8.xGravatar Mehrdad Afshari2017-12-14
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|/ / / / / / | |/| | | | | | | | | | | | Upmerge changes from v1.8.x to master
| * | | | | | | | | | | | | Merge pull request #13786 from kpayson64/fix_python_server_raceGravatar kpayson642017-12-14
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes race condition in Python server shutdown
| | * | | | | | | | | | | | | Fixes race condition in Python server shutdownGravatar Ken Payson2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we set the call state to "CANCELLED" after grpc_cancel_all_calls, we would block other start batch operations from happening. The rpc_state for the cancelled call would still be in the server's rpc_states set, but it would never get removed because there were no active batches for the call, and the only place we remove from rpc_states is when a batch completes. It is better to rely on c-core's cancellation. Once a call is cancelled, all subsequent ops on that call will return immediately with a cancellation error. The RLock() change is due to the possibility that _on_call_completed gets invoked immediately when the call has already completed when the rpc_future callback is created.
| | | | | * | | | | | | | | | Fix executor tsan bugGravatar ncteisen2017-12-14
| |_|_|_|/ / / / / / / / / / |/| | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge pull request #13773 from ncteisen/tsanGravatar Noah Eisen2017-12-14
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / / / / / / |/| | | | | | | | | | | | | Fix tsan in bad_client tests
| | * | | | | | | | | | | | Reallow out-of-spec metadataGravatar Nathaniel Manista2017-12-14
| | |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This restore unsupported, de facto behavior that was dropped in 80516e884a8cd03daaa1f4a40d2bb2 but that it turns out a lot of folks have been using.
| | | | | * / / / / / / / [Ruby] Specify module init after cloning repoGravatar Frank Natividad2017-12-14
| |_|_|_|/ / / / / / / / |/| | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #13764 from kpayson64/fix_unused_paramGravatar kpayson642017-12-13
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Fix unused parameter warning in cpp codegen
| | * | | | | | | | | | | Fix tsan in bad_client testsGravatar Noah Eisen2017-12-13
| |/ / / / / / / / / / / |/| | | | | | | | | | |
| | | * | | | | | | | | Disable soreuseport in ruby unit testsGravatar Alexander Polcyn2017-12-13
| | | | | | | | | | | |
| | | | * | | | | | | | Mark tcp errors as UNAVAILABLEGravatar yang-g2017-12-13
| | | | | |_|_|_|/ / / | | | | |/| | | | | |
| | | | | | | | | | * metadata plugin update statuses in wrapped langsGravatar Jan Tattermusch2017-12-14
| | | | | | | | | | |
| | | | | | | | | | * Revert "Revert "Switching from UNAUTHENTICATED to UNAVAILABLE for auth ↵Gravatar Jan Tattermusch2017-12-14
| |_|_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | metadata failure""
* | | | | | | | | | Merge pull request #13754 from muxi/fix-stream-compression-gzipGravatar Muxi Yan2017-12-13
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / / |/| | | | | | | | | Fix stream_compression_payload flake
| | * | | | | | | | Fix unused parameter warning in cpp codegenGravatar Ken Payson2017-12-13
| |/ / / / / / / / |/| | | | | | | |
| | | | | * | | | Merge branch 'master' of github.com:grpc/grpc into backoff_cppGravatar David Garcia Quintas2017-12-13
| | | | | |\ \ \ \ | |_|_|_|_|/ / / / |/| | | | | | | |
| | | | | * | | | Fixed wrong conversion factorGravatar David Garcia Quintas2017-12-13
| | | | | | | | |
| | | | | | * | | Delete node-related files againGravatar murgatroid992017-12-13
| | | | | | | | |
| * | | | | | | | Fix inline/refcounted slice problem in gzipGravatar Muxi Yan2017-12-13
| | |_|/ / / / / | |/| | | | | |
* | | | | | | | Merge pull request #13739 from jtattermusch/csharp_gen_headerGravatar Jan Tattermusch2017-12-13
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | C# plugin should add auto-generated header for generated files.
* \ \ \ \ \ \ \ \ Merge pull request #13450 from daniel-j-born/tcp_clientGravatar Mark D. Roth2017-12-13
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Refactor POSIX TCP client connect.
| | * | | | | | | | regenerateGravatar Jan Tattermusch2017-12-13
| | | | | | | | | |
| | * | | | | | | | use auto-generated header for C# pluginGravatar Jan Tattermusch2017-12-13
| | | | | | | | | |