Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | PR comments | David Garcia Quintas | 2018-01-09 |
| | |||
* | Connected subchannel refactoring | David Garcia Quintas | 2018-01-05 |
| | |||
* | Revert "Fix a Python spinlock bug" | Mehrdad Afshari | 2018-01-02 |
| | | | | This reverts commit 2df509fc0e8628d6d4431139ce953c70796a21eb. | ||
* | Fix struct names | Vijay Pai | 2018-01-01 |
| | |||
* | Merge branch v1.8.x into master | Mehrdad Afshari | 2017-12-31 |
|\ | | | | | | | Upmerge v1.8.3 into master | ||
| * | Relax log-level when polling engines are undefined | Mehrdad Afshari | 2017-12-29 |
| | | |||
* | | Merge branch 'master' into startcb | Dan Zhang | 2017-12-20 |
|\ \ | |||
| * \ | Merge pull request #13834 from dgquintas/debug_location_namespace | David G. Quintas | 2017-12-20 |
| |\ \ | | | | | | | | | Add namespace to macro expansion | ||
* | | | | Add a start_cb to grpc_udp_listener to be called when listener is | Dan Zhang | 2017-12-20 |
|/ / / | | | | | | | | | | created. | ||
| * | | Add namespace to macro expansion | David Garcia Quintas | 2017-12-20 |
| | | | |||
* | | | Merge pull request #13811 from ita9naiwa/master | Noah Eisen | 2017-12-19 |
|\ \ \ | | | | | | | | | Typo fix | ||
* \ \ \ | Merge pull request #13831 from dgquintas/fix_wrong_slice_unref | David G. Quintas | 2017-12-19 |
|\ \ \ \ | | | | | | | | | | | Fix wrong unreffing of slice | ||
* \ \ \ \ | Merge pull request #13833 from ncteisen/comments | Noah Eisen | 2017-12-19 |
|\ \ \ \ \ | |_|_|/ / |/| | | | | Add ownership semantic comments to error.h | ||
| | | | * | Merge pull request #13665 from kpayson64/poll_spin_bug | kpayson64 | 2017-12-19 |
| | | | |\ | | | | | | | | | | | | | Fix a Python spinlock bug | ||
| * | | | | | Add ownership semantic comments to error.h | ncteisen | 2017-12-19 |
| | | | | | | |||
| | * | | | | Fix wrong unreffing of slice | David Garcia Quintas | 2017-12-19 |
| |/ / / / |/| | | | | |||
| | | | * | Fix a Python spinlock bug | Ken Payson | 2017-12-19 |
| | | | | | |||
* | | | | | Merge pull request #13494 from dgquintas/backoff_cpp | David G. Quintas | 2017-12-19 |
|\ \ \ \ \ | | | | | | | | | | | | | C++-ize backoff | ||
| * | | | | | Create copy of "ac" data instead of stretching the locked section | David Garcia Quintas | 2017-12-19 |
| | | | | | | |||
| * | | | | | Fix use-after-free caused by unsync'd access in tcp_client_posix. | David Garcia Quintas | 2017-12-19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tc_on_alarm() and on_writable() race, resulting in the following: ``` D1219 08:59:33.425951347 86323 tcp_client_posix.cc:143] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_writable: error="No Error" D1219 08:59:33.426032150 86342 tcp_client_posix.cc:104] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_alarm: error="No Error" // At this point, note that the callbacks are running on different threads. D1219 08:59:33.426063521 86323 tcp_client_posix.cc:218] XXX on_writable ac->addr_str 0x603000008dd0 before unlock. # refs 2->1. Done 0 // on_writable() unrefs while still holding the lock. Because refs > 0, it marks its "done" as false and unlocks. D1219 08:59:33.426125130 86342 tcp_client_posix.cc:113] XXX tc_on_alarm ac->addr_str 0x603000008dd0 before unlock. # refs 1->0. Done 1 // right after on_writable() unlocks, tc_on_alarm() acquires the lock and unrefs, this time getting to zero and marking its "done" as true. // It then proceeds to destroy "ac", and, in particular for this failure, "ac->addr_str". D1219 08:59:33.426139370 86323 tcp_client_posix.cc:234] XXX on_writable about to read from ac->addr_str 0x603000008dd0. Done 0, error=OS Error // When on_writable() tries to read ac->addr_str to assemble its error details, it causes a use-after-free. ``` The problem is the lock isn't held long enough by on_writable(). Alternatively, a copy of ac->addr_str could be made in on_writable() while still holding the lock, but that seems more fragile. It doesn't seem that holding the lock longer would be a performance issue, given we are in a failure scenario. | ||
* | | | | | | Fix internal TSAN bug | Noah Eisen | 2017-12-19 |
| |/ / / / |/| | | | | |||
* | | | | | Merge pull request #13798 from apolcyn/min_max_rpc_version_constants | apolcyn | 2017-12-18 |
|\ \ \ \ \ | | | | | | | | | | | | | Define RPC protocol version constants | ||
| * | | | | | Define RPC protocol version constants | Alexander Polcyn | 2017-12-18 |
| | | | | | | |||
| | | * | | | minor typo : becuase -> because | ita9naiwa | 2017-12-19 |
| |_|/ / / |/| | | | | |||
* | | | | | Merge pull request #13776 from ncteisen/executor-tsan | Noah Eisen | 2017-12-15 |
|\ \ \ \ \ | | | | | | | | | | | | | Fix shutdown executor tsan bug | ||
* \ \ \ \ \ | Merge pull request #13771 from yang-g/delete | Yang Gao | 2017-12-15 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Mark tcp errors as UNAVAILABLE | ||
| | | | * \ \ | Merge branch 'master' of github.com:grpc/grpc into backoff_cpp | David Garcia Quintas | 2017-12-15 |
| | | | |\ \ \ | |_|_|_|/ / / |/| | | | | | | |||
| | * | | | | | Fix executor tsan bug | ncteisen | 2017-12-14 |
| |/ / / / / |/| | | | | | |||
* | | | | | | Fix tsan in bad_client tests | Noah Eisen | 2017-12-13 |
| |/ / / / |/| | | | | |||
| * | | | | Mark tcp errors as UNAVAILABLE | yang-g | 2017-12-13 |
| | | | | | |||
* | | | | | Merge pull request #13754 from muxi/fix-stream-compression-gzip | Muxi Yan | 2017-12-13 |
|\ \ \ \ \ | | | | | | | | | | | | | Fix stream_compression_payload flake | ||
| | | * \ \ | Merge branch 'master' of github.com:grpc/grpc into backoff_cpp | David Garcia Quintas | 2017-12-13 |
| | | |\ \ \ | |_|_|/ / / |/| | | | | | |||
| * | | | | | Fix inline/refcounted slice problem in gzip | Muxi Yan | 2017-12-13 |
| |/ / / / | |||
* | | | | | Merge pull request #13450 from daniel-j-born/tcp_client | Mark D. Roth | 2017-12-13 |
|\ \ \ \ \ | | | | | | | | | | | | | Refactor POSIX TCP client connect. | ||
| | | | * | | fix or slow down windows socket leak | Junsung Ko | 2017-12-12 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | related issue https://github.com/grpc/grpc/issues/13519 https://github.com/grpc/grpc/issues/13102 | ||
* | | | | | | Merge pull request #13604 from yayaboring/master | Jan Tattermusch | 2017-12-12 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | fix or slow down windows socket leak | ||
| | | | | * | | v1.8.0-pre2 is now v1.8.0 | Mehrdad Afshari | 2017-12-12 |
| | | | | |/ | |||
* | | | | | | Merge pull request #13631 from sreecha/cv-wait-monotonic | Sree Kuchibhotla | 2017-12-12 |
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | Use monotonic clock type for gpr_cv_wait | ||
| | | * | | | Refactor POSIX TCP client connect. | Dan Born | 2017-12-12 |
| | | | | | | |||
* | | | | | | Use the correct env var name | yang-g | 2017-12-11 |
| |_|/ / / |/| | | | | |||
| * | | | | Merge branch 'master' into cv-wait-monotonic | Sree Kuchibhotla | 2017-12-08 |
| |\ \ \ \ | |/ / / / |/| | | | | |||
* | | | | | Disallow delete on ExecCtx | Yash Tibrewal | 2017-12-08 |
| | | | | | |||
* | | | | | virtual destructor in exec_ctx, remove unneeded flush in grpc_shutdown and ↵ | Yash Tibrewal | 2017-12-07 |
| | | | | | | | | | | | | | | | | | | | | remove grpc_exec_ctx from .pxi files in python | ||
* | | | | | Merge master | Yash Tibrewal | 2017-12-07 |
|\ \ \ \ \ | |||
| * \ \ \ \ | Merge pull request #13647 from y-zeng/send_ping | Yuchen Zeng | 2017-12-07 |
| |\ \ \ \ \ | | | | | | | | | | | | | | | Add on_initiate callback for the send_ping tranport op | ||
* | | | | | | | Revert "Revert "All instances of exec_ctx being passed around in src/core ↵ | Yash Tibrewal | 2017-12-06 |
|/ / / / / / | | | | | | | | | | | | | | | | | | | removed"" | ||
* | | | | | | Revert "All instances of exec_ctx being passed around in src/core removed" | Yash Tibrewal | 2017-12-06 |
| | | | | | | |||
* | | | | | | Merge pull request #13058 from yashykt/execctx | Yash Tibrewal | 2017-12-05 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | All instances of exec_ctx being passed around in src/core removed | ||
* \ \ \ \ \ \ | Merge pull request #13559 from dmaclach/threadnames | Vijay Pai | 2017-12-05 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Add thread naming support on platforms that support it. | ||
| | * \ \ \ \ \ | Merge master into execctx | Yash Tibrewal | 2017-12-05 |
| | |\ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | |