Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | Merge pull request #13975 from danzh2010/adjustrcvbuf | Yang Gao | 2018-01-12 |
|\ | | | | | change udp_server receive/send buffer size and set SO_RXQ_OVFL | ||
* | | Revert "Revert "Set error status correctly on server side"" | Ken Payson | 2018-01-11 |
| | | | | | | | | This reverts commit 951f84aea00a1f8a65cf160d7d8f342c30593000. | ||
* | | Revert "Set error status correctly on server side" | David G. Quintas | 2018-01-11 |
| | | |||
| * | format | Dan Zhang | 2018-01-11 |
| | | |||
| * | %zd->%d | Dan Zhang | 2018-01-11 |
| | | |||
| * | change to int type | Dan Zhang | 2018-01-11 |
| | | |||
| * | fix portability errors | Dan Zhang | 2018-01-11 |
| | | |||
* | | Merge pull request #13676 from markdroth/inlined_vector | Mark D. Roth | 2018-01-11 |
|\ \ | | | | | | | Implement InlinedVector independently of absl. | ||
* | | | exec_ctx_fwd.h should never have been in public headers | Vijay Pai | 2018-01-10 |
| | | | |||
| | * | change to pass in value | Dan Zhang | 2018-01-10 |
| | | | |||
| * | | Implement InlinedVector independently of absl. | Mark D. Roth | 2018-01-10 |
| | | | |||
| | * | Adjust receiv buffer via setsockopt for udp_server's listening socket. | Dan Zhang | 2018-01-10 |
| |/ |/| | | | | | | | Since this socket is used for all incoming traffic, its current buffer 1MB is appearantly too small. Change it to 10 MB for now. | ||
* | | Merge pull request #13912 from ncteisen/nullptr | David G. Quintas | 2018-01-09 |
|\ \ | |/ |/| | Missing s/NULL/nullptr | ||
* | | Merge pull request #13933 from kpayson64/avoid_stall | kpayson64 | 2018-01-08 |
|\ \ | | | | | | | Avoid stall | ||
| * | | Fix bug with pollhup workaround | Ken Payson | 2018-01-05 |
| | | | |||
* | | | Merge pull request #13931 from apolcyn/merge_18x | apolcyn | 2018-01-05 |
|\ \ \ | | | | | | | | | Merge 1.8.x into master | ||
| * | | | Manual merge conflict resolve: remove exec_ctx param from tcp_free | Alexander Polcyn | 2018-01-05 |
| | | | | |||
| | * | | Fix a Python spinlock bug | Ken Payson | 2018-01-05 |
| | | | | |||
* | | | | Merge pull request #13900 from vjpai/odr | Vijay Pai | 2018-01-05 |
|\ \ \ \ | | | | | | | | | | | Wrap duplicated-name definitions in anonymous namespace (except for iomgr) | ||
| | * | | | Merge remote-tracking branch 'upstream/v1.8.x' into merge_18x | Alexander Polcyn | 2018-01-05 |
| |/| | | |/| | | | | |||
* | | | | | Set error status correctly on server side | Ken Payson | 2018-01-04 |
| | | | | | |||
| | * | | | Mark tcp errors as UNAVAILABLE in UV tcp code | murgatroid99 | 2018-01-04 |
| | | | | | |||
| | | | * | Missing s/NULL/nullptr | ncteisen | 2018-01-03 |
| |_|_|/ |/| | | | |||
| * | | | Revert unneeded changes | Vijay Pai | 2018-01-03 |
| | | | | |||
| * | | | Wrap duplicated-name definitions in anonymous namespace | Vijay Pai | 2018-01-02 |
| | | | | |||
* | | | | Revert "Fix a Python spinlock bug" | Mehrdad Afshari | 2018-01-02 |
|/ / / | | | | | | | | | | This reverts commit 2df509fc0e8628d6d4431139ce953c70796a21eb. | ||
* | | | Fix struct names | Vijay Pai | 2018-01-01 |
| | | | |||
* | | | Merge branch v1.8.x into master | Mehrdad Afshari | 2017-12-31 |
|\| | | | | | | | | | | | Upmerge v1.8.3 into master | ||
| * | | Relax log-level when polling engines are undefined | Mehrdad Afshari | 2017-12-29 |
| | | | |||
* | | | Merge branch 'master' into startcb | Dan Zhang | 2017-12-20 |
|\ \ \ | |||
| * \ \ | Merge pull request #13834 from dgquintas/debug_location_namespace | David G. Quintas | 2017-12-20 |
| |\ \ \ | | | | | | | | | | | Add namespace to macro expansion | ||
* | | | | | Add a start_cb to grpc_udp_listener to be called when listener is | Dan Zhang | 2017-12-20 |
|/ / / / | | | | | | | | | | | | | created. | ||
| * | | | Add namespace to macro expansion | David Garcia Quintas | 2017-12-20 |
| | | | | |||
* | | | | Merge pull request #13811 from ita9naiwa/master | Noah Eisen | 2017-12-19 |
|\ \ \ \ | | | | | | | | | | | Typo fix | ||
* \ \ \ \ | Merge pull request #13831 from dgquintas/fix_wrong_slice_unref | David G. Quintas | 2017-12-19 |
|\ \ \ \ \ | | | | | | | | | | | | | Fix wrong unreffing of slice | ||
* \ \ \ \ \ | Merge pull request #13833 from ncteisen/comments | Noah Eisen | 2017-12-19 |
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | Add ownership semantic comments to error.h | ||
| | | | * | | Merge pull request #13665 from kpayson64/poll_spin_bug | kpayson64 | 2017-12-19 |
| | | | |\ \ | | | | | | | | | | | | | | | Fix a Python spinlock bug | ||
| * | | | | | | Add ownership semantic comments to error.h | ncteisen | 2017-12-19 |
| | | | | | | | |||
| | * | | | | | Fix wrong unreffing of slice | David Garcia Quintas | 2017-12-19 |
| |/ / / / / |/| | | | | | |||
| | | | * | | Fix a Python spinlock bug | Ken Payson | 2017-12-19 |
| | | | | | | |||
* | | | | | | Merge pull request #13494 from dgquintas/backoff_cpp | David G. Quintas | 2017-12-19 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | C++-ize backoff | ||
| * | | | | | | Create copy of "ac" data instead of stretching the locked section | David Garcia Quintas | 2017-12-19 |
| | | | | | | | |||
| * | | | | | | Fix use-after-free caused by unsync'd access in tcp_client_posix. | David Garcia Quintas | 2017-12-19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tc_on_alarm() and on_writable() race, resulting in the following: ``` D1219 08:59:33.425951347 86323 tcp_client_posix.cc:143] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_writable: error="No Error" D1219 08:59:33.426032150 86342 tcp_client_posix.cc:104] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_alarm: error="No Error" // At this point, note that the callbacks are running on different threads. D1219 08:59:33.426063521 86323 tcp_client_posix.cc:218] XXX on_writable ac->addr_str 0x603000008dd0 before unlock. # refs 2->1. Done 0 // on_writable() unrefs while still holding the lock. Because refs > 0, it marks its "done" as false and unlocks. D1219 08:59:33.426125130 86342 tcp_client_posix.cc:113] XXX tc_on_alarm ac->addr_str 0x603000008dd0 before unlock. # refs 1->0. Done 1 // right after on_writable() unlocks, tc_on_alarm() acquires the lock and unrefs, this time getting to zero and marking its "done" as true. // It then proceeds to destroy "ac", and, in particular for this failure, "ac->addr_str". D1219 08:59:33.426139370 86323 tcp_client_posix.cc:234] XXX on_writable about to read from ac->addr_str 0x603000008dd0. Done 0, error=OS Error // When on_writable() tries to read ac->addr_str to assemble its error details, it causes a use-after-free. ``` The problem is the lock isn't held long enough by on_writable(). Alternatively, a copy of ac->addr_str could be made in on_writable() while still holding the lock, but that seems more fragile. It doesn't seem that holding the lock longer would be a performance issue, given we are in a failure scenario. | ||
* | | | | | | | Fix internal TSAN bug | Noah Eisen | 2017-12-19 |
| |/ / / / / |/| | | | | | |||
* | | | | | | Merge pull request #13798 from apolcyn/min_max_rpc_version_constants | apolcyn | 2017-12-18 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Define RPC protocol version constants | ||
| * | | | | | | Define RPC protocol version constants | Alexander Polcyn | 2017-12-18 |
| | | | | | | | |||
| | | * | | | | minor typo : becuase -> because | ita9naiwa | 2017-12-19 |
| |_|/ / / / |/| | | | | | |||
* | | | | | | Merge pull request #13776 from ncteisen/executor-tsan | Noah Eisen | 2017-12-15 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix shutdown executor tsan bug | ||
* \ \ \ \ \ \ | Merge pull request #13771 from yang-g/delete | Yang Gao | 2017-12-15 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Mark tcp errors as UNAVAILABLE | ||
| | | | * \ \ \ | Merge branch 'master' of github.com:grpc/grpc into backoff_cpp | David Garcia Quintas | 2017-12-15 |
| | | | |\ \ \ \ | |_|_|_|/ / / / |/| | | | | | | |