aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Pass KOKORO_BUILD_ID to DockerGravatar Matt Kwong2017-12-20
|
* Merge branch 'master' into kokoro-urlGravatar Matt Kwong2017-12-20
|\
| * Merge pull request #13834 from dgquintas/debug_location_namespaceGravatar David G. Quintas2017-12-20
| |\ | | | | | | Add namespace to macro expansion
| | * Add namespace to macro expansionGravatar David Garcia Quintas2017-12-20
| | |
| * | Merge pull request #13835 from muxi/use-build-yaml-in-podspecGravatar Muxi Yan2017-12-20
| |\ \ | | | | | | | | Generate more files in gRPC-Core.podspec from build.yaml
| * \ \ Merge pull request #13837 from yang-g/interopGravatar Yang Gao2017-12-20
| |\ \ \ | | | | | | | | | | When seeing an error in interop test, also log the debug error string.
| * \ \ \ Merge pull request #13811 from ita9naiwa/masterGravatar Noah Eisen2017-12-19
| |\ \ \ \ | | | | | | | | | | | | Typo fix
| * \ \ \ \ Merge pull request #13838 from apolcyn/fix_parse_commandline_flagsGravatar apolcyn2017-12-19
| |\ \ \ \ \ | | | | | | | | | | | | | | Use ParseCommandLineFlags in golden file test in the same way that other test binaries use it
| * \ \ \ \ \ Merge pull request #13836 from apolcyn/mark_testonlyGravatar apolcyn2017-12-19
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Mark one test binary as testonly
| * \ \ \ \ \ \ Merge pull request #13831 from dgquintas/fix_wrong_slice_unrefGravatar David G. Quintas2017-12-19
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix wrong unreffing of slice
| * \ \ \ \ \ \ \ Merge pull request #13824 from ncteisen/fix-trickleGravatar Noah Eisen2017-12-19
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Make benchmark tests use correct timeout
| * \ \ \ \ \ \ \ \ Merge pull request #13833 from ncteisen/commentsGravatar Noah Eisen2017-12-19
| |\ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|/ | |/| | | | | | | | Add ownership semantic comments to error.h
| | | | | | * | | | Use the same ParseCommandLineFlags for golden file test that is used in ↵Gravatar Alexander Polcyn2017-12-19
| | | | | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | other test binaries
| | | | | | | * / When seeing an error in interop test, also log the debug error string.Gravatar yang-g2017-12-19
| | |_|_|_|_|/ / | |/| | | | | |
| | | | | * | | Mark one test binary as testonlyGravatar Alexander Polcyn2017-12-19
| | |_|_|/ / / | |/| | | | |
| | | | | | * Generate more files in gRPC-Core.podspec from build.yamlGravatar Muxi Yan2017-12-19
| | |_|_|_|/ | |/| | | |
| | * | | | Add ownership semantic comments to error.hGravatar ncteisen2017-12-19
| | | | | |
| | | * | | Use correct timeout for benchmarksGravatar ncteisen2017-12-19
| | |/ / / | |/| | |
| | | * | Fix wrong unreffing of sliceGravatar David Garcia Quintas2017-12-19
| | |/ / | |/| |
| * | | Merge pull request #13823 from mehrdada/shellcheckify-runtests-slash-sanityGravatar Mehrdad Afshari2017-12-19
| |\ \ \ | | | | | | | | | | shellcheckify `tools/run_tests/sanity`
| * \ \ \ Merge pull request #13494 from dgquintas/backoff_cppGravatar David G. Quintas2017-12-19
| |\ \ \ \ | | | | | | | | | | | | C++-ize backoff
| * \ \ \ \ Merge pull request #13720 from apolcyn/enable_golden_file_test_in_bazelGravatar apolcyn2017-12-19
| |\ \ \ \ \ | | | | | | | | | | | | | | Fix golden file test under bazel
| * \ \ \ \ \ Merge pull request #13822 from grpc/error-tsanGravatar Noah Eisen2017-12-19
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix internal TSAN bug
| | | | | * | | Enforce shellcheck on tools/run_tests/sanityGravatar Mehrdad Afshari2017-12-19
| | | | | | | |
| | | | | * | | Fix core_untyped_structs.sh to pass shellcheckGravatar Mehrdad Afshari2017-12-19
| | | | | | | |
| | | | | * | | Fix check_unsecure.sh to pass shellcheckGravatar Mehrdad Afshari2017-12-19
| | | | | | | |
| | | | | * | | Fix check_submodules.sh to pass shellcheckGravatar Mehrdad Afshari2017-12-19
| | | | | | | |
| | | | | * | | Fix check_owners.sh to pass shellcheckGravatar Mehrdad Afshari2017-12-19
| | | | | | | |
| | | | | * | | Fix check_clang_tidy.sh to pass shellcheckGravatar Mehrdad Afshari2017-12-19
| | |_|_|/ / / | |/| | | | |
| * | | | | | Merge pull request #13816 from mehrdada/sanitytest-shellcheckGravatar Mehrdad Afshari2017-12-19
| |\ \ \ \ \ \ | | |_|_|_|/ / | |/| | | | | Add a sanity test for shellcheck
| | | | | * | Create copy of "ac" data instead of stretching the locked sectionGravatar David Garcia Quintas2017-12-19
| | | | | | |
| | * | | | | Add a sanity test for shellcheckGravatar Mehrdad Afshari2017-12-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Start by checking the scripts in tools/run_tests/helper_scripts.
| | | | | * | Fix use-after-free caused by unsync'd access in tcp_client_posix.Gravatar David Garcia Quintas2017-12-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tc_on_alarm() and on_writable() race, resulting in the following: ``` D1219 08:59:33.425951347 86323 tcp_client_posix.cc:143] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_writable: error="No Error" D1219 08:59:33.426032150 86342 tcp_client_posix.cc:104] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_alarm: error="No Error" // At this point, note that the callbacks are running on different threads. D1219 08:59:33.426063521 86323 tcp_client_posix.cc:218] XXX on_writable ac->addr_str 0x603000008dd0 before unlock. # refs 2->1. Done 0 // on_writable() unrefs while still holding the lock. Because refs > 0, it marks its "done" as false and unlocks. D1219 08:59:33.426125130 86342 tcp_client_posix.cc:113] XXX tc_on_alarm ac->addr_str 0x603000008dd0 before unlock. # refs 1->0. Done 1 // right after on_writable() unlocks, tc_on_alarm() acquires the lock and unrefs, this time getting to zero and marking its "done" as true. // It then proceeds to destroy "ac", and, in particular for this failure, "ac->addr_str". D1219 08:59:33.426139370 86323 tcp_client_posix.cc:234] XXX on_writable about to read from ac->addr_str 0x603000008dd0. Done 0, error=OS Error // When on_writable() tries to read ac->addr_str to assemble its error details, it causes a use-after-free. ``` The problem is the lock isn't held long enough by on_writable(). Alternatively, a copy of ac->addr_str could be made in on_writable() while still holding the lock, but that seems more fragile. It doesn't seem that holding the lock longer would be a performance issue, given we are in a failure scenario.
| | | | | * | Fix another data race in client_lb_end2endGravatar David Garcia Quintas2017-12-19
| | | | | | |
| | | * | | | Fix internal TSAN bugGravatar Noah Eisen2017-12-19
| | |/ / / / | |/| | | |
| | | | * | fix tsan issue in client_lb_end2endGravatar David Garcia Quintas2017-12-18
| | | | | |
| * | | | | Merge pull request #13813 from dgquintas/disable_low_thread_countGravatar David G. Quintas2017-12-18
| |\ \ \ \ \ | | |/ / / / | |/| | | | Disabled the json_run_localhost:*_low_thread_count family of tests
| * | | | | Merge pull request #13798 from apolcyn/min_max_rpc_version_constantsGravatar apolcyn2017-12-18
| |\ \ \ \ \ | | | | | | | | | | | | | | Define RPC protocol version constants
| | | * | | | Disabled the json_run_localhost:*_low_thread_count family of testsGravatar David Garcia Quintas2017-12-18
| | |/ / / / | |/| | | |
| | | | * | Removed exec_ctx from new client_lb_end2end codeGravatar David Garcia Quintas2017-12-18
| | | | | |
| | * | | | Define RPC protocol version constantsGravatar Alexander Polcyn2017-12-18
| | | | | |
| * | | | | Merge pull request #13777 from frankyn/patch-1Gravatar apolcyn2017-12-18
| |\ \ \ \ \ | | | | | | | | | | | | | | [Ruby] Specify module init in README
| | | | | | * minor typo : becuase -> becauseGravatar ita9naiwa2017-12-19
| | |_|_|_|/ | |/| | | |
| * | | | | Merge pull request #13803 from apolcyn/mark_testonlyGravatar apolcyn2017-12-17
| |\ \ \ \ \ | | | | | | | | | | | | | | Mark two test binaries as testonly
| * \ \ \ \ \ Merge pull request #13793 from apolcyn/fix_ruby_distrib_retryGravatar apolcyn2017-12-15
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix failing ruby distrib tests
| * \ \ \ \ \ \ Merge pull request #11622 from mehrdada/shellckecGravatar Mehrdad Afshari2017-12-15
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix tools/run_tests/helper_scripts/*.sh to pass shellcheck
| * \ \ \ \ \ \ \ Merge pull request #13776 from ncteisen/executor-tsanGravatar Noah Eisen2017-12-15
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix shutdown executor tsan bug
| * \ \ \ \ \ \ \ \ Merge pull request #13771 from yang-g/deleteGravatar Yang Gao2017-12-15
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Mark tcp errors as UNAVAILABLE
| | | | * | | | | | | Fix run_tests_in_workspace.sh to pass shellcheckGravatar Mehrdad Afshari2017-12-15
| | | | | | | | | | |
| | | | * | | | | | | Fix run_grpc-node.sh to pass shellcheckGravatar Mehrdad Afshari2017-12-15
| | | | | | | | | | |
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 16:18:00 +0000