diff options
author | Yash Tibrewal <yashkt@google.com> | 2018-08-24 09:44:37 -0700 |
---|---|---|
committer | Yash Tibrewal <yashkt@google.com> | 2018-08-24 10:02:54 -0700 |
commit | d60a4b0f6b0d0d92944385bc9b629bb12aea24af (patch) | |
tree | 7df2b8b85cf83304ab75ba9a544c5f9b9a42edbe /src/core/lib | |
parent | 497532027dca770da60ac23e44f60ecf619cc2c5 (diff) |
Reviewer comments
Diffstat (limited to 'src/core/lib')
-rw-r--r-- | src/core/lib/surface/call.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/core/lib/surface/call.cc b/src/core/lib/surface/call.cc index 0b86a74340..e568ff3db4 100644 --- a/src/core/lib/surface/call.cc +++ b/src/core/lib/surface/call.cc @@ -690,11 +690,12 @@ static void set_final_status(grpc_call* call, grpc_error* error) { gpr_log(GPR_DEBUG, "%s", grpc_error_string(error)); } if (call->is_client) { - grpc_slice slice = grpc_empty_slice(); grpc_error_get_status(error, call->send_deadline, - call->final_op.client.status, &slice, nullptr, + call->final_op.client.status, + call->final_op.client.status_details, nullptr, call->final_op.client.error_string); - *call->final_op.client.status_details = grpc_slice_ref_internal(slice); + // explicitly take a ref + grpc_slice_ref_internal(*call->final_op.client.status_details); call->status_error = error; grpc_core::channelz::ChannelNode* channelz_channel = grpc_channel_get_channelz_node(call->channel); |