aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Jan Tattermusch <jtattermusch@google.com>2015-02-20 17:14:30 -0800
committerGravatar Jan Tattermusch <jtattermusch@google.com>2015-02-20 17:14:30 -0800
commitcad2782c6f64b93f2389d8126837102fb57bcdf0 (patch)
tree6215dc805846f8d7851addd1f2eb2d4bdd15db2c
parent213ecbfcfac56498fb9d1ac30885e88677dc3318 (diff)
Forgot to commit some files
-rw-r--r--tools/dockerfile/grpc_node_base/Dockerfile2
-rw-r--r--tools/dockerfile/grpc_ruby_base/Dockerfile5
2 files changed, 7 insertions, 0 deletions
diff --git a/tools/dockerfile/grpc_node_base/Dockerfile b/tools/dockerfile/grpc_node_base/Dockerfile
index 20efde98ad..e14e03143f 100644
--- a/tools/dockerfile/grpc_node_base/Dockerfile
+++ b/tools/dockerfile/grpc_node_base/Dockerfile
@@ -15,6 +15,8 @@ RUN cd /var/local/git/grpc && \
git pull --recurse-submodules && \
git submodule update --init --recursive
+# TODO: pre-building seems unnecessary, because we need to run make clean
+# anyway to prevent build from crashing if header files are added/removed.
# Build the C core
RUN make static_c shared_c -j12 -C /var/local/git/grpc
diff --git a/tools/dockerfile/grpc_ruby_base/Dockerfile b/tools/dockerfile/grpc_ruby_base/Dockerfile
index a3a80daf9b..0d872069d7 100644
--- a/tools/dockerfile/grpc_ruby_base/Dockerfile
+++ b/tools/dockerfile/grpc_ruby_base/Dockerfile
@@ -54,5 +54,10 @@ RUN cd /var/local/git/grpc/third_party/protobuf && \
./configure --prefix=/usr && \
make -j12 && make check && make install && make clean
+# TODO: pre-building seems unnecessary, because we need to run make clean
+# anyway to prevent build from crashing if header files are added/removed.
# Build the C core
RUN make static_c shared_c -j12 -C /var/local/git/grpc
+
+# Define the default command.
+CMD ["bash"]