diff options
| author |  Michael Lumish <mlumish@google.com> | 2017-05-30 08:15:14 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2017-05-30 08:15:14 -0700 |
| commit | 4ff54fa8af36cb4216d4064272597fd28108b31a (patch) | |
| tree | 1da4940f3817e7ae0523e335db1a8010c1195ae6 | |
| parent | 7563641414f490f0f66a6991fc3901319ddb172c (diff) | |
| parent | cce3ccc29ede38276628060ab9b819dbeaafe23f (diff) | |
Merge pull request #3 from apolcyn/flake_fix_master
Get rid of flakey asserts in num_watchers test
| -rw-r--r-- | test/core/surface/num_external_connectivity_watchers_test.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/test/core/surface/num_external_connectivity_watchers_test.c b/test/core/surface/num_external_connectivity_watchers_test.c index 96288ab60d..93944c9ad5 100644 --- a/test/core/surface/num_external_connectivity_watchers_test.c +++ b/test/core/surface/num_external_connectivity_watchers_test.c @@ -92,15 +92,12 @@ static void run_timeouts_test(const test_fixture *fixture) { /* start 1 watcher and then let it time out */ channel_idle_start_watch(channel, cq); - GPR_ASSERT(grpc_channel_num_external_connectivity_watchers(channel) == 1); channel_idle_poll_for_timeout(channel, cq); GPR_ASSERT(grpc_channel_num_external_connectivity_watchers(channel) == 0); /* start 3 watchers and then let them all time out */ for (size_t i = 1; i <= 3; i++) { channel_idle_start_watch(channel, cq); - GPR_ASSERT(grpc_channel_num_external_connectivity_watchers(channel) == - (int)i); } for (size_t i = 1; i <= 3; i++) { channel_idle_poll_for_timeout(channel, cq); @@ -111,14 +108,11 @@ static void run_timeouts_test(const test_fixture *fixture) { * time out */ for (size_t i = 1; i <= 3; i++) { channel_idle_start_watch(channel, cq); - GPR_ASSERT(grpc_channel_num_external_connectivity_watchers(channel) == - (int)i); } channel_idle_poll_for_timeout(channel, cq); for (size_t i = 3; i <= 5; i++) { channel_idle_start_watch(channel, cq); } - GPR_ASSERT(grpc_channel_num_external_connectivity_watchers(channel) >= 3); for (size_t i = 1; i <= 5; i++) { channel_idle_poll_for_timeout(channel, cq); } @@ -160,7 +154,6 @@ static void run_channel_shutdown_before_timeout_test( grpc_channel_watch_connectivity_state(channel, GRPC_CHANNEL_IDLE, connect_deadline, cq, (void *)1); - GPR_ASSERT(grpc_channel_num_external_connectivity_watchers(channel) == 1); grpc_channel_destroy(channel); grpc_event ev = |