From b947d97b47466c466da6add29385a8c60f2d4387 Mon Sep 17 00:00:00 2001 From: dmaclach Date: Thu, 13 Dec 2018 14:04:27 -0800 Subject: We should not be generating position dependent code. This is no longer standard for macOS or iOS. (#225) --- XcodeConfig/Target/LoadableBundle.xcconfig | 3 --- XcodeConfig/Target/SharedLibrary.xcconfig | 5 +---- XcodeConfig/Target/StaticLibrary.xcconfig | 3 --- XcodeConfig/subconfig/General.xcconfig | 3 --- 4 files changed, 1 insertion(+), 13 deletions(-) (limited to 'XcodeConfig') diff --git a/XcodeConfig/Target/LoadableBundle.xcconfig b/XcodeConfig/Target/LoadableBundle.xcconfig index 8b824d7..0b8e3d6 100644 --- a/XcodeConfig/Target/LoadableBundle.xcconfig +++ b/XcodeConfig/Target/LoadableBundle.xcconfig @@ -25,6 +25,3 @@ // Bundles should not have their external symbols stripped. STRIP_STYLE = non-global - -// Bundles need to be position independent -GCC_DYNAMIC_NO_PIC = NO diff --git a/XcodeConfig/Target/SharedLibrary.xcconfig b/XcodeConfig/Target/SharedLibrary.xcconfig index 7c37d50..9981d7b 100644 --- a/XcodeConfig/Target/SharedLibrary.xcconfig +++ b/XcodeConfig/Target/SharedLibrary.xcconfig @@ -22,8 +22,5 @@ // the License. // -// Dynamic libs need to be position independent -GCC_DYNAMIC_NO_PIC = NO - // Dynamic libs should not have their external symbols stripped. -STRIP_STYLE = non-global \ No newline at end of file +STRIP_STYLE = non-global diff --git a/XcodeConfig/Target/StaticLibrary.xcconfig b/XcodeConfig/Target/StaticLibrary.xcconfig index df1016b..2e40943 100644 --- a/XcodeConfig/Target/StaticLibrary.xcconfig +++ b/XcodeConfig/Target/StaticLibrary.xcconfig @@ -22,9 +22,6 @@ // the License. // -// Static libs can be included in bundles so make them position independent -GCC_DYNAMIC_NO_PIC = NO - // Static libs should not have their internal globals or external symbols // stripped. STRIP_STYLE = debugging diff --git a/XcodeConfig/subconfig/General.xcconfig b/XcodeConfig/subconfig/General.xcconfig index 1517514..59e60e6 100644 --- a/XcodeConfig/subconfig/General.xcconfig +++ b/XcodeConfig/subconfig/General.xcconfig @@ -48,9 +48,6 @@ GCC_ENABLE_OBJC_EXCEPTIONS = YES // not sure why apple defaults this on, but it's pretty risky ALWAYS_SEARCH_USER_PATHS = NO -// Turn on position dependent code for most cases (overridden where appropriate) -GCC_DYNAMIC_NO_PIC = YES - // For ObjC++ we want C++ cdtors called GCC_OBJC_CALL_CXX_CDTORS = YES -- cgit v1.2.3