From 911c457618377e675bbc89abbda97ffc13af1306 Mon Sep 17 00:00:00 2001 From: Thomas Van Lenten Date: Tue, 24 May 2016 10:02:33 -0400 Subject: Remove GTM_PERFORM_KVO_CHECKS. They have become too invasive and cause more issues than they were solving, especially on iOS where they seem to interact very badly with the accessibility provided by the OS. --- Foundation/GTMNSObject+KeyValueObservingTest.m | 53 -------------------------- 1 file changed, 53 deletions(-) (limited to 'Foundation/GTMNSObject+KeyValueObservingTest.m') diff --git a/Foundation/GTMNSObject+KeyValueObservingTest.m b/Foundation/GTMNSObject+KeyValueObservingTest.m index ba59a96..43a1bba 100644 --- a/Foundation/GTMNSObject+KeyValueObservingTest.m +++ b/Foundation/GTMNSObject+KeyValueObservingTest.m @@ -127,56 +127,3 @@ } @end - -#if GTM_PERFORM_KVO_CHECKS -@interface GTMNSObject_KeyValueObservingChecksTest: GTMTestCase { - @private - id value_; - id _value2; - GTM_WEAK NSArray *value3_; - GTM_WEAK NSString *value4; -} -- (NSString *)value4; -@end - -@implementation GTMNSObject_KeyValueObservingChecksTest - -- (void)setUp { - value_ = nil; - _value2 = nil; -} - -- (void)testAddingObserver { - [GTMUnitTestDevLogDebug expectPattern:@"warning:.*"]; - [self addObserver:self forKeyPath:@"value_" options:0 context:NULL]; - [GTMUnitTestDevLogDebug expectPattern:@"warning:.*"]; - [self addObserver:self forKeyPath:@"_value2" options:0 context:NULL]; - value3_ = [NSArray arrayWithObject:@"foo"]; - NSIndexSet *set = [NSIndexSet indexSetWithIndex:0]; - [GTMUnitTestDevLogDebug expectPattern:@"warning:.*"]; - [value3_ addObserver:self toObjectsAtIndexes:set forKeyPath:@"_fronttest" - options:0 context:NULL]; - [GTMUnitTestDevLogDebug expectPattern:@"warning:.*"]; - [value3_ addObserver:self toObjectsAtIndexes:set forKeyPath:@"backtest_" - options:0 context:NULL]; -#if DEBUG - // Should only throw in debug - STAssertThrows([self valueForKey:@"value_"], nil); -#else - STAssertNoThrow([self valueForKey:@"value_"], nil); -#endif - value4 = @"Hello"; - STAssertEqualObjects([self valueForKey:@"value4"], @"Hello", nil); - [self removeObserver:self forKeyPath:@"value_"]; - [self removeObserver:self forKeyPath:@"_value2"]; - [value3_ removeObserver:self fromObjectsAtIndexes:set forKeyPath:@"_fronttest"]; - [value3_ removeObserver:self fromObjectsAtIndexes:set forKeyPath:@"backtest_"]; -} - -- (NSString *)value4 { - return value4; -} -@end - -#endif // GTM_PERFORM_KVO_CHECKS - -- cgit v1.2.3