From 8b6fbb8fa94600574337580cd1c3d7511379b8d4 Mon Sep 17 00:00:00 2001 From: "gtm.daemon" Date: Wed, 10 Nov 2010 20:36:02 +0000 Subject: [Author: dmaclach] Fix up GTMHotKeyTextField so that it compiles cleanly with format string warnings on. Change to match other controls where string value always returns the empty string as opposed to nil. R=thomasvl DELTA=7 (4 added, 0 deleted, 3 changed) --- AppKit/GTMHotKeyTextField.m | 6 +++++- AppKit/GTMHotKeyTextFieldTest.m | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) (limited to 'AppKit') diff --git a/AppKit/GTMHotKeyTextField.m b/AppKit/GTMHotKeyTextField.m index df5853a..276f212 100644 --- a/AppKit/GTMHotKeyTextField.m +++ b/AppKit/GTMHotKeyTextField.m @@ -148,7 +148,11 @@ static CFStringRef kGTM_TISPropertyUnicodeKeyLayoutData = NULL; } - (NSString *)stringValue { - return [[self class] displayStringForHotKey:hotKey_]; + NSString *value = [[self class] displayStringForHotKey:hotKey_]; + if (!value) { + value = @""; + } + return value; } - (void)setStringValue:(NSString *)string { diff --git a/AppKit/GTMHotKeyTextFieldTest.m b/AppKit/GTMHotKeyTextFieldTest.m index 59c46f8..1bdc4cc 100644 --- a/AppKit/GTMHotKeyTextFieldTest.m +++ b/AppKit/GTMHotKeyTextFieldTest.m @@ -182,7 +182,7 @@ STAssertEquals([field intValue], 0, nil); STAssertEquals([field floatValue], 0.0f, nil); #if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5 - [GTMUnitTestDevLog expectString:expectedString]; + [GTMUnitTestDevLog expectString:@"%@", expectedString]; [field setIntegerValue:5]; STAssertEquals([field integerValue], (NSInteger)0, nil); #endif @@ -216,7 +216,7 @@ [GTMUnitTestDevLog expectString:@"Hot key fields don't accept formatters."]; [field setFormatter:testFormatter]; - [GTMUnitTestDevLog expectString:expectedString]; + [GTMUnitTestDevLog expectString:@"%@", expectedString]; [field takeObjectValueFrom:self]; // Setting to nil is valid. -- cgit v1.2.3