From e7b70553d40a8bb2f894ce311cf618826095c294 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 31 Oct 2014 16:14:12 -0400 Subject: Windows: Fix crash when user.name is not set in git config. --- .../getEffectiveUserID_not_supported_on_Windows.mdwn | 6 ++++++ .../comment_1_26cd277e6bbfcac920ca0a2a47acfcfd._comment | 17 ----------------- 2 files changed, 6 insertions(+), 17 deletions(-) delete mode 100644 doc/bugs/getEffectiveUserID_not_supported_on_Windows/comment_1_26cd277e6bbfcac920ca0a2a47acfcfd._comment (limited to 'doc') diff --git a/doc/bugs/getEffectiveUserID_not_supported_on_Windows.mdwn b/doc/bugs/getEffectiveUserID_not_supported_on_Windows.mdwn index 458c18b90..e8271ff94 100644 --- a/doc/bugs/getEffectiveUserID_not_supported_on_Windows.mdwn +++ b/doc/bugs/getEffectiveUserID_not_supported_on_Windows.mdwn @@ -20,3 +20,9 @@ Running Windows 7, x64. Also tried running as administrator and in a cmd.exe she ### Please provide any additional information below. The `git annex test` command does work, and all 84 tests passes. + +> [[fixed|done]]; I was able to reproduce this bug, and it was crashing +> trying to look up the geckos username. I don't understand why this worked +> before; some change exposed this code path on Windows. In any case, I've +> fixed the crash, and I will be updating the windows builds with this bug +> fix. --[[Joey]] diff --git a/doc/bugs/getEffectiveUserID_not_supported_on_Windows/comment_1_26cd277e6bbfcac920ca0a2a47acfcfd._comment b/doc/bugs/getEffectiveUserID_not_supported_on_Windows/comment_1_26cd277e6bbfcac920ca0a2a47acfcfd._comment deleted file mode 100644 index f9412487c..000000000 --- a/doc/bugs/getEffectiveUserID_not_supported_on_Windows/comment_1_26cd277e6bbfcac920ca0a2a47acfcfd._comment +++ /dev/null @@ -1,17 +0,0 @@ -[[!comment format=mdwn - username="joey" - subject="""comment 1""" - date="2014-10-31T16:57:05Z" - content=""" -This code path should only be called when USERPROFILE or -one of USERNAME/USER/LOGNAME is not set. Which should not usually be the case -when using git-annex on windows. - -However, since we know that won't work on Windows it might as well not even -try.. So I've made it instead print an error that indicates which -environment variables need to be set. - -Can you please download the windows daily build from -, and see what this new, -better error message says? -"""]] -- cgit v1.2.3