From c5c157803bf0119b697a662f278134c2bada3079 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 7 Jul 2013 13:35:06 -0400 Subject: Windows: Fix url to object when using a http remote. annexLocations uses OS-native directory separators, but for an url, it needs to use / even on Windows. This is an ugly workaround. Could parameterize a lot of stuff in annexLocations to fix it better. I suspect this is probably the only place it's needed though. --- ...ails_with_HTTP_Remote__44___but_believes_it_has_succeeded..mdwn | 7 +++++++ ...___annex_get_over_HTTP_sends_URLs_with_incorrect_separator.mdwn | 2 ++ 2 files changed, 9 insertions(+) (limited to 'doc/bugs') diff --git a/doc/bugs/On_Windows__44___annex_get_fails_with_HTTP_Remote__44___but_believes_it_has_succeeded..mdwn b/doc/bugs/On_Windows__44___annex_get_fails_with_HTTP_Remote__44___but_believes_it_has_succeeded..mdwn index 9604042e2..b34befcc0 100644 --- a/doc/bugs/On_Windows__44___annex_get_fails_with_HTTP_Remote__44___but_believes_it_has_succeeded..mdwn +++ b/doc/bugs/On_Windows__44___annex_get_fails_with_HTTP_Remote__44___but_believes_it_has_succeeded..mdwn @@ -171,3 +171,10 @@ C:\Users\test-git-annex\test_annex>type file1.txt 192.168.0.2 - - [] "GET /test_annex/.git/annex\objects\c96\53e\SHA256-s21--6ed275e9e01c84a57fdd99d6af793c5d587d02e699cd2c28b32b7dc90f73e729\SHA256-s21--6ed275e9e01c84a57fdd99d6af793c5d587d02e699cd2c28b32b7dc90f73e729 HTTP/1.1" 404 - 192.168.0.2 - - [] code 404, message File not found """]] + +> This seems to be two distinct bugs. First, curl was not propigating the exit +> status. I already fixed that. +> +> Second, it's using DOS style path separators when constructing the url. +> `http://192.168.0.8:8000/test_annex/.git/annex\\objects\\c96` +> I've put in an (ugly) fix for that. [[done]] --[[Joey]] diff --git a/doc/bugs/On_Windows__44___annex_get_over_HTTP_sends_URLs_with_incorrect_separator.mdwn b/doc/bugs/On_Windows__44___annex_get_over_HTTP_sends_URLs_with_incorrect_separator.mdwn index 5b97cfa1e..08bc76ed1 100644 --- a/doc/bugs/On_Windows__44___annex_get_over_HTTP_sends_URLs_with_incorrect_separator.mdwn +++ b/doc/bugs/On_Windows__44___annex_get_over_HTTP_sends_URLs_with_incorrect_separator.mdwn @@ -182,3 +182,5 @@ git-annex: get: 1 failed 192.168.0.2 - - [] code 404, message File not found 192.168.0.2 - - [] "GET /test_annex/.git/annex%5Cobjects%5CJ9%5Cm6%5CSHA256-s21--6ed275e9e01c84a57fdd99d6af793c5d587d02e699cd2c28b32b7dc90f73e729%5CSHA256-s21--6ed275e9e01c84a57fdd99d6af793c5d587d02e699cd2c28b32b7dc90f73e729 HTTP/1.1" 404 - """]] + +> [[fixed|done]] --[[Joey]] -- cgit v1.2.3