From 1396113ccbb6be895b1deb7c7eec228323e47078 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 16 Jul 2015 15:01:10 -0400 Subject: Fix bug that prevented uploads to remotes using new-style chunking from resuming after the last successfully uploaded chunk. "checkPresent baser" was wrong; the baser has a dummy checkPresent action not the real one. So, to fix this, we need to call preparecheckpresent to get a checkpresent action that can be used to check if chunks are present. Note that, for remotes like S3, this means that the preparer is run, which opens a S3 handle, that will be used for each checkpresent of a chunk. That's a good thing; if we're resuming an upload that's already many chunks in, it'll reuse that same http connection for each chunk it checks. Still, it's not a perfectly ideal thing, since this is a different http connection that the one that will be used to upload chunks. It would be nice to improve the API so that both use the same http connection. --- debian/changelog | 2 ++ 1 file changed, 2 insertions(+) (limited to 'debian') diff --git a/debian/changelog b/debian/changelog index d8e468dc8..e494f9ced 100644 --- a/debian/changelog +++ b/debian/changelog @@ -3,6 +3,8 @@ git-annex (5.20150714) UNRELEASED; urgency=medium * Improve bash completion code so that "git annex" will also tab complete. However, git's bash completion script needs a patch, which I've submitted, for this to work prefectly. + * Fix bug that prevented uploads to remotes using new-style chunking + from resuming after the last successfully uploaded chunk. -- Joey Hess Thu, 16 Jul 2015 14:55:07 -0400 -- cgit v1.2.3