From b44e74ace2d74954c503930b9edb75d0aa9d7b52 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 20 Aug 2014 11:25:07 -0400 Subject: Ensure that all lock fds are close-on-exec, fixing various problems with them being inherited by child processes such as git commands. (With the exception of daemon pid locking.) This fixes at part of #758630. I reproduced the assistant locking eg, a removable drive's annex journal lock file and forking a long-running git-cat-file process that inherited that lock. This did not affect Windows. Considered doing a portable Utility.LockFile layer, but git-annex uses posix locks in several special ways that have no direct Windows equivilant, and it seems like it would mostly be a complication. This commit was sponsored by Protonet. --- Remote/Helper/Hooks.hs | 1 + 1 file changed, 1 insertion(+) (limited to 'Remote') diff --git a/Remote/Helper/Hooks.hs b/Remote/Helper/Hooks.hs index 907400bd1..150e9efd2 100644 --- a/Remote/Helper/Hooks.hs +++ b/Remote/Helper/Hooks.hs @@ -86,6 +86,7 @@ runHooks r starthook stophook a = do mode <- annexFileMode fd <- liftIO $ noUmask mode $ openFd lck ReadWrite (Just mode) defaultFileFlags + setFdOption fd CloseOnExec True v <- liftIO $ tryIO $ setLock fd (WriteLock, AbsoluteSeek, 0, 0) case v of -- cgit v1.2.3